From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7469D1B51E; Fri, 23 Nov 2018 11:55:42 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BFF64800065; Fri, 23 Nov 2018 10:55:40 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 23 Nov 2018 10:55:34 +0000 To: Thomas Monjalon , CC: Ferruh Yigit , , "Stephen Hemminger" , References: <20181106214901.1392-2-stephen@networkplumber.org> <20181123002945.36697-1-ferruh.yigit@intel.com> <1550603.EXdslK9Pks@xps> From: Andrew Rybchenko Message-ID: Date: Fri, 23 Nov 2018 13:55:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1550603.EXdslK9Pks@xps> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24240.003 X-TM-AS-Result: No-10.164800-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/sOwH4pD14DsPHkpkyUphL9OhJ9m53n4aAdTIwEQt3c48lQ VvH1JO6TjFALQ7SG7YJPl68/zJltcd1bJb6nwrziVU3yVpaj3Qxgp5U7towQcweLCIX046iBSrJ TO1VGhMF2+AZuxakJy89fuxSQqqSyyA1ihY42R28vj6wHfIGxyQhRCJFb9cuseVCAkHLwRePFM8 3SLuKMYU3o+3zb2hKg/76CM4Z/MGblRxm3A2wKujl/1fD/GopdcmfM3DjaQLHZs3HUcS/scLyah 9aCYUCH+KIx1Lpl9DDBgJfeI3a56dc+Th8U7SurOAAwAGHfrEEiYA265V+dAQAywX4xuqgHe9oM URy8vtk/Go5QJwEbRgivjPxperVb X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.164800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24240.003 X-MDID: 1542970541-jIaVORzvQlLA Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix allocation of PCI device path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 10:55:43 -0000 On 11/23/18 1:45 PM, Thomas Monjalon wrote: > Please, anyone for a review and a test? > > 23/11/2018 01:29, Ferruh Yigit: >> The pci_resource_by_index called strlen() on uninitialized >> memory which would lead to the wrong size of memory allocated >> for the path portion of the resource map. This would either cause >> excessively large allocation, or worse memory corruption. >> >> Coverity Issue: 300868 >> Fixes: ea9d56226e72 ("pci: introduce function to map uio resource by index") >> Cc: stable@dpdk.org >> >> Signed-off-by: Stephen Hemminger >> Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko