From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B96662BAE for ; Mon, 11 Dec 2017 11:43:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 02:43:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1833159" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 02:43:05 -0800 To: Marko Kovacevic , dev@dpdk.org References: <20171128132203.43181-1-marko.kovacevic@intel.com> From: "Hunt, David" Message-ID: Date: Mon, 11 Dec 2017 10:43:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171128132203.43181-1-marko.kovacevic@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 10:43:08 -0000 Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: --snip-- > > int > -guest_channel_host_connect(const char *path, unsigned lcore_id) > +guest_channel_host_connect(const char *path, unsigned int lcore_id) --snip-- I'd suggest adding the following into the commit message. It would help explain why you're doing all the "unsigned" to "unsigned int" changes up front rather than including them in the other patches. "Since this patch-set attempts to clean up the power library, and there are many instances of "unsigned" caught by checkpatch, it was decided to clean these up first rather than have them included in the later patches in the patch set. And would also minimise this type of error being caught by checkpatch in the future." Regards, Dave.