* [dpdk-dev] [PATCH] net/pcap: fix memory leak
@ 2019-01-30 1:08 Qi Zhang
2019-01-30 11:30 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2019-01-30 1:08 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Qi Zhang, stable
Fix potential memory leak due to kvlist not be freed.
Fixes: 0d0dd2d9d8ff ("net/pcap: enable data path for secondary process")
Cc: stable@dpdk.org
Reported-by: Gage Eads <gage.eads@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/pcap/rte_eth_pcap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 9fd932772..65bbd7e2f 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1258,7 +1258,8 @@ pmd_pcap_probe(struct rte_vdev_device *dev)
if (pp == NULL) {
PMD_LOG(ERR,
"Failed to allocate memory for process private");
- return -1;
+ ret = -1;
+ goto free_kvlist;
}
eth_dev->dev_ops = &ops;
@@ -1281,7 +1282,7 @@ pmd_pcap_probe(struct rte_vdev_device *dev)
eth_dev->tx_pkt_burst = eth_pcap_tx;
rte_eth_dev_probing_finish(eth_dev);
- return 0;
+ goto free_kvlist;
}
ret = eth_from_pcaps(dev, &pcaps, pcaps.num_of_queue, &dumpers,
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/pcap: fix memory leak
2019-01-30 1:08 [dpdk-dev] [PATCH] net/pcap: fix memory leak Qi Zhang
@ 2019-01-30 11:30 ` Ferruh Yigit
2019-02-07 12:29 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2019-01-30 11:30 UTC (permalink / raw)
To: Qi Zhang; +Cc: dev, stable
On 1/30/2019 1:08 AM, Qi Zhang wrote:
> Fix potential memory leak due to kvlist not be freed.
>
> Fixes: 0d0dd2d9d8ff ("net/pcap: enable data path for secondary process")
> Cc: stable@dpdk.org
>
> Reported-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/pcap: fix memory leak
2019-01-30 11:30 ` Ferruh Yigit
@ 2019-02-07 12:29 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-02-07 12:29 UTC (permalink / raw)
To: Qi Zhang; +Cc: dev, stable
On 1/30/2019 11:30 AM, Ferruh Yigit wrote:
> On 1/30/2019 1:08 AM, Qi Zhang wrote:
>> Fix potential memory leak due to kvlist not be freed.
>>
>> Fixes: 0d0dd2d9d8ff ("net/pcap: enable data path for secondary process")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Gage Eads <gage.eads@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-07 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 1:08 [dpdk-dev] [PATCH] net/pcap: fix memory leak Qi Zhang
2019-01-30 11:30 ` Ferruh Yigit
2019-02-07 12:29 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).