From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 620B61B11F for ; Wed, 3 Oct 2018 18:09:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 09:09:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="79576233" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga006.jf.intel.com with ESMTP; 03 Oct 2018 09:09:25 -0700 To: keith.wiles@intel.com References: <20180803140605.43072-1-keith.wiles@intel.com> Cc: dpdk-dev , Thomas Monjalon From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Wed, 3 Oct 2018 17:09:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180803140605.43072-1-keith.wiles@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 16:09:28 -0000 On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: > Signed-off-by: Keith Wiles > --- > lib/librte_eal/common/include/rte_common.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h > index 069c13ec7..2c4535b1a 100644 > --- a/lib/librte_eal/common/include/rte_common.h > +++ b/lib/librte_eal/common/include/rte_common.h > @@ -68,6 +68,11 @@ typedef uint16_t unaligned_uint16_t; > /******* Macro to mark functions and fields scheduled for removal *****/ > #define __rte_deprecated __attribute__((__deprecated__)) > > +/** > + * short definition to mark a function or variable to a weak reference. > + */ > +#define __rte_weak __attribute__((__weak__)) Looks good to me. Reviewed-by: Ferruh Yigit Since the change is all mechanical same change in further patches, what do you think merging this patchset into single patch?