From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F12C0A0C43; Thu, 23 Sep 2021 15:53:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 812C441260; Thu, 23 Sep 2021 15:53:06 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D2F5641257 for ; Thu, 23 Sep 2021 15:53:04 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HFc2T6bG7zbmfs for ; Thu, 23 Sep 2021 21:48:49 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 23 Sep 2021 21:53:02 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 23 Sep 2021 21:53:02 +0800 To: Kevin Laatz , CC: , References: <20210910172737.2561156-1-kevin.laatz@intel.com> <20210917164136.3499904-1-kevin.laatz@intel.com> From: fengchengwen Message-ID: Date: Thu, 23 Sep 2021 21:53:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210917164136.3499904-1-kevin.laatz@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kevin, Can you add the following functions? 1. Add dump dmadev which trigger by signal, like: ... static void dma_dump(void) { uint32_t i, j; if (copy_mode != COPY_MODE_DMA_NUM) return; for (i = 0; i < cfg.nb_ports; i++) { for (j = 0; j < cfg.ports[i].nb_queues; j++) rte_dma_dump(cfg.ports[i].dmadev_ids[j], stdout); } } ... static void signal_handler(int signum) { if (signum == SIGINT || signum == SIGTERM) { printf("\n\nSignal %d received, preparing to exit...\n", signum); force_quit = true; } else if (signum == SIGUSR1) { dma_dump(); } } ... signal(SIGUSR1, signal_handler); 2. Controls the output frequency of print_stats. currently fix 1s, hope could control by parameters. Thanks. On 2021/9/18 0:41, Kevin Laatz wrote: > This patchset first adds some additional command line options to the > existing ioatfwd application to enhance usability. > > The last 3 patches of this set then port the ioatfwd application to use the > dmadev library APIs instead of the IOAT rawdev APIs. Following the port, > all variables etc are renamed to be more appropriate for using with the > DMAdev library. Lastly, the application itself is renamed to "dmafwd". > > Depends-on: series-18960 ("support dmadev") > > Kevin Laatz (3): > examples/ioat: port application to dmadev APIs > examples/ioat: update naming to match change to dmadev > examples/ioat: rename application to dmafwd > > Konstantin Ananyev (3): > examples/ioat: always use same lcore for both DMA requests enqueue and > dequeue > examples/ioat: add cmd-line option to control DMA batch size > examples/ioat: add cmd line option to control max frame size > > MAINTAINERS | 7 +- > .../sample_app_ug/{ioat.rst => dma.rst} | 114 ++-- > doc/guides/sample_app_ug/index.rst | 2 +- > doc/guides/sample_app_ug/intro.rst | 4 +- > examples/{ioat => dma}/Makefile | 4 +- > examples/{ioat/ioatfwd.c => dma/dmafwd.c} | 586 +++++++++--------- > examples/{ioat => dma}/meson.build | 10 +- > examples/meson.build | 2 +- > 8 files changed, 380 insertions(+), 349 deletions(-) > rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (73%) > rename examples/{ioat => dma}/Makefile (97%) > rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (63%) > rename examples/{ioat => dma}/meson.build (63%) >