From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 340DC1B1F6 for ; Mon, 2 Oct 2017 12:29:02 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2017 03:29:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,469,1500966000"; d="scan'208";a="1225987449" Received: from nikhilr-mobl.amr.corp.intel.com (HELO [10.252.169.48]) ([10.252.169.48]) by fmsmga002.fm.intel.com with ESMTP; 02 Oct 2017 03:28:57 -0700 From: "Rao, Nikhil" To: Jerin Jacob Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com References: <1506028634-22998-1-git-send-email-nikhil.rao@intel.com> <1506028634-22998-4-git-send-email-nikhil.rao@intel.com> <20170922091032.GA5895@jerin> <92c090c8-b024-dc9f-6d76-59d4b44ab3f5@intel.com> Message-ID: Date: Mon, 2 Oct 2017 15:58:56 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <92c090c8-b024-dc9f-6d76-59d4b44ab3f5@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 10:29:03 -0000 On 9/25/2017 8:29 AM, Rao, Nikhil wrote: > On 9/24/2017 11:46 PM, Rao, Nikhil wrote: >> On 9/22/2017 2:40 PM, Jerin Jacob wrote: >> >>> When we worked on a prototype, we figured out that we need a separate >>> event type >>> for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? >>> The Reason is: >>> - In the HW based Rx adapter case, the packet are coming directly to >>> eventdev once it is configured. >>> - So on a HW implementation of the event dequeue(), CPU needs to >>> convert HW specific >>> metadata to mbuf >>> - The event dequeue() is used in two cases >>> a) octeontx eventdev driver used with any external NIC >>> b) octeontx eventdev driver used with integrated NIC(without service >>> core to inject the packet) >>> We need some identifier to understand case (a) and (b).So, in >>> dequeue(), if the >>> packet is from RTE_EVENT_TYPE_ETHDEV then we can do "HW specific >>> metadata" to mbuf >>> conversion and in another case (!RTE_EVENT_TYPE_ETHDEV) result in no >>> mbuf >>> conversion. >>> >>> Application can check if it is an Ethernet type event by >>> ev.event_type == RTE_EVENT_TYPE_ETHDEV || ev.event_type == >>> RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER >>> >> >> As per my understanding, the case (a) uses an in built port >> Is it possible for the eventdev PMD to do the conversion based off the >> eventdev port ? >> > > I realized the dequeue wouldn't have knowledge of the port the event was > injected from, the application shouldn't have to see the difference > between case (a) & (b). > > Would it be possible to use the impl_opaque field within struct rte_event ? > > Nikhil Hi Jerin, Any further thoughts on this ? Nikhil