From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD9B41D41; Wed, 22 Feb 2023 18:55:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C264C43056; Wed, 22 Feb 2023 18:55:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8ECB143047 for ; Wed, 22 Feb 2023 18:55:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677088532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U35iG1Z6cKGECKaO3HZK1FfNfWuyP5N93kgIaU9gY9k=; b=Pil7nOLLm1W353Q3xzhEyFhS9L81ZD2paKfxrLblMSWYpr27RxpO/W4l7fW6XURWuv7LNb qz7oglcHaZptFdLxr+ZMY6LuQFs8sbXXSKpHQLIfJPKDZ2Noils6NsJw3C9X0K5oMO0r5q PjSLQnaB/BgsYS1jvJDFwjAekkNbLxM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-106-NWA6b0g1N4KjOL32u_AiWw-1; Wed, 22 Feb 2023 12:55:28 -0500 X-MC-Unique: NWA6b0g1N4KjOL32u_AiWw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9CE1B18E53C4; Wed, 22 Feb 2023 17:55:27 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EFE42026D38; Wed, 22 Feb 2023 17:55:25 +0000 (UTC) Message-ID: Date: Wed, 22 Feb 2023 18:55:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 2/3] baseband/acc: remove unused ops check To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com References: <20230222164043.170909-1-hernan.vargas@intel.com> <20230222164043.170909-3-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230222164043.170909-3-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/22/23 17:40, Hernan Vargas wrote: > Remove unnecessary debug check for ops. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index baab459436..c242f7737a 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,10 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > -#ifdef RTE_LIBRTE_BBDEV_DEBUG > - if (unlikely(ops == 0)) > - return 0; > -#endif > op = acc_op_tail(q, 0); > if (unlikely(ops == NULL || op == NULL)) > return 0; Reviewed-by: Maxime Coquelin Thanks, Maxime