From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F69646C32; Mon, 28 Jul 2025 13:31:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A27F40430; Mon, 28 Jul 2025 13:31:54 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id A2B064026C for ; Mon, 28 Jul 2025 13:31:52 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7DE2152B; Mon, 28 Jul 2025 04:31:43 -0700 (PDT) Received: from [10.1.35.56] (JR4XG4HTQC-2.cambridge.arm.com [10.1.35.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C117B3F66E; Mon, 28 Jul 2025 04:31:50 -0700 (PDT) Message-ID: Date: Mon, 28 Jul 2025 12:31:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dts: call hugepages configure at testrun setup Content-Language: en-GB To: Patrick Robb Cc: dmarx@iol.unh.edu, Paul.Szczepanek@arm.com, abailey@iol.unh.edu, mmahajan@iol.unh.edu, thomas.wilks@arm.com, dev@dpdk.org References: <20250725200553.1262542-1-probb@iol.unh.edu> From: Luca Vizzarro In-Reply-To: <20250725200553.1262542-1-probb@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Really good catch Patrick! Thank you for this! Would it make more sense to place setup_hugepages under Node.setup()? In that case the method can also remain private, involving a single line change. Reviewed-by: Luca Vizzarro