From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ED77A0A02; Thu, 15 Apr 2021 03:58:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6834161EF0; Thu, 15 Apr 2021 03:58:46 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id F054A161E73 for ; Thu, 15 Apr 2021 03:58:44 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FLMr52TxlzpYCx for ; Thu, 15 Apr 2021 09:55:49 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 15 Apr 2021 09:58:38 +0800 To: Ferruh Yigit , References: <1618314611-47978-1-git-send-email-humin29@huawei.com> <1618314611-47978-11-git-send-email-humin29@huawei.com> <698abc7a-8c81-de22-7b20-7c2526ec3391@intel.com> From: "Min Hu (Connor)" Message-ID: Date: Thu, 15 Apr 2021 09:58:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <698abc7a-8c81-de22-7b20-7c2526ec3391@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 10/12] net/hns3: rename Rx burst API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/15 1:41, Ferruh Yigit 写道: > On 4/13/2021 12:50 PM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Currently, user could use runtime config "rx_func_hint=simple" to >> select the hns3_recv_pkts API, but the API's name get from >> rte_eth_rx_burst_mode_get is "Scalar" which has not reflected "simple". >> >> So this patch renames hns3_recv_pkts to hns3_recv_pkts_simple, and >> also change it's name which gets from rte_eth_rx_burst_mode_get to >> "Scalar Simple" to maintain conceptual consistency. >> >> Also changes the hns3_recv_scattered_pkts API's name which gets from >> rte_eth_rx_burst_mode_get to "Scalar". >> >> Fixes: 521ab3e93361 ("net/hns3: add simple Rx path") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) > > <...> > >> @@ -2743,10 +2745,10 @@ hns3_rx_burst_mode_get(struct rte_eth_dev >> *dev, __rte_unused uint16_t queue_id, >>           eth_rx_burst_t pkt_burst; >>           const char *info; >>       } burst_infos[] = { >> -        { hns3_recv_pkts,        "Scalar" }, >> -        { hns3_recv_scattered_pkts,    "Scalar Scattered" }, >> -        { hns3_recv_pkts_vec,        "Vector Neon" }, >> -        { hns3_recv_pkts_vec_sve,    "Vector Sve" }, >> +        { hns3_recv_pkts_simple,    "Scalar Simple" }, >> +        { hns3_recv_scattered_pkts,    "Scalar"        }, >> +        { hns3_recv_pkts_vec,        "Vector Neon"   }, >> +        { hns3_recv_pkts_vec_sve,    "Vector Sve"    }, > > No concern on the burst function rename, that is driver internal, but > related to the above change, I think new value "Scalar Simple" is not > clear, what does 'Simple' mean? > At least previously "Scalar Scattered" vs "Scalar" was more clear, one > can easily say difference is scattered Rx support, but with "Scalar" vs > "Scalar Simple" the difference is not clear. > Agreed to retain the hns3_recv_scattered_pkts name "Scalar Scattered", but suggests changing the hns3_recv_pkts_simple name to "Scalar Simple" for the following reasons: 1. Currently, the transmit and receive algorithms implemented in C language only process single-BD algorithms. The Rx direction is Scalar, while the Tx direction is Scalar Simple. The two do not correspond with each other. 2. The algorithm name selected by using rx_func_hint=simple does not contain simple. The DPDK user may be confused. BTW, v2 has been sent, please check it out, thanks. > .