Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/28/2019 5:51 AM, Yang, Qiming wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Di, ChenxuX
>> Sent: Thursday, October 24, 2019 9:03 AM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>
>> Subject: [PATCH] app/testpmd: fix device hotplug remove
>>
>> Hotplug remove cause infinite loops. Fix by canceling port_close  before
>> port_detach function when rmv_port_callback.
>>
>> Fixes: ac89d46096d5 ("net/i40e: release port upon close")
>>
>> Signed-off-by: Di ChenxuX <chenxux.di@intel.com>
>> ---
>>  app/test-pmd/testpmd.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
>> 5701f3141..a264644a1 100644
>> --- a/app/test-pmd/testpmd.c
>> +++ b/app/test-pmd/testpmd.c
>> @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg)
>>  	no_link_check = 1;
>>  	stop_port(port_id);
>>  	no_link_check = org_no_link_check;
>> -	close_port(port_id);
>>  	detach_port_device(port_id);
>>  	if (need_to_start)
>>  		start_packet_forwarding(0);
>> --
>> 2.17.1
> 
> NACK, this patch is not acceptable.
> 

I can't really follow what is the root cause of the failure here, @Qiming, if it
is a driver issue, can you please briefly describe what is wrong in the driver?

Thanks,
ferruh