From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 527D42E41
 for <dev@dpdk.org>; Fri,  4 Aug 2017 13:40:45 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 Aug 2017 04:40:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="133550889"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by orsmga005.jf.intel.com with ESMTP; 04 Aug 2017 04:40:43 -0700
To: "Mcnamara, John" <john.mcnamara@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
References: <20170720092303.97525-1-ferruh.yigit@intel.com>
 <46961328.cqyKbn3m1e@xps> <628b3af4-6c4e-f262-110d-f899f0422501@intel.com>
 <1557856.DY0fuUa5Sa@xps>
 <B27915DBBA3421428155699D51E4CFE23ED5AA4C@IRSMSX103.ger.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <b495372b-8523-d5b6-48c5-8937da776064@intel.com>
Date: Fri, 4 Aug 2017 12:40:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ED5AA4C@IRSMSX103.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2017 11:40:46 -0000

On 8/4/2017 12:11 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Friday, August 4, 2017 10:32 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Olivier Matz
>> <olivier.matz@6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features
>>
>> 04/08/2017 10:56, Ferruh Yigit:
>>> On 8/3/2017 11:57 PM, Thomas Monjalon wrote:
>>>> 01/08/2017 17:23, Ferruh Yigit:
>>>>> +:orphan:
>>>>> +
>>>>> +.. _nic_overview_features:
>>>>
>>>> Why have you done an orphan page?
>>>> I think it should be in doc/guides/nics/overview.rst
>>>
>>> There is a link from nics/overview.rst to this file. But this file is
>>> not in the index and not making it orphan is causing a build warning.
>>
>> But why creating a new page?
>> It could be below the table in overview.rst.
> 
> For me it makes more sense on a separate page. It isn't really overview material.
> 
> However, thinking about it again I think that it should be included in the index
> instead of using the :orphan: directive. Maybe after the compilation chapter/page.

I will send a new version that has been included into index.

Thanks,
ferruh

> 
> John
>