From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99DD4A0C4E; Thu, 22 Jul 2021 12:32:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32D9A4014E; Thu, 22 Jul 2021 12:32:42 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id D6AA34014D for ; Thu, 22 Jul 2021 12:32:40 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 90A5C7F514; Thu, 22 Jul 2021 13:32:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 90A5C7F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1626949960; bh=Ymj+r0Eylzbe7t0vgB/oRX18BffOAS/66mIwr57psts=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=l9AuIr+4b9cm5gzLMjQ1gFGaGyTkjB/FCAo63UfCiQ8FbOyb9EB/1gKKpqpAsV9er /jQTLOdx8Gy0SJX2+h2nmZIrDN469R/e+IwYcz3UmRunR+An7nkC1YptDSw3o/VdBg jXBYhCgfVTN6+ochp0TV/kFVJDDI7vQZvF9tD0sk= To: Martin Havlik , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Thomas Monjalon , Asaf Penso , Jiawei Wang , Bing Zhao , Xueming Li , Tal Shnaiderman , Shun Hao , Ciara Power , Bruce Richardson , Michael Baum , Raslan Darawsheh Cc: dev@dpdk.org, Jan Viktorin References: <20210721155550.188663-2-xhavli56@stud.fit.vutbr.cz> From: Andrew Rybchenko Message-ID: Date: Thu, 22 Jul 2021 13:32:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210721155550.188663-2-xhavli56@stud.fit.vutbr.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] doc: clarify RTE flow behaviour on port stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/21/21 6:55 PM, Martin Havlik wrote: > It is now clearly stated that RTE flow rules can be > created only after the port is started. > > Signed-off-by: Martin Havlik > --- > doc/guides/nics/mlx5.rst | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index f5b727c1ee..119d537adf 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -1790,21 +1790,25 @@ Notes for rte_flow > ------------------ > > Flows are not cached in the driver. > When stopping a device port, all the flows created on this port from the > application will be flushed automatically in the background. > After stopping the device port, all flows on this port become invalid and > not represented in the system. > All references to these flows held by the application should be discarded > directly but neither destroyed nor flushed. > > -The application should re-create the flows as required after the port restart. > +The application should re-create the flows as required after the port is > +started again. > + > +Creating flows before port start is not permitted. All flows the application > +wants to create have to be created after the port is started. I'm not 100% sure that it is always OK for applications, but in an attempt to make it OK we should: - mention isolated mode if application dislikes default flow rules and would like to control it - mention what happens if restart happens internally, e.g. in order to recover from broken state. I guess in this case we need an event and application must register callback and handle it. > > Notes for testpmd > ----------------- > > Compared to librte_net_mlx4 that implements a single RSS configuration per > port, librte_net_mlx5 supports per-protocol RSS configuration. > > Since ``testpmd`` defaults to IP RSS mode and there is currently no > command-line parameter to enable additional protocols (UDP and TCP as well > as IP), the following commands must be entered from its CLI to get the same >