* [PATCH] ethdev: fix flow action async query coverity
@ 2023-10-17 8:23 Suanming Mou
2023-10-17 12:21 ` Ori Kam
0 siblings, 1 reply; 3+ messages in thread
From: Suanming Mou @ 2023-10-17 8:23 UTC (permalink / raw)
To: Ori Kam, Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko; +Cc: dev
This commit adds the ops chcek to fix the coverity issue.
Coverity issue: 403258
Fixes: c9dc03840873 ("ethdev: add indirect action async query")
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
lib/ethdev/rte_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index 874f845513..3a67f1aaba 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t port_id,
const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
int ret;
+ if (unlikely(!ops))
+ return -rte_errno;
ret = ops->async_action_handle_query(dev, queue_id, op_attr,
action_handle, data, user_data, error);
ret = flow_err(port_id, ret, error);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] ethdev: fix flow action async query coverity
2023-10-17 8:23 [PATCH] ethdev: fix flow action async query coverity Suanming Mou
@ 2023-10-17 12:21 ` Ori Kam
2023-10-17 13:18 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ori Kam @ 2023-10-17 12:21 UTC (permalink / raw)
To: Suanming Mou, NBU-Contact-Thomas Monjalon (EXTERNAL),
Ferruh Yigit, Andrew Rybchenko
Cc: dev
Hi Suanming,
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Tuesday, October 17, 2023 11:23 AM
>
> This commit adds the ops chcek to fix the coverity issue.
>
> Coverity issue: 403258
> Fixes: c9dc03840873 ("ethdev: add indirect action async query")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
> lib/ethdev/rte_flow.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> index 874f845513..3a67f1aaba 100644
> --- a/lib/ethdev/rte_flow.c
> +++ b/lib/ethdev/rte_flow.c
> @@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t
> port_id,
> const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
> int ret;
>
> + if (unlikely(!ops))
> + return -rte_errno;
> ret = ops->async_action_handle_query(dev, queue_id, op_attr,
> action_handle, data, user_data,
> error);
> ret = flow_err(port_id, ret, error);
> --
> 2.34.1
Acked-by: Ori Kam <orika@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ethdev: fix flow action async query coverity
2023-10-17 12:21 ` Ori Kam
@ 2023-10-17 13:18 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-10-17 13:18 UTC (permalink / raw)
To: Ori Kam, Suanming Mou, NBU-Contact-Thomas Monjalon (EXTERNAL),
Andrew Rybchenko
Cc: dev
On 10/17/2023 1:21 PM, Ori Kam wrote:
> Hi Suanming,
>
>> -----Original Message-----
>> From: Suanming Mou <suanmingm@nvidia.com>
>> Sent: Tuesday, October 17, 2023 11:23 AM
>>
>> This commit adds the ops chcek to fix the coverity issue.
>>
>> Coverity issue: 403258
>> Fixes: c9dc03840873 ("ethdev: add indirect action async query")
>>
>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
>
> Acked-by: Ori Kam <orika@nvidia.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-17 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 8:23 [PATCH] ethdev: fix flow action async query coverity Suanming Mou
2023-10-17 12:21 ` Ori Kam
2023-10-17 13:18 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).