From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B5C42A09; Wed, 26 Apr 2023 18:58:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B81C410FA; Wed, 26 Apr 2023 18:58:13 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2072.outbound.protection.outlook.com [40.107.100.72]) by mails.dpdk.org (Postfix) with ESMTP id 33F524068E for ; Wed, 26 Apr 2023 18:58:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0LDgbc/2nkNOViBLDPphyNkvRAdipGJooUVeKVk3J0uLPPupmaycqxjf04Ay91l9OEspCLIABQQyWOfQokc0l636ONiRFKkyE5w3AJ3HV/U9Wi7qsDPruxCA1r8aSs1DZQ/4wg24m0SOarEYpOUxzbFFJfth5CRhELmLE8zxIenAiXXz3Us9a5TfeVB/95kQd6iJUc7VhHeJa44MdWqWDrCoG4WqiQr3o5VNa5gCyI+f1w0YjgtFTgX5q7x7gmxjF9/N/vfPF/tvfHgUbfL2oVKchfJApf2Zk1ka9sRC17wERDaqzuBi/xQRAUQ9q6peg8xmMLPA7q0fR1KfXuJeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NH8Aum9OL8Zts4+aguwsGhEVet72rrMPybUoz+dWuKw=; b=ed/D358sB/IgS5j3yRXUmIbsfwQd1ENwqiI362BuHx0Jco4S3fQrvKyXvGGf9dBhEp/ZY5uPBnOpWPeGNIT5fbZxNuUJiGPkwwMF1IlYKkJv+jBi+lpk6IQBJoLZqqx2RgdDeymkZnQxXzhd2SW7gAAsTyE11jJ3sCqKjn1KiweCG/GGRuYpnTQzHreFwtKGnNk7gamxviTZS70C93QSbGvLoE1am7Mgl8yoaMRZ8Hp3ZZiyZyzGCX0TWT+sNIJjUjEi7/GnNwmVLpDRyiPtL7Lz8N5BAjX8b/+hggwaoNcy1vh9093/gRPBoSFk+qY5tZ2M/OKcQLtPbCrMm3nITQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NH8Aum9OL8Zts4+aguwsGhEVet72rrMPybUoz+dWuKw=; b=YlifoBWkpC+x9fpI+F55Ql+if9lwB+0GkpOV1D0IuxIpkkpY4dgi+apoLPHeQjhAoX/bhJlZpF2Zz7HosqfdMz2p64vj1+h19U5qCfhAgEm5Fl4Lfe/o12XLIPE6Z2pD/Y8Z/OBbhGRiGo67+GLyueCl6R35jQn0vH45Q8TyGR8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH7PR12MB7233.namprd12.prod.outlook.com (2603:10b6:510:204::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 16:58:07 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 16:58:07 +0000 Message-ID: Date: Wed, 26 Apr 2023 17:58:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Ronak Doshi , Jochen Behrens Cc: dev@dpdk.org References: <20230412162636.30843-1-doshir@vmware.com> <20230412162636.30843-5-doshir@vmware.com> From: Ferruh Yigit Subject: Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes In-Reply-To: <20230412162636.30843-5-doshir@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::19) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH7PR12MB7233:EE_ X-MS-Office365-Filtering-Correlation-Id: ba229535-f483-4f33-5ceb-08db4677689f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FG4Uhe+9xmviojWNnh8eQRLcqNHqx8dg3E3YMvBZSxbdTNGqHyplZNJjw7gvpfHhAXtwODw35dlOeEP9Pvhi8UiKZCuJieWTUY22MPsJtoansBom+tTmWJFqTss01oBnIjceZTdtIWWxn95WRXIRlAw8YE3PkLQ2R7WWkMb1NlmatNuhiwKj2xrnzJvD43WGcxaLJltlYt6rGPSIxB+LqPSVe8zfs0SerEfejmFD/Wt17nPj4gywa1Z2I7EtPMXLXsbTwIUlhHfcmGWpLBa33UPZRLLlic8+RHkDj3vnp+y8eq/Re2VZWJBeY6la+Gyux7qYiEmALEbApmbVq1aJP3bMG7Zf0JoFD6kWiVKEjjM2mSQ6r266wfivhDLPDOmRW3uJE+a8Pqn3wXPqX6VXYRiwXBW5ExjUbCwd0xc6CwcCzLE5nxIjuYSEBLJizBQUnS90hXbpUTSd7nOqWvoOWuj3532/Z8z4DTozszGKM+ZksQZkkr9s9xzjXXe9dyyY2X58srg9ceOmmrzCDevveh1e3MJHac4iNzcClFUJFaDr1ypcFPxfMoXSBLThaPVlV8AACT63FK75iyO16XCy2uw1pKoRj3+iyZdJgmQSLv6tktOBd9nl3gSu3ODBxReR5y4taHE/7udx+gKgxypUmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199021)(31696002)(36756003)(2906002)(86362001)(31686004)(6486002)(6666004)(186003)(53546011)(2616005)(6506007)(26005)(6512007)(19627235002)(66946007)(66556008)(66476007)(478600001)(316002)(41300700001)(38100700002)(5660300002)(110136005)(44832011)(8676002)(4326008)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGQrNy9GSk8wM2VqSHFtQ09WYVhQNGhVTEVPTCtLRWVTR0E2UmxiMDhGS1lM?= =?utf-8?B?LytQbGVLY3N6U2pOSkxITWlDVWtlS2srNFVvbklmWjJWYjF5c01VK3ZPYnNF?= =?utf-8?B?Y3lUa3A4K2xrV3hkWnp5S1BlR05ocnZ0RG1mNHNRVTV0bldqK2U5NlA2MTcv?= =?utf-8?B?dW9YRzFBTmVuNVg3a2lWcWNCcTNHKzJSZGtwS1IvbkNISHVSbmZDMEsvYjBZ?= =?utf-8?B?aGpNdi92R3RWZVU0ZE1OWS9YdldHYmcza0d2cGc5cXRzNjRiUEkxRHZHaDA1?= =?utf-8?B?dGFjT0sza3pZOHZEM2hpaEIvYjVPOThvZ3k4S2dKT1ZqeHJBZldUT0NxN1BN?= =?utf-8?B?RnhLWDU2Ukh0b1dTZytCMURTSkIwVUYxREZ5b3o1cG9oU1ViMDJlOHRQdjJV?= =?utf-8?B?ZHFySWFGNEVQbytlaStvMVFSN0FDTS9FQzdyQkYrbjh2Qks0dCtZS2VvaEFz?= =?utf-8?B?Tk9Tdk9JblQ2cGlmeFloc3RsY09FbWIxNkgxaHVETGJJQ0V2bGZjZGtHK0xl?= =?utf-8?B?UUZpYjJZQ1BYSlgyVDI4NGRWQTJ2M1owZnZXQytqa2VpUFhENS9waFNHRW1O?= =?utf-8?B?b2dyMllEaTZWN0ZCZWE3WUVrbWtDN2M1cXBqNjBLaUNIY3BBN0N1NjE1YVJa?= =?utf-8?B?VEdLblYycFBNUU1mclBnZnQvaWhPaHlIUnpqc3cvTlREYnBidS8weVNLOTBH?= =?utf-8?B?dWQ4NFNDS0JmTTJDWW42UmlPWTJSR0VTRzcxazZLZ3ljZXU4dVV1MzF0WE5R?= =?utf-8?B?WlVndEY3cjlWeW5kTjN4UWN3UTJZMGo1Nzg5cnNuWXg5RlExRmVsTmlzSVM5?= =?utf-8?B?dWN1M1czN1ljMENSdURUeTJXdkhUcG9zUVd6UXlXNlIvUWltMmhSeG5qbmRV?= =?utf-8?B?dDVxODhpNy9PVFhucHVnY1dGS1VPdnNQdDV4dGw3MnZSOWlLUEpORWhFYmlr?= =?utf-8?B?SWJjK2pUWlQxcEVLRmo3dDE5MnVMSEo2K2N1bHlrUUQ1K0RJNGZlWnVRZnRQ?= =?utf-8?B?M2M4MkJMYSt5U3F1V3JMd2p5eVVicDhNcEZGc3BTU0M2RHpjSVNjcEkzVkpY?= =?utf-8?B?QmdYSi9UUG9OTHhIK2c0MytqYTM3TzAzRUdtemlxbDU3OVlSK29TYmN0b1c4?= =?utf-8?B?VUFsMVRqbDdSQzR6bVpaV0tra0wrMHZOVWFlc2pVVXFMSnpoRE56Q1BvUmo3?= =?utf-8?B?cDdEZW4rbDFCRTVENVAvalExL1FrazVSdUN6czlLeWdacWNMWDY3dHpYUFNE?= =?utf-8?B?Wk9uOXUydDZuUCtVR1hTcXMvVkR3WEVZYWVjNktTQk50TGtwd2UxM2JGNU5M?= =?utf-8?B?bDZZei95V1g3dm9xU0h0SCt1QTNUcjBiT3dETDJMUDQ3TjB0dkJUWGxjY2Nh?= =?utf-8?B?d0VUZkdYakJBdlQyd2JaOEZmZDNXQWVGUy9nck1NY3RKTkhWVlNKMklpUXBy?= =?utf-8?B?KzFmelJoNUpiVWMyVUE1QXRiV1R1cHlld0ppNFA1QnlwSFZmbnB6ZEQ4OC9N?= =?utf-8?B?RmErd1pmS2FtNHpCbS9uL1V5dlRib01lRVllNFRmdkluYTJyMGRvS1lBcWhZ?= =?utf-8?B?dG5xeU5zQzZCcjVyekdRMGFDL1djWGJTWHJIdzdOcUxsTzRKSmVnbDhIYTl1?= =?utf-8?B?cDliclpNVFQ4T3B1ZDFSSHU5SnhYSnRyU2EzNTBmK1hhc3dOSytTNERQRExF?= =?utf-8?B?YjBZUS9Ka3g1S2JLU0RaYllES0ZwT05zQk5QWCtjMWViK2xsRklkeDRFSkxP?= =?utf-8?B?Z0ttbzNUbG11Wk1KSXM0cFZrMUFVZVNZaU9PaFFFMnF1TzIyY0g4eE1WOW5C?= =?utf-8?B?bnhWTnNGN3VQbnVtNTJyR2Q4U1VyenJKeWRyK1BaSXNkMUl5ZXNjN2ErRk43?= =?utf-8?B?TVNYTHE2cytBMUhsSnVrSWZveU9OMWpuM21jTHY4U05KbzNNTGpvSUd1eVo5?= =?utf-8?B?Y3RHNWFVaGVmUHdZNWhSYUljMmFoLzBLWm9KVUo1WWRiN1MveTY4UEdHZ0k1?= =?utf-8?B?SE44aHMxTEtsTE9SblI4c0F1K2NzNE1HVm1tcDgzZmhOdTlENmltT0pzV3hh?= =?utf-8?B?Szh3ZDZTalp5ZGdxczAzS0FVMEJYQ2dDRDF1YlBYejBuMG85aEFkUFdyYm1O?= =?utf-8?Q?Bw9NF18z3V2pMUa8LYSdPbirT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba229535-f483-4f33-5ceb-08db4677689f X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 16:58:07.5839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0IJb4Yuti9mLD3pmOGTniNnAXBhx8Y7gc+Psup2GkImLbN6tnDmTSjVPJzwRkSzj X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7233 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/12/2023 5:26 PM, Ronak Doshi wrote: > This patch adds a new command to set ring buffer sizes. This is > required to pass the buffer size information to passthrough devices. > Also, ring sizes are round down to power of 2. > > Signed-off-by: Ronak Doshi > Acked-by: Jochen Behrens > --- > drivers/net/vmxnet3/base/vmxnet3_defs.h | 15 +++++++++++++++ > drivers/net/vmxnet3/vmxnet3_ethdev.c | 18 ++++++++++++++++++ > drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 + > drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 +++++++ > 4 files changed, 41 insertions(+) > > diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h > index 27f35a0062..d8cc295b08 100644 > --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h > +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h > @@ -105,6 +105,9 @@ typedef enum { > VMXNET3_CMD_RESERVED4, > VMXNET3_CMD_REGISTER_MEMREGS, > VMXNET3_CMD_SET_RSS_FIELDS, > + VMXNET3_CMD_RESERVED9, > + VMXNET3_CMD_RESERVED10, > + VMXNET3_CMD_SET_RING_BUFFER_SIZE, > > VMXNET3_CMD_FIRST_GET = 0xF00D0000, > VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET, > @@ -822,6 +825,17 @@ typedef enum Vmxnet3_RSSField { > VMXNET3_RSS_FIELDS_ESPIP6 = 0x0020, > } Vmxnet3_RSSField; > > +typedef > +#include "vmware_pack_begin.h" > +struct Vmxnet3_RingBufferSize { > + __le16 ring1BufSizeType0; > + __le16 ring1BufSizeType1; > + __le16 ring2BufSizeType1; > + __le16 pad; > +} > +#include "vmware_pack_end.h" > +Vmxnet3_RingBufferSize; > + As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" has only file license comment, and I can see this is used in a few other type declaration. What is the reasoning behind using these headers?