From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E393A04AF; Wed, 19 Aug 2020 09:09:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 212FE1C002; Wed, 19 Aug 2020 09:09:50 +0200 (CEST) Received: from m12-14.163.com (m12-14.163.com [220.181.12.14]) by dpdk.org (Postfix) with ESMTP id 340611BE7D for ; Wed, 19 Aug 2020 09:09:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=5Sitg JShhzPkS1BIz31XLIH1/KTawZhhwz1UfutFFdg=; b=jD0huUSXouN+rGWIoUgrV KidYCOHgXqhoySlGYyrEVQ5+sZz+sm2ziits3GdBg+VOjjVLSC0p4AtwtGIvp4n4 eTNfNITIyJRThAYa3mcqIE6W5TNCBU9762AWt53D/RPvlbLWQpd9WsQxhM/IJO4f TOdMJeClVYNF/vlgmbw4AU= Received: from [192.168.1.199] (unknown [139.159.243.11]) by smtp10 (Coremail) with SMTP id DsCowACnrX0g0Dxf+VANGw--.63930S2; Wed, 19 Aug 2020 15:09:21 +0800 (CST) To: Ruifeng Wang , "dev@dpdk.org" Cc: "Wei Hu (Xavier)" , nd , Honnappa Nagarahalli , "jerinjacobk@gmail.com" , "xavier.huwei@huawei.com" References: <20200817124703.58157-1-huwei013@chinasoftinc.com> <20200818080904.5173-1-huwei013@chinasoftinc.com> <20200818080904.5173-3-huwei013@chinasoftinc.com> From: "Wei Hu (Xavier)" Message-ID: Date: Wed, 19 Aug 2020 15:09:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID: DsCowACnrX0g0Dxf+VANGw--.63930S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxWFykKFW5Kw4UWr1rtw17trb_yoW5GF4UpF sakayfua1xJwnrJ3yaqFWY93Z5Jr4rG3W7ArW2yF1UCF90vr10vryrCr1kWFn8Cr18Awn5 Aas8Xwn29w1DA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07b8NVkUUUUU= X-Originating-IP: [139.159.243.11] X-CM-SenderInfo: 50dyxv5ubk34lhl6il2tof0z/xtbBZwGFo1etz6LBkwAAsF Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/cpuflag: add new flags for ARM64 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ruifeng Wang On 2020/8/19 10:26, Ruifeng Wang wrote: > >> -----Original Message----- >> From: Wei Hu (Xavier) >> Sent: Tuesday, August 18, 2020 4:09 PM >> To: dev@dpdk.org >> Cc: nd ; Honnappa Nagarahalli >> ; Ruifeng Wang >> ; jerinjacobk@gmail.com; >> xavier.huwei@huawei.com >> Subject: [PATCH v4 2/2] test/cpuflag: add new flags for ARM64 platform >> >> From: "Wei Hu (Xavier)" >> >> This patch adds new flags into the test_cpuflags() functions for ARM64 >> platform, such as RTE_CPUFLAG_SVE, etc. >> >> Signed-off-by: Wei Hu (Xavier) >> --- >> app/test/test_cpuflags.c | 39 >> +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c index >> 06718631f..845564410 100644 >> --- a/app/test/test_cpuflags.c >> +++ b/app/test/test_cpuflags.c >> @@ -118,6 +118,45 @@ test_cpuflags(void) >> >> printf("Check for ATOMICS:\t"); >> CHECK_FOR_FLAG(RTE_CPUFLAG_ATOMICS); >> + >> + printf("Check for SVE:\t"); > Nit. Use double '\t' for better alignment. > >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVE); >> + >> + printf("Check for SVE2:\t"); > Ditto. > > With the suggested changes, > Reviewed-by: Ruifeng Wang OK, I will update them in V5. Thanks, Xavier > >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVE2); >> + >> + printf("Check for SVEAES:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEAES); >> + >> + printf("Check for SVEPMULL:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEPMULL); >> + >> + printf("Check for SVEBITPERM:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEBITPERM); >> + >> + printf("Check for SVESHA3:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVESHA3); >> + >> + printf("Check for SVESM4:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVESM4); >> + >> + printf("Check for FLAGM2:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_FLAGM2); >> + >> + printf("Check for FRINT:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_FRINT); >> + >> + printf("Check for SVEI8MM:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEI8MM); >> + >> + printf("Check for SVEF32MM:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEF32MM); >> + >> + printf("Check for SVEF64MM:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEF64MM); >> + >> + printf("Check for SVEBF16:\t"); >> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEBF16); >> #endif >> >> #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) >> -- >> 2.27.0