From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id CEDB91B05 for ; Fri, 25 May 2018 08:34:26 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 110BF940054; Fri, 25 May 2018 06:34:24 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 25 May 2018 07:34:17 +0100 To: Yongseok Koh , , CC: , , References: <20180525005338.28773-1-yskoh@mellanox.com> <20180525012006.29856-1-yskoh@mellanox.com> From: Andrew Rybchenko Message-ID: Date: Fri, 25 May 2018 09:34:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180525012006.29856-1-yskoh@mellanox.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23866.003 X-TM-AS-Result: No--17.668000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1527230066-v1LmtkMbhYpw Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 06:34:27 -0000 On 05/25/2018 04:20 AM, Yongseok Koh wrote: > Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html > > Signed-off-by: Yongseok Koh > --- > > v2: > * modify removal deadline and add more comments in the deprecation note > * mark deprecation on the comment of the macro in rte_mbuf.h > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 1e2443c76..e1630c2cf 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -42,6 +42,13 @@ Deprecation Notices > is defined in librte_sched in a non-generic way. The new generic format > will contain: queue ID, traffic class, color. Field size will not change. > > +* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or later and > + replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. As > + ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, ``RTE_MBUF_INDIRECT()`` > + can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the new > + experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of the macro > + is to fix this semantic inconsistency. > + > * ethdev: a new Tx and Rx offload API was introduced on 17.11. > In the new API, offloads are divided into per-port and per-queue offloads. > Offloads are disabled by default and enabled per application request. > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index e136d12b7..8e6b4d292 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > #define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > /** > - * Returns TRUE if given mbuf is indirect, or FALSE otherwise. > + * Deprecated. > + * Use RTE_MBUF_CLONED(). > */ > #define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > Acked-by: Andrew Rybchenko