From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19B0AA00C5; Thu, 15 Sep 2022 11:55:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 086314021D; Thu, 15 Sep 2022 11:55:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E846740156 for ; Thu, 15 Sep 2022 11:55:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663235738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtB4ZXqN4eSgH5vstAB+BIehFC2pSw31SZnZFd+a6ro=; b=UQFTlkp1HrJ3804lY058RZ8KkI7otWQqNEEufm71nJw3VItC2hDQ7kSdihAlAk+8qK34AC Rcyy03vzwkKU+nPgtRhBrLu0h6KWPHT+yaE8LLLwDepROgqutkSePQcqRIpZpY+IwbLS/x s3EzbV6t+hmFFpTF0TFBKunZ3ZQMnhs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-If5T29WXPXOZy-N5RDuNyQ-1; Thu, 15 Sep 2022 05:55:37 -0400 X-MC-Unique: If5T29WXPXOZy-N5RDuNyQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0CB3B1C04B67; Thu, 15 Sep 2022 09:55:37 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF998492B04; Thu, 15 Sep 2022 09:55:35 +0000 (UTC) Message-ID: Date: Thu, 15 Sep 2022 11:55:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 19/37] baseband/acc100: add queue stop operation To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-20-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-20-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Implement new feature queue stop operation. Implement new feature to stop queue operation? > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 58 ++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 460233a499..deb2cb6d36 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -990,6 +990,63 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > return 0; > } > > +static inline void > +acc100_print_op(struct rte_bbdev_dec_op *op, enum rte_bbdev_op_type op_type, > + uint16_t index) > +{ > + if (op == NULL) > + return; > + if (op_type == RTE_BBDEV_OP_LDPC_DEC) > + rte_bbdev_log(INFO, Info level might be a bit too much, maybe put this as debug log? > + " Op 5GUL %d %d %d %d %d %d %d %d %d %d %d %d", > + index, > + op->ldpc_dec.basegraph, op->ldpc_dec.z_c, > + op->ldpc_dec.n_cb, op->ldpc_dec.q_m, > + op->ldpc_dec.n_filler, op->ldpc_dec.cb_params.e, > + op->ldpc_dec.op_flags, op->ldpc_dec.rv_index, > + op->ldpc_dec.iter_max, op->ldpc_dec.iter_count, > + op->ldpc_dec.harq_combined_input.length > + ); > + else if (op_type == RTE_BBDEV_OP_LDPC_ENC) { > + struct rte_bbdev_enc_op *op_dl = (struct rte_bbdev_enc_op *) op; > + rte_bbdev_log(INFO, > + " Op 5GDL %d %d %d %d %d %d %d %d %d", > + index, > + op_dl->ldpc_enc.basegraph, op_dl->ldpc_enc.z_c, > + op_dl->ldpc_enc.n_cb, op_dl->ldpc_enc.q_m, > + op_dl->ldpc_enc.n_filler, op_dl->ldpc_enc.cb_params.e, > + op_dl->ldpc_enc.op_flags, op_dl->ldpc_enc.rv_index > + ); > + } > +} > + > +static int > +acc100_queue_stop(struct rte_bbdev *dev, uint16_t queue_id) > +{ > + struct acc100_queue *q; > + struct rte_bbdev_dec_op *op; > + uint16_t i; New line here. > + q = dev->data->queues[queue_id].queue_private; > + rte_bbdev_log(INFO, "Queue Stop %d H/T/D %d %d %x OpType %d", > + queue_id, q->sw_ring_head, q->sw_ring_tail, > + q->sw_ring_depth, q->op_type); > + for (i = 0; i < q->sw_ring_depth; ++i) { > + op = (q->ring_addr + i)->req.op_addr; > + acc100_print_op(op, q->op_type, i); > + } > + /* ignore all operations in flight and clear counters */ > + q->sw_ring_tail = q->sw_ring_head; > + q->aq_enqueued = 0; > + q->aq_dequeued = 0; > + dev->data->queues[queue_id].queue_stats.enqueued_count = 0; > + dev->data->queues[queue_id].queue_stats.dequeued_count = 0; > + dev->data->queues[queue_id].queue_stats.enqueue_err_count = 0; > + dev->data->queues[queue_id].queue_stats.dequeue_err_count = 0; > + dev->data->queues[queue_id].queue_stats.enqueue_warn_count = 0; > + dev->data->queues[queue_id].queue_stats.dequeue_warn_count = 0; New line here. > + return 0; > +} > + > /* Release ACC100 queue */ > static int > acc100_queue_release(struct rte_bbdev *dev, uint16_t q_id) > @@ -1184,6 +1241,7 @@ static const struct rte_bbdev_ops acc100_bbdev_ops = { > .info_get = acc100_dev_info_get, > .queue_setup = acc100_queue_setup, > .queue_release = acc100_queue_release, > + .queue_stop = acc100_queue_stop, > .queue_intr_enable = acc100_queue_intr_enable, > .queue_intr_disable = acc100_queue_intr_disable > }; With minor comments fixed: Reviewed-by: Maxime Coquelin Thanks, Maxime