DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michael Lilja <ml@napatech.com>,
	helin.zhang@intel.com, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times
Date: Wed, 17 May 2017 16:16:43 +0100	[thread overview]
Message-ID: <b4ecf91b-3a91-d855-af35-5e82c410d848@intel.com> (raw)
In-Reply-To: <20170517145757.22299-1-ml@napatech.com>

On 5/17/2017 3:57 PM, Michael Lilja wrote:
> Previously, the FDIR programming time is +11ms on i40e.
> This patch will result in an average programming time of
> 22usec with a max of 60usec .
> 
> Signed-off-by: Michael Lilja <ml@napatech.com>

<...>

>  	/* totally delay 10 ms to check programming status*/
> -	rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_US);
> -	if (i40e_check_fdir_programming_status(rxq) < 0) {
> -		PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
> -			    " programming status reported.");
> -		return -ENOSYS;
> +	for (; i < I40E_FDIR_MAX_WAIT_US; i++) {
> +		if (i40e_check_fdir_programming_status(rxq) >= 0)
> +			return 0;
> +		rte_delay_us(1);
>  	}
> -
> -	return 0;
> +	PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"
> +		" programming status reported."
I am aware that you just moved this log, but since you have touched to
it, can you please fix it too [1]:

PMD_DRV_LOG(ERR,
	"Failed to program FDIR filter: programming status reported.");

[1] Or if you prefer please let me know, so I can fix it while applying.

> +	return -ETIMEDOUT;
>  }
>  
>  /*
> 

  reply	other threads:[~2017-05-17 15:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 22:01 [dpdk-dev] [PATCH v3] net/i40e: Improved " Michael Lilja
2017-05-17  2:22 ` Xing, Beilei
2017-05-17  8:44   ` Ferruh Yigit
2017-05-17  9:12 ` [dpdk-dev] [PATCH v4] net/i40e: improved " Michael Lilja
2017-05-17  9:39   ` Xing, Beilei
2017-05-17 10:38   ` [dpdk-dev] [PATCH v5] " Michael Lilja
2017-05-17 10:43     ` Xing, Beilei
2017-05-17 11:21     ` Ferruh Yigit
2017-05-17 13:45     ` [dpdk-dev] [PATCH v6] " Michael Lilja
2017-05-17 14:10       ` Ferruh Yigit
2017-05-17 14:31     ` [dpdk-dev] [PATCH v7] " Michael Lilja
2017-05-17 14:43       ` Ferruh Yigit
2017-05-17 14:46         ` Michael Lilja
2017-05-17 14:50           ` Ferruh Yigit
2017-05-17 14:52             ` Michael Lilja
2017-05-17 14:57     ` [dpdk-dev] [PATCH v8] " Michael Lilja
2017-05-17 15:16       ` Ferruh Yigit [this message]
2017-05-17 15:33         ` Michael Lilja
2017-05-18  1:38       ` Xing, Beilei
2017-05-18  8:52         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4ecf91b-3a91-d855-af35-5e82c410d848@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=ml@napatech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).