From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E375E292D for ; Wed, 17 May 2017 17:17:13 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2017 08:16:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,354,1491289200"; d="scan'208";a="88409004" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 17 May 2017 08:16:43 -0700 To: Michael Lilja , helin.zhang@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org References: <20170517103807.18746-1-ml@napatech.com> <20170517145757.22299-1-ml@napatech.com> From: Ferruh Yigit Message-ID: Date: Wed, 17 May 2017 16:16:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170517145757.22299-1-ml@napatech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8] net/i40e: improved FDIR programming times X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 May 2017 15:17:14 -0000 On 5/17/2017 3:57 PM, Michael Lilja wrote: > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of > 22usec with a max of 60usec . > > Signed-off-by: Michael Lilja <...> > /* totally delay 10 ms to check programming status*/ > - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_US); > - if (i40e_check_fdir_programming_status(rxq) < 0) { > - PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" > - " programming status reported."); > - return -ENOSYS; > + for (; i < I40E_FDIR_MAX_WAIT_US; i++) { > + if (i40e_check_fdir_programming_status(rxq) >= 0) > + return 0; > + rte_delay_us(1); > } > - > - return 0; > + PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" > + " programming status reported." I am aware that you just moved this log, but since you have touched to it, can you please fix it too [1]: PMD_DRV_LOG(ERR, "Failed to program FDIR filter: programming status reported."); [1] Or if you prefer please let me know, so I can fix it while applying. > + return -ETIMEDOUT; > } > > /* >