From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4914A0352; Mon, 14 Feb 2022 18:34:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A61E140DDA; Mon, 14 Feb 2022 18:34:30 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 62B554067E for ; Mon, 14 Feb 2022 18:34:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644860069; x=1676396069; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=7rm48gJf+ccNk2EjNiB6WFRl1Ej6ZkTJD780tKCjJm4=; b=C4YxzH9yc7vCaVEzRhRaZrwp7R4TdQiBQHYmRNxsdOWjidNEuKFbkf7C S0xeUELYv6eFPlPgv3RBTwZYAyMU4AXDukhMBALyW0CSeKr2lVvx/5com Jk8bdJVzYxXZp/1cGWaHnKgmgHg+3qWo+v26YEfSEc7cYFm/h8U1A/kRX WNt+FLJJ5WG4jfhRKKxi6OvrcS769gpD2OmFVJsFvpibIRnplOEGpY96h DCdlDcipz7e8hvfO8FVwn9DnEUP1bzoseWOavGflNTGSJ5qkoCU55rW/7 gM61CgRAihi/0LHvJ0Q6Ova/f08Trq5/ywWWk4EgUEDnTOR5kP16IIDcw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="248974147" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="248974147" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 09:34:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="680612138" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2022 09:34:28 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 09:34:27 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 09:34:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 09:34:27 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 09:34:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y+R+7RS8UgVoksv3+BsuUBzrwbyiTysqFQIxf6cRIXhiUdRkGyuo9/6ssaJXnPaqyaZh0i2PuE0JHT3vvYqcOGUcKfq2Ds+1hdc9DNXesGqq+E2QITgjPXIQep322UVYWOF3P1XlyAdxV4PmwcnqdVEF+hzkWVo6+Vhcq5EpnQtz+GVpQgjnDqH0Ad09uuk6qS791ctoP9zPc3QDBAn+SFnfyR4nu3hhOolSMHekqgNud2ob9ughiHh89TL8YselpZv/2tewEICBhIx1pcBiWRUpbi9Y+u/1u6oiwmIrua8YE56nxtcbjJJ4vkTQT/VKIxFfnSI87nhEgMRan6xzLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGO/QM0nb5Jf7TsBE/wzuSug7T+I1GCkMDMwet1tNFc=; b=mtaV/PxI+Vf7p42SGIRz6tRq2OcFSojeWPNu8xShY26kdOvBwhhJVz1TPdDSv/k+6J0l0FCIp5RGKjyDHxA8ys87XB/i6M/0ayOEAFGwo3L2+WyUfuwGafTpyiuYv8mohdcIsB6XXvgRoDm3rHfbpkzyt0Djst/uOVwM2F2eWpsLW/nEpi3HxNhOUXM8e80DMuhNK2b/p+HP825E9UX+5kJPxBav27xdALfvpL2912pwtp4FouKJI1L63Eo9DvAbh2uel6n3jl18ejmYluqO/+Ed3gluNxR2slUj4cU41qD+KX2zOCBbCg+B2Y0I8mC2Wd2AS59vBCFpK6TokEL5eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN9PR11MB5433.namprd11.prod.outlook.com (2603:10b6:408:11e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 17:34:25 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 17:34:25 +0000 Message-ID: Date: Mon, 14 Feb 2022 17:34:19 +0000 Subject: Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst Content-Language: en-US To: Martin Spinler , References: <20220214112541.29782-1-spinler@cesnet.cz> <20220214112541.29782-3-spinler@cesnet.cz> <9ae7a914-fc0f-f2d9-5e48-00c56676eab1@intel.com> <9e543fe223f78405a72d36c2d244316510f9f169.camel@cesnet.cz> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <9e543fe223f78405a72d36c2d244316510f9f169.camel@cesnet.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51de85bd-87e0-4861-45b0-08d9efe03ead X-MS-TrafficTypeDiagnostic: BN9PR11MB5433:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:619; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DN8MvMaVM0e5MazjrgNeX65aKCHoDvFadszOsw7MTvai0Ox7Zp8cUu0p1JEwOIoJ9BVt6Z+NPxfnifyS0dq2GNQBRy3ZIgkVBZV4yA9SQmJG33iADgz8Hu7zoasDiuox+nr+TLuiv1n0/08O4eF38593BiIwkKkd1Wf1o2bH5zDXlUvoDdlKlRooV+IarJFooJkfevedZ8fqnyJPBEFISjIPv9JtlcZ8gN8k01MWzJkowHjWPIUiZeeTv6TNth3/kPTVA4SjkNPh/ASYioO69LbUnN2HpusCc9rbX2DOe8Fp+oDR0oQEtlKLXS1bUkwT45lF0gKVZM2FL4ljOgKf3ihfvyWB21Oy9Oux+/wi+iO+c1TzbKb+310UVUaApDHBtpuT/POlCske1G3v+XTb0gDdw27MujXadLgQ2DXa6UjWqX8G5M8gP9dZ3Vcm1BxCwDo0SJro1mcp2Ep7jlsL1/mPKkyzXXt3ANclY0iqttrs0dBxk5UVYRN7ksA7lRJ9zISowYK7KrSTpS2q/9JY9QJ5uvJFgACmy5do0J/IvWAtu/1d8LOCJl1fnEdcrZTc/Ubzxd8CQQZkJh051DMAMhYwYPp/jhRBydN7HYNqd/OGUNgYZ9vIkXdBcdGT4MgVCxTj+ujHjV3Umn8JWO8djKZUWWPTt6A8BYMfKe9rCXTchqY0ga3bZOfvgDuZJZORz8+KiPOUFu1G+6rMMDZvEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(86362001)(31696002)(66946007)(8676002)(66476007)(66556008)(82960400001)(316002)(8936002)(5660300002)(2906002)(44832011)(2616005)(186003)(26005)(83380400001)(6486002)(508600001)(53546011)(6666004)(6506007)(6512007)(31686004)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVNibVFSbGJGK3FubXNnZEYyYjdacWNiMVNlSjZTUnd4cXlkcDcrNWU2SFBV?= =?utf-8?B?RUo3UnB3UWtiUmRLM293R0Z2MkZBbUxUK2ladXlXbzdDTld1bUNWazZrSGVl?= =?utf-8?B?V1p0bis2Mm1uNlR3blFFNDg0NU96ZVhiWE1BSDJsN0pHV1RvOFE3UHREZ1hO?= =?utf-8?B?QisrREh0VGZUc2c0Sk0wUzVzMUw1b2NFdzc5Y1ZuUzlSSUN0TnVjYXpocDhr?= =?utf-8?B?RktqTmpaaVNRbVFHaEJWYVBvSGZ4L0hKUW9ncUdXRWw0bWRBbnNEWkFaZ3Qw?= =?utf-8?B?SmgwcjJ3NXZKSGJtZzRVUkFFTHg0N1pTMGhyeGF6M1RyK2lvaUhFckk5V1Yr?= =?utf-8?B?Uk0venVXVEErazlZRElMeGVzVUF4MjVDczcwNkdoYm84YitZaXJVNXhWM3ZL?= =?utf-8?B?WEJLWTJIYlc1REFGZ2ErNWRQMGdxY2pQZ0Q4cHR4ZXhDaURNaTJIakhtT3NU?= =?utf-8?B?UXNibTZYOUN1NG44UysweDBoSFRrVlRRRjFnVk9LaVpFei9MczgzVk5NMHNW?= =?utf-8?B?Ni9vUDFLa2NENUlSYXFpWWE1cXJzZitpbWpYblo0Y29MQXBiaExWWUdQQVl3?= =?utf-8?B?eENzdFR3c0RzNjcyZUMwTzZweEJtWWNJc0kvQ3hLK0VFUTFhTlFJQWpNTGdx?= =?utf-8?B?ZXlHSWNGajRKZHdpbDFRZ0dsdTlXQjRnQ1FsSWtkTnZMd3JUd2QrQzBDMlVD?= =?utf-8?B?QjZDK1BoNUw4WHVwQk1RRDE4Zk92U3VLWHV6WWZiVW5FZFZZK0F4YUJkUGYy?= =?utf-8?B?cVZhRXgwcEk1aHRRakp4a0g4VGZhY085MzNMUUVvSElTQUlLVHdwbHluNEFU?= =?utf-8?B?OWNCS3RBdVRRZXp0MGpyTVRMUXRCaFlkY0t5elpLczhJVEhZYmdqTlRwdnhh?= =?utf-8?B?L2g0ODJWQnpOczFMd1JnYTdtaWphdVRzeTZqcjE1amZvOWNYd3VxOG9LeWNM?= =?utf-8?B?ZzMyMmxnaDkwemMzYmdSNGNJSDlBTmJ3VkRlelk4V2FjSDRRVFFld2l0MjRZ?= =?utf-8?B?VWJGZnJST0UrbHJ4eE1waHkzeStrZjVrbHlFWlF4T29pMjBLUmxJNS9hS3pr?= =?utf-8?B?Z3l1VXVCZUppTkhEQmhCWW51Y0Zab0dQQnpZYXdiZGJsQXJYdVNIQmJVUmZW?= =?utf-8?B?OHVSVW9sSlVRSUdrc05SMktaTGs3TVA2czFmQUZYaENQeDJlNlduakQyaTR6?= =?utf-8?B?OFBJaHRpa2VaUUppVkY3RzFaK0JWcGtkbGdEWmFaeVdLMlA0NDBJZUZEb3l5?= =?utf-8?B?YTBVMDNSaGM2dXpEU3hRNXc4NGJDMEhLaFBCcGhsQ0JpUDBJaHlVdzhKbmdn?= =?utf-8?B?SSsrdzVia1JnaGhlYUZhUjNsSW5mbi9uTmZvd1FBRzJjUm5EWHNlQmRRZlFL?= =?utf-8?B?V0VpSm1YMWpET2hpTTZuK3p0Q1pEbDhKVDl4S1V5SUV4aEJhTDZiSDY2cmVx?= =?utf-8?B?VHNOUkZyY2djTHU5d2ZkVXdVTEkzcS9zczRMcWd0V3BVLzVuR1plMnRUcmNi?= =?utf-8?B?QVRMcGJwZVRvRTV4OUw2RmVONGQzY3UxQjBEL2tydnNnbGI4MnJTRlFJVFd6?= =?utf-8?B?eEd5Qkd3T3RrQWd0TVRKUit1NSttK0h5Y20wdXIzY3NRNWNGcGxKSUY4NGxC?= =?utf-8?B?OWxzS05oWlkvTlFIRWd1L0kvWlhjdG00cko5NUlkL1JWVXhhL21VMm5GSFpP?= =?utf-8?B?ZlYzN2JJV0NESEpQbTkrSWdoWVc2UUlxNlpqcE5PU2RLTko1d1BEYlJ6cEZy?= =?utf-8?B?R1lQYWhac3UyclU5ZURhcjJMekdrT050ZTZSOTRuSEtySHRDZTlYVlFzTVlC?= =?utf-8?B?cHN3U0l2THRCR0dRelc1S0FhTTM0czhVWTlQUTkySWFKeHBGRTRhR0RuNElF?= =?utf-8?B?RWJFRHltWVdqeVpIZ09jVFN4d2YwZmFNOGdGNEVPVmdDdWorUGRGWmgySnIz?= =?utf-8?B?c1NlTENiNjhTdWFtVzd3MC9EWUlxNWZYOGNVYnJMcGwzd0xuVW1ERE5GN0xr?= =?utf-8?B?TTFXdlVUYXZGZzhORVE5eVdBWndPSEJ4QVdFYjBqUGViTER2OW9Nb2o1ZjM5?= =?utf-8?B?dm5ma0JTakp4REtvaFdrUXcvSk43T0NjeFl2Z1FvUE9TczhxRmlVaURmSkVx?= =?utf-8?B?TjJTV25iZVh4Z2h1MDN4SGpEVDdZYTk1TmpzanVSajl0N28vL0hmc2l0MkJ3?= =?utf-8?Q?2BZEeNCdgLIMcWdue/u53Lc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 51de85bd-87e0-4861-45b0-08d9efe03ead X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 17:34:25.5391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PmW/MGaM0x1GeJEyqqO6vtE0tz4+KlgSOMFNku22tgGUA6oPExrTkY/5qwxBUIWr5zhDN8O1aoJsv6xrI++cgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5433 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 4:53 PM, Martin Spinler wrote: > On Mon, 2022-02-14 at 13:35 +0000, Ferruh Yigit wrote: >> On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: >>> From: Martin Spinler >>> >>> Zero-sized TX burst floods the log no more. >>> >> >> If you want this patch to be backported, you can update >> commit log as fix and add fixes & stable tags. > > I don't think it is a fix, rather an unplesant behaviour in a specific > application. It doesn't happen in the test-pmd app. > If you don't want to backport, OK to keep as it is. >> >>> Signed-off-by: Martin Spinler >>> --- >>> drivers/net/nfb/nfb_tx.h | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h >>> index d3cbe3e6b3..910020e9e9 100644 >>> --- a/drivers/net/nfb/nfb_tx.h >>> +++ b/drivers/net/nfb/nfb_tx.h >>> @@ -136,7 +136,10 @@ nfb_eth_ndp_tx(void *queue, >>> >>> struct ndp_packet packets[nb_pkts]; >>> >>> - if (unlikely(ndp->queue == NULL || nb_pkts == 0)) { >>> + if (unlikely(nb_pkts == 0)) >>> + return 0; >>> + >>> + if (unlikely(ndp->queue == NULL)) { >>> RTE_LOG(ERR, PMD, "TX invalid arguments!\n"); >>> return 0; >>> } >> >