From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5691D43A40; Wed, 7 Feb 2024 11:47:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D466D40279; Wed, 7 Feb 2024 11:47:39 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2084.outbound.protection.outlook.com [40.107.243.84]) by mails.dpdk.org (Postfix) with ESMTP id DF73D4021D for ; Wed, 7 Feb 2024 11:47:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzYHcViFNW41ztrmSBzrsHkxkGbX/Ows12AnfZR4dHhrG2TUmJ6uAP6Kg0cF578JR4ql3xSfM851lbZFih345NtvVTMMZiJBlNcoz7A78haBQl7JTUial89hX1FOjYfS3r70fpFjPGNax1T2UMhSehHOf9/fpYavW8WoXi04l4s4jOTeHjBOvg2PNth6r1RLwNYpu7kPg6Ng/tNrVyMvNowbbgySuvqG8kimGfjt7/CuKSsGX/Y9gSZaMxgYGJa4P1UwuHNFZUs9DAvMqKKq6huD0CDZ6sERAf0F1l24r/rfP6qqYnnJbqPM94dBPONI9fbMFXc/syQpX3KhrrvE5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zGCpFe+Ejc1HlDsarxfAi9G5ftGnMjoUUJoaiEPbYyI=; b=gxCjGuq9UbNkQMxvCcjBzh1oDv92ieX5/ULL3PijJtwFKG6yI3nHO0wWWZKJHjP4dHGWxXwg4vAxfBfiRDLZlXxOMpoF8fwgbJ5odo0GGxxfpe9CauZkDOH9BD52vh089XXx5+x231IpBS/R5lU2lRT/axl+mxDtHgbxh5IXIDva5AsY6hENxNHGxPFijGrI8O1I5GG6knxSd/oi9PqH8EkFvUkkiVhYERaWaQu1LHOalXvErYBbdWa0AZgy8kBJjlc0tlF7SZgFZX0ev6OwfzVok2QNNa7DpdkPdmUdW609hYzz+mlAbdsuM2BMNs0bvtJduubGARlKyxX8XyC3nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zGCpFe+Ejc1HlDsarxfAi9G5ftGnMjoUUJoaiEPbYyI=; b=gGJ9h9iLrMqGFvISu4Iv+oy/z5fFI3DOJfUQbGAPM6NMmGsqNu1TW3gPnIS5ZRpSUBT7bT0sfv50ag2DNk5Luv+NmEd+V5uV2t+u9qi8qaQRqcJvgpclQN1Ndzpd0ppXKBqNkNrAAiMwQc2WaOmckRAudzcqo6r+bP11eBfhJZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6376.namprd12.prod.outlook.com (2603:10b6:8:a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 10:47:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 10:47:37 +0000 Message-ID: Date: Wed, 7 Feb 2024 10:47:32 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ethdev: fast path async flow API Content-Language: en-US To: Thomas Monjalon , Dariusz Sosnowski Cc: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , dev@dpdk.org References: <20240131093523.1553028-1-dsosnowski@nvidia.com> <13882742.RDIVbhacDa@thomas> <2b0c7fe0-5713-4416-987e-34da0dc4aaef@amd.com> <2956397.VdNmn5OnKV@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <2956397.VdNmn5OnKV@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0284.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6376:EE_ X-MS-Office365-Filtering-Correlation-Id: b7ab4d44-51c4-4dbe-3ebe-08dc27ca32ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSs0yVYLcdizmIclH7m/2F0By7gyt/gD5Pk0OwCmw8lKdTFFdEwCoNzDcFW3frtP4AsLMxevuR81wBqa4j0YKat0l7Vos8UEKzdtsZJkFoXnwDB56KEP6FivmqrNA+yIzypCxEYbE9DY5bc2IZuXcGmpwR6sLz7YG26krmqqquV5Fl1EBmfDuHJ7+MA6Wn+wbnTTf0IcsnWy5vDxhPNtde4Dv+FBtWGd9pY+/j1uxp0x5P5KhHy9AcsFjlR/VHNyqfqhP2TWQjV5TRVfU3pmmhlWECR37cZyQvMzC/f+SU1Swjg4vfrUmNgqKE1eY8xb5+etgCv4MZLnBCFyLMmeEXKQuQCiadtOYEi5l8qOJPCmtJk5h/ryBR+RxTL0j5qWvZp7CL+Zek/kd4oZN/2tEx+88goJe1XVTabAjnSDDYBf1hZ4wccXsgQzKio6HDWNa/z6xRLdIPXkvXVqcjojAKkhkUrcB8ChQ9B/g33wEjvknyeA0jN4uA6P3BRsuP+k+QYs94rE8KsJW0nTxEEr91sJRtCKs4LOhMzqObQQMJECmHNiM6T1C58i5VSVy2dp2XfcQT8DTR54zKM1DLc8qwW3ewn756ejnNIUJ2ete3/n4tvQ3tVRW1e7omJxd8AZH5xEtzG/l4E7XEvngO46Lg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(136003)(366004)(396003)(376002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(2616005)(26005)(31686004)(6512007)(41300700001)(54906003)(6486002)(316002)(66556008)(36756003)(38100700002)(66476007)(6506007)(53546011)(6666004)(66946007)(83380400001)(478600001)(2906002)(44832011)(86362001)(110136005)(5660300002)(31696002)(4326008)(8676002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzI4TFVtZXBRbG5lWWtTZGRDZ3k3ekNZaDZVUExFbGVFS0dFYlhKQ0JMMlds?= =?utf-8?B?S256aWpjTkhVQTlhaDNPMlc2MjhHZlBlcStHdVl5aUF1eVVHSm96Rml6dWJU?= =?utf-8?B?V2tzbUJHdG00UGRKWTdXalNIS0MydGVrUXdKT3VvZkE4cnRTS0hoR3FYWlV5?= =?utf-8?B?WERSNU1RUjc3VVpmOEFFa2dTZEpCWUpYUHFRbi8zbjg2RS84enRtd0Izbkg5?= =?utf-8?B?Z3JycVlYUGdRNmZYWklVVGJKamNmR2cvYzl5K3dQUmtRN2ZxMkF6UytEVFVD?= =?utf-8?B?dnlGS09Sbm1Vb1JGVkNoU1pXLzlFRHl3WTRUYmRwU2ZtWHR0NVp2c1llKzJz?= =?utf-8?B?Y3JXQU1yUWZocjhaSllvMVhWKzVGYUNqQVpCeThZQjlwTTBsUGNudGl3aXBN?= =?utf-8?B?T1Z3V3g1aENYYXhsZXB3TE92Wk1yclV4WlZPT0QrQlNtZDlDNEsvZVYrT0xq?= =?utf-8?B?Mit0UDFmZU9oNk1iaDJ3eFl1SFB0b1pCdTNIeWxsc200OE4xeXJoSWtJVTJG?= =?utf-8?B?clZhNUsrdERjaTJlZ0pqU21rWFhNRkg2NzVMallmRUNVMGZZT01aanZOREVC?= =?utf-8?B?c1RNSVYzeGNIN2dTWnNKMzJiaTdIdFVROHBIUlBMcUFHOTAvVXBaSS91QjYz?= =?utf-8?B?YUpHR29XdmkwdUxRMUkrMmRhbGo0RWNCVFdqZ3pnRUlUZ3hpOUFYRENsUFJp?= =?utf-8?B?amlaOVR6bHdhKzY0R013L1VuMjlKRkxmbmNOaVBuM3BDTEFFczFPcmRjQ2x2?= =?utf-8?B?UHNrMmJkVGtvSm0vdGdmWldrSjE5WVlHM1NUM3p0L1p3MGdwbm5lUXhUeFZ4?= =?utf-8?B?SWtjYTZCMnF3djc2d2xoWHpCSGkvT0wzQ2hiMTRMMTZKTE11TFBvZUp6b2xC?= =?utf-8?B?OXRVSGVQaUM0UEpPVFBnSXR0NHM4NG1lYVNod2paVHdYUVhkdUgrUXVmc0d1?= =?utf-8?B?a1VXcmdtbHlacHgxUjliOU9OTFJRYnF6Tm82Szh5UVA2YWdkM28veWNJVG5y?= =?utf-8?B?RGplRjYrVzFtK0RETWF5MTFWcU42d2ttM2lsQVBOSlFzNFZYRTd3MWI5QmRS?= =?utf-8?B?NGdPR3U0OEhmMU5wOWd1cmRLNEhCS2lGVU5DTHJ2dUVxcCsvQ0ExOEJFWktn?= =?utf-8?B?a0pqTWVtTXY4WU9YRm94dEJUOWFLcG9weFRiRmgxK1drb0ZhejE4ZktYRWE2?= =?utf-8?B?aWdrdE1lbm9kY1VKd1lIWk50dG0zTVIwY2F1NTJCWS9lL2dEcmx3WEtzalRI?= =?utf-8?B?RzFBekpCdzc2cHhyMGJnakhrK284NjNVY2FxWFNLSWZZN0ZxdG5GSk1tNDNt?= =?utf-8?B?ck0xR010TERlSlBRVDQxckY5ZHkxd0Y1TFFXSE8yNkh3N3IreEdPRkhmZEZL?= =?utf-8?B?L3Rnb2xpdElZbE41WlFGYUdoUThYVjJIM1h3S2JTMm5DUVZzcjJyRVVLNmhy?= =?utf-8?B?NWFYaUFZMzlZUGt2cHlEcmFxaE1vRTNCTHRySEpyOGRJOSs2aWhsWkdCMVA1?= =?utf-8?B?QmRKclQ4THRBN2p2MVF0NE9MTFZwcmZLNzlNQzUzakdadEl5QzRZODJWY1Fz?= =?utf-8?B?L0c0U2RXUVQzN0JOeXJ0eWVCRTZGOFFpSHIwb05EdHo2cGRFN2lFZThQWFRh?= =?utf-8?B?Wm5JK2ZRdzl1UmJWSTR2QnF3cmZJOCtsQy8zWVhicVprcUQzZTI0ZDdmbzMz?= =?utf-8?B?QnI5V0lIN0tWNXBVZThYcjduTUFqUitKSWxZTGN1ZTNJcGU2enZsM04veHJr?= =?utf-8?B?MFpUU2x6Zk4wWlhFSzZyTzY0bFcycnlKaUV0eFJzL01uWHpnM3VBS2t2eE90?= =?utf-8?B?dzZEdWRSNmtacGcyN1liV2J4S1lnekVsaDFZUmxadi9BdW8wZHhBdEduTzJM?= =?utf-8?B?NWlKejVBYThBK3I2eXAxUFdKbjVCVi9GY0VQdW9LMnVXckM4ZEJYY1MvZjEy?= =?utf-8?B?S0J3QVZyUGtpRXBWM25wcnNMWE1WelZxL09RY1Y1UmpSSjhMTTVVNDhxUGZX?= =?utf-8?B?SThCSm0xa1F5MXZVbGZHSERwMHBTU0ZPcE16eXZMb2NJQ1c1MnVSQnVkSkpF?= =?utf-8?B?SE1ncVA0QUMrWjNPcjB6OFBlSzhUdGpuMktzZkdEWHdXaWJaN3V3NFpiTTMz?= =?utf-8?Q?nBm8Q7vkFuIhD6uzg3KNOL9z8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7ab4d44-51c4-4dbe-3ebe-08dc27ca32ba X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 10:47:36.9950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p+d85Ljl54sz0BWPep3N1PUA4/mGvZ/ds/QN9yJofVQoryAtfJddzI3QUI56x0ss X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6376 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2024 9:27 AM, Thomas Monjalon wrote: > 07/02/2024 01:57, Ferruh Yigit: >> On 2/6/2024 10:21 PM, Thomas Monjalon wrote: >>> 06/02/2024 18:36, Dariusz Sosnowski: >>>> --- a/doc/guides/nics/build_and_test.rst >>>> +++ b/doc/guides/nics/build_and_test.rst >>>> +- ``RTE_FLOW_DEBUG`` (default **disabled**; enabled automatically on debug builds) >>>> + >>>> + Build with debug code in asynchronous flow APIs. >>>> + >>>> .. Note:: >>>> >>>> - The ethdev library use above options to wrap debug code to trace invalid parameters >>>> + The ethdev library uses above options to wrap debug code to trace invalid parameters >>>> on data path APIs, so performance downgrade is expected when enabling those options. >>>> - Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. >>>> + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path >>>> + and in asynchronous flow APIs implementation. >>> >>> Good >>> >>>> --- a/doc/guides/rel_notes/release_24_03.rst >>>> +++ b/doc/guides/rel_notes/release_24_03.rst >>>> +* ethdev: PMDs implementing asynchronous flow operations are required to provide relevant functions >>>> + implementation through ``rte_flow_fp_ops`` struct, instead of ``rte_flow_ops`` struct. >>>> + Pointer to device-dependent ``rte_flow_fp_ops`` should be provided to ``rte_eth_dev.flow_fp_ops``. >>> >>> That's a change only for the driver. >>> If there is no change for the application, it should not appear in the release notes. >>> BTW, API means Application Programming Interface :) >>> >>>> + This change applies to the following API functions: >>>> + >>>> + * ``rte_flow_async_create`` >>>> + * ``rte_flow_async_create_by_index`` >>>> + * ``rte_flow_async_actions_update`` >>>> + * ``rte_flow_async_destroy`` >>>> + * ``rte_flow_push`` >>>> + * ``rte_flow_pull`` >>>> + * ``rte_flow_async_action_handle_create`` >>>> + * ``rte_flow_async_action_handle_destroy`` >>>> + * ``rte_flow_async_action_handle_update`` >>>> + * ``rte_flow_async_action_handle_query`` >>>> + * ``rte_flow_async_action_handle_query_update`` >>>> + * ``rte_flow_async_action_list_handle_create`` >>>> + * ``rte_flow_async_action_list_handle_destroy`` >>>> + * ``rte_flow_async_action_list_handle_query_update`` >>>> + >>>> +* ethdev: Removed the following fields from ``rte_flow_ops`` struct: >>>> + >>>> + * ``async_create`` >>>> + * ``async_create_by_index`` >>>> + * ``async_actions_update`` >>>> + * ``async_destroy`` >>>> + * ``push`` >>>> + * ``pull`` >>>> + * ``async_action_handle_create`` >>>> + * ``async_action_handle_destroy`` >>>> + * ``async_action_handle_update`` >>>> + * ``async_action_handle_query`` >>>> + * ``async_action_handle_query_update`` >>>> + * ``async_action_list_handle_create`` >>>> + * ``async_action_list_handle_destroy`` >>>> + * ``async_action_list_handle_query_update`` >>> >>> [...] >>>> --- a/lib/ethdev/ethdev_driver.h >>>> +++ b/lib/ethdev/ethdev_driver.h >>>> @@ -71,6 +71,10 @@ struct rte_eth_dev { >>>> struct rte_eth_dev_data *data; >>>> void *process_private; /**< Pointer to per-process device data */ >>>> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >>>> + /** >>>> + * Fast path flow API functions exported by PMD. >>>> + */ >>> >>> This comment may be on one single line. >>> >>>> + const struct rte_flow_fp_ops *flow_fp_ops; >>>> struct rte_device *device; /**< Backing device */ >>>> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ >>> >>>> --- a/lib/ethdev/meson.build >>>> +++ b/lib/ethdev/meson.build >>>> +if get_option('buildtype').contains('debug') >>>> + cflags += ['-DRTE_FLOW_DEBUG'] >>>> +endif >>> >>> This looks OK. >>> >>> Acked-by: Thomas Monjalon >>> >>> >> >> Acked-by: Ferruh Yigit >> >> Applied to dpdk-next-net/main, thanks. > > Ferruh, I was expecting a new version. > Did you address yourself the comments above? > > No, I missed the comment, if it is simple I can apply in next-net, let me sync with Dariusz.