From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E62943A50; Fri, 2 Feb 2024 15:53:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12DEA402AB; Fri, 2 Feb 2024 15:53:08 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 255B340265; Fri, 2 Feb 2024 15:53:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706885587; x=1738421587; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=srbcSn6zc12r0yrbTSi3Jwamwn2BxWgWQwQN/PcU3ws=; b=LFpH+DasAg5yWAVJxqT/JDqWbHAwP4BYEpq+mQc/vr5/BeQhsAG7LRnH 1FhQcJ5oVNyFuVP8bDqxXD8lJIjqSQlbLIkuUtZ6CDrC+bQ6fxzVgEYba 1nhUpArk7bEOAhhPf17wKYqmaXOhIhuTsxOiOAwMPHCSbsvc2qP44+7MZ eBpMO2BMscIIcR942/Vmk+KseyhL818hmPsJQAM97+pMoc4CAu6GZi30u X6EPUWBDEBtn+k7Nb47DOklmbwTkJKT6pWiExOmntgbDXU0jJAT6s1dTM jSOedgei/KqL9UnQU3QST9Uw5z3T0t3TI+gNvZzE/dmmDJuFKGqzp1Bwm Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="10822638" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="10822638" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 06:53:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="97541" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 06:53:04 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 06:53:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 06:53:03 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 06:53:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+Cd/iuvrnVFTm8murnJX6lWSRRHS2v0TX60pQPmPzC0RLLOAnTEuK07pi8UJAtgcp2cagPH392oBnKR8/bsXFv4oBmOIoGkbV3CoqXs0qj2CYqoCaxvDTw812vIp/W+xGKRnGSUIECdLP1gQuNH6/ywemw5LvM86hmf+ZHaLo7uAjujheXS39FEjP2gKnzejxdlGYGQWOV9nkuQy9qhqscV1Z8rCaWadVV+eLoFbsAe+5Ju1fyZN3LQIjrYvFLO3jQh/FjdUYENGbBd3Mr2ev+IwlioYsaCiPtttksFEaXufZMOgisjBT8qtf9Ioano93uNo3wBu68lHvGoaC/nig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0cruy4elHp5GnTGTxxZ3Bp6Ir0+5XiI7vbR1XMSwvs=; b=eviejeV+WQxJp7YgI2jdMAFTmSTLOJDBp+iQPVcW1hTNiq8aeaSK3GAFJXETYnG2nKkpT6GkJ/vYWOIpAmgRPUZ1Rk7sizRScq37I6ZVFZbALBAjc4bCNns2CDRK51GgtZFoyT3fppu/Ra3JHGe8Thj87tmBnn7Z7WMDIPUWVMdM3gj3MWz0W4jpttMJKFM9fdWBRD+DDbIiKqkAdcyfsCp5ps8n9d78R0xuvU46ol8NBWcDhztmI5SzXXGe/ceW7CQnoEYNlXTgsBIfD72c7azX1avT6i/MuEAg4hC4pQNKp60VaZL6c/HOS7gOaE0ciWJQePJd0J7n/Q6/36CecA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) by IA0PR11MB7378.namprd11.prod.outlook.com (2603:10b6:208:432::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Fri, 2 Feb 2024 14:53:00 +0000 Received: from PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085]) by PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::60f:d984:1a35:2085%4]) with mapi id 15.20.7228.027; Fri, 2 Feb 2024 14:52:58 +0000 Message-ID: Date: Fri, 2 Feb 2024 15:52:52 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bus/vdev: fix devargs memory leak To: Mingjin Ye , CC: , , References: <20230901072409.741847-1-mingjinx.ye@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20230901072409.741847-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7PR01CA0026.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::22) To PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6498:EE_|IA0PR11MB7378:EE_ X-MS-Office365-Filtering-Correlation-Id: 78b4550f-8c69-43e6-e368-08dc23fea520 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aXcMXDrSCl2g2JYUUlLJJ80SkuwauFjJrUql6iNC30cUeUCroLAEBTKFwz3vTZaqaVfV01zW6Oo4rLi0x18KDncKBAgg1n3ZoiKd6t8tiTnoIq2bnCrJo/bI/NNhwHp7JvL05PhoAQ5ZigLD2qAIJHjXhhJGVN7PSh1GRiXvtoJj8cPUdJGwPnOWkBKVmDZphJw4d009DGJvL7//OxU/mWIzBEnRX/T8QT9ojsVxyi3vsUn0ZerfizuUGW6DxU5W6tFDF1fC2XbAfkHlsdEosNOcyrjylTmidfwFGDB+LbYqLZIwmQQ4YC62Z55KC4bxKE1N/Ps9wBVHMeMuVJeXwSAdsW4wq/EKp+snAi0tg3oxMFlfYYwzBtEtIZ0hzWPHk8OITUVz0geF+kAYa56ZeskDwt6R0wuCye7F7EdFusYpHo1ke+aBEwL5CcI47cKYqvrY/0HUVJs9XH6SDv+BJuBIjp/DKdL2Rh2K+DXrd6XehbZyr8y+pF3X9EWcOYEEv7Hh8uxR+61aaEkPadQ1gFK5aL9nFB6fBsDjVJSCrkBXjj92eaQl/ZdskcAj8xkPsQb76jKUHmHjBEXfMmYDJ0Pr8hL/pinNnAFGc6r5EytLBdTYbIrZr2jfsZW5/ghuFH8bEFfEP6nmdwhm/0YgLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6498.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(366004)(376002)(136003)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(41300700001)(6512007)(2616005)(26005)(38100700002)(5660300002)(53546011)(8676002)(478600001)(4326008)(450100002)(8936002)(6506007)(316002)(66946007)(4744005)(2906002)(6666004)(6486002)(66556008)(66476007)(82960400001)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlhQME42NVk5SEZvNHRwSG9IMTFBMFVHcDB2aFh1ZVVPUGROSmxTR3FlMUZn?= =?utf-8?B?Vm1aeGpFQ0ZBRHdpNTdtWmsxR1o2QVZ4WE14ZmlsSExNd0hMWFNVQVBkWVFO?= =?utf-8?B?MWc0SmtIZURUM3Fnc0l6eDVhMUxwTWhIaWVmdlpObGdNOXl1dkFvMjdiMWJm?= =?utf-8?B?RWNNRXVRUUZ6QXR0UWxDVFZuQkM5VG9hdmNLN21lbTh2eXdHbWtuODNIRlNJ?= =?utf-8?B?aGltalhLWmRCN1g0cWNnOTN4TTgvQms3NERmQWJsalZaNFlIbzhkNk5YQ3hV?= =?utf-8?B?NnV0UFBndW5UYW9rM3hnQS9RanB0Nmp4cWw4ZWlTK0lNWjgzK2pMQmhYMUQw?= =?utf-8?B?VUFRSWwxVzRTUWpUeVRGMW5uUmFBY3dVSWZ3K1F2SmZMcWR0dC8wcHkxQ0hP?= =?utf-8?B?ekQ3YXQ4STR0T2RIYjFMdkNmMmlCMnpvRGJMMVlJQXZTYmgrQzlzSmNZajBB?= =?utf-8?B?OXo5aU56RFJCSGsrU0MzUTdwSmZyQXJsMVpIbk5uQmZuaGhQVytldlZ2QUpH?= =?utf-8?B?YWVuYXN6S0ZwaUpNdE53djJjUjRLNnAxWlFSbERmN2JwU1JLTGRyZldXejVq?= =?utf-8?B?akViSTlGcWEzNVJNNWREK0s4VkJRUWZYMnlYYXVJLzdrQ3BmZi9Tb1BoSXps?= =?utf-8?B?cElCanRpbGhyN2k1S0FzdzRwUnBYK3hOM3RubTY1enh6WDliY21HeVAxZHA3?= =?utf-8?B?THlWVmVIK1M5dnVwOVRraUZram05NHJtcSt2alUwTnJxZU90aTN0QXZ5MkdS?= =?utf-8?B?bnNZaVNzdjAxYWwzOUdsKzdiYlhPZ01kN0hZYkFBd1pxVzhJRlVNZUNOeXpY?= =?utf-8?B?dW14U3dUYmsrR3B5ZlpwNXRYYVJndlZsampndTR6dm9HQ2N0c0F1TXFuQjc1?= =?utf-8?B?S2JVaWR0R2l3Z2ZVWDJlTFg0OXIzNXZ2MFBvVWhaZlZhOG96dEorUGM5bk5S?= =?utf-8?B?ekRrQ2lZVEFBVmtTOU1QVW1SUjhVQXN6clhGNU54T21MbXdxRzN2VjdiSDRy?= =?utf-8?B?QnhGNE9ndWlEOTU2a1ZZbWhZbm9MUVRUS2V4UnBPRklwWGdicXdmOStPdVM3?= =?utf-8?B?QjdBWGxuUWRpK1BaKy9LZkg5dTNQM2prQWEvV0lVVTVESjZrSVFOOEZsMjVV?= =?utf-8?B?UERmNk9DTkhHTkFIMTh1N2VnREgwb3l3c25QU0FPeE9kOHZPTXEwbW9WY0ZQ?= =?utf-8?B?cGRYMWJqTW4wZ09MWHZWMHcvUFNZbHJ0dGcxMm1ZaVc0djl4ZmxsQm52b0Vx?= =?utf-8?B?STVFRVdzd2xzdHJwTFRYbCtVVDdHYmpJZUkzSllleU4wRmNjanQ3Q0ZJMmlP?= =?utf-8?B?MmdTZUJMRkNMT1ZOSlJKQVdMZ1ZhUXA3QzhDdFQvLyswK09rVWk0NkJQekpm?= =?utf-8?B?Mm5FNUlrUGhjUVV4eXpoNlFOM0F5VGZ6RklpVm9ZZjEzemJ5WldXQ3VYazUy?= =?utf-8?B?NUx0VThqQkZRVVFsWTUzTWxLZmx6NUN1NVlvNTNlZnpuYis0QVRPdFlOY29i?= =?utf-8?B?eWVjV0tuY0tEblRlcmtiWEEzM09iZmJjTXJrbDJjOG8wVmo2clp0S0FWaEZV?= =?utf-8?B?L2cvY1c1WXpORG1hSXRsODZJaFdjVXV5cFNJNnJMajk3ZlRrQ0hObXI1eGp6?= =?utf-8?B?RkZXR0d4cEVqaGp4dmxpeUpwSGVybDUyVUJnNW5SWDJKcWFTcmh3SFdRV2l5?= =?utf-8?B?cDNTdWN0L2VJYmhxSENnZHdYdG9NemxiSTFKTlpxeTNiT2VlYkR5eG5Wbnhn?= =?utf-8?B?a0pzRjIwdHBzQTliMW1kc2dpamxwLytIazhQSDl2YXZ1Zll3UnI4QmxTRWdo?= =?utf-8?B?ZGRDQXU4UmxYTmdFMHIvaWNSZGlsZzFXQWxzVVJpN0hIUTFTdFZLZHRLcFYx?= =?utf-8?B?NEtGTkRHS29za2d0d1Y3YVowNFVHVEgwcGJQdVozSDB0MHJHdElMa1BTVFRR?= =?utf-8?B?eUVERllMenNyenBiTXc1YzdTeUdtQk5nK3R4QmdXck1pKytaNmdLWHlncllB?= =?utf-8?B?cWFabFRkd2tPS2hHODE5Y1VpOEhydU52bG5iM3YxRzcyMXdzQVVPQUFmTktx?= =?utf-8?B?SlJ6d0o2YTZBcFc4Y2VRcUdYaVQyV1hUS2Q0K3Rmb3h5d3BTZ1RMUFJNUjRY?= =?utf-8?B?eXVmNG5UTGE1QkdEUHdrZ2s1TUdZU1VLMjhITGV4d0xkT0xCOGcwQzQzZy9m?= =?utf-8?B?NXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 78b4550f-8c69-43e6-e368-08dc23fea520 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6498.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 14:52:58.3269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GxM+BigVTkIIsuB0Pag7Sm++6Sv0b906dNLIFaePAFL3C14CIhbFFSCgdIBxDnJ0rjSZv1Fv2x3wRVf9es7bUEvVSLKWBYwkguYE4qcGJNI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7378 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/1/2023 9:24 AM, Mingjin Ye wrote: > When a device is created by a secondary process, an empty devargs is > temporarily generated and bound to it. This causes the device to not > be associated with the correct devargs, and the empty devargs are not > released when the resource is freed. > > This patch fixes the issue by matching the devargs when inserting a > device in secondary process. > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") > Fixes: a16040453968 ("eal: extract vdev infra") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly