From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5865BA0471 for ; Tue, 13 Aug 2019 11:40:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 211881BDAC; Tue, 13 Aug 2019 11:40:16 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 0D39A1B94A for ; Tue, 13 Aug 2019 11:40:15 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id p74so864469wme.4 for ; Tue, 13 Aug 2019 02:40:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=dqg/GPm43DCcQBPF3Dboqx+j1HhxgJvtOJF5tP3S6Rs=; b=HcEkWzbRjzVF+R3103WrLpuK7qFuvrakbNmTChxfGDwwOWlnKjVVtRwNE6QuFNHkVz MZKBuJ6tOjInFGt6cOY8myu/1Bo01c2DTXipMkj9haealxMvj4lgeRsHYXBbL9h8xmHA ziarW2w2lt5OxDUNRie6vuwP7C752LR13sw/Ja6fRZyX3l3JJ+0eNHXa1/kS4hFhtxGZ U0uce82Q4/3+ob9R205YP8VKPERHg3sbmKpEIwqdmsY36kLpkGuoo9zBcIYfcokIsJgp O8qWc2kKESmaX62ySKW/CpY2NckRg/APZOrpsEvueCcRqNTeVqbMeB7zIZ3sXxqs6y23 Pz2g== X-Gm-Message-State: APjAAAWKGhe7aRANaDX/GBf6ORcuobmBoCglhIXBsUVVprR2cMTwvfDX G1nnf+pca+IOdNqFKQ7UOmycLHsgR8k= X-Google-Smtp-Source: APXvYqz6UY23DxUs1tR3+PACP/PX1bnW2fqhy/o8YxpwmSDxKUgCIDZ/VSc6Dlora3I+ScsKEjfNYA== X-Received: by 2002:a7b:c857:: with SMTP id c23mr2225462wml.51.1565689214580; Tue, 13 Aug 2019 02:40:14 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id z2sm733786wmi.2.2019.08.13.02.40.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 02:40:14 -0700 (PDT) Message-ID: From: Luca Boccassi To: Thomas Monjalon , bruce.richardson@intel.com Cc: dev@dpdk.org Date: Tue, 13 Aug 2019 10:40:13 +0100 In-Reply-To: <20190812230358.988-6-thomas@monjalon.net> References: <20190812230358.988-1-thomas@monjalon.net> <20190812230358.988-6-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/6] devtools: test compiler availability only once X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote: > The compilation test is skipped if the compiler is not available. > In the case of gcc/arm, it was tested both in the generic function > "build" and in the cross-compilation section. >=20 > By passing the compiler as argument of the generic function, > the test with "command" is done only once. >=20 > This small clean-up has the benefit of introducing the compiler > parameter to be used later in another improvement. >=20 > Signed-off-by: Thomas Monjalon < > thomas@monjalon.net > > > --- > devtools/test-meson-builds.sh | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi