From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2CD867D30 for ; Tue, 2 Jan 2018 11:27:11 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80801552C7; Tue, 2 Jan 2018 10:27:10 +0000 (UTC) Received: from [10.36.112.13] (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 169B25C1A1; Tue, 2 Jan 2018 10:27:04 +0000 (UTC) To: Stefan Hajnoczi , dev@dpdk.org Cc: Yuanhan Liu , Tetsuya Mukawa References: <20180102093136.28690-1-stefanha@redhat.com> From: Maxime Coquelin Message-ID: Date: Tue, 2 Jan 2018 11:27:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180102093136.28690-1-stefanha@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 02 Jan 2018 10:27:10 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2018 10:27:11 -0000 Hi Stefan, On 01/02/2018 10:31 AM, Stefan Hajnoczi wrote: > v2: > * Add internal vhost_vring_call() helper function [Maxime] > > These patches eliminate code duplication for vhost_virtqueue->callfd users by > introducing rte_vhost_vring_call() (public API) and vhost_vring_call() > (librte_vhost-internal API). > > Stefan Hajnoczi (2): > vhost: add vhost_vring_call() helper > vhost: introduce rte_vhost_vring_call() > > lib/librte_vhost/rte_vhost.h | 15 +++++++++++++++ > lib/librte_vhost/vhost.h | 12 ++++++++++++ > examples/vhost/virtio_net.c | 11 ++--------- > examples/vhost_scsi/vhost_scsi.c | 6 +++--- > lib/librte_vhost/vhost.c | 21 +++++++++++++++++++++ > lib/librte_vhost/virtio_net.c | 23 +++-------------------- > lib/librte_vhost/rte_vhost_version.map | 7 +++++++ > 7 files changed, 63 insertions(+), 32 deletions(-) > I just wonder whether tagging the new API as experimental is needed, but apart from that it looks good to me: Reviewed-by: Maxime Coquelin Thanks! Maxime