From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77A3543B49; Mon, 19 Feb 2024 09:24:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E352D40289; Mon, 19 Feb 2024 09:24:51 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 3E95240275 for ; Mon, 19 Feb 2024 09:24:49 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TdbDG4Ck0zqjBk; Mon, 19 Feb 2024 16:24:14 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id CDCEB140157; Mon, 19 Feb 2024 16:24:47 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Mon, 19 Feb 2024 16:24:47 +0800 Message-ID: Date: Mon, 19 Feb 2024 16:24:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RESEND v7 1/3] ring: fix unmatched type definition and usage To: Thomas Monjalon CC: , , , , , , , , References: <20230117091049.20194-1-haijie1@huawei.com> <20231109102046.1277893-1-haijie1@huawei.com> <20231109102046.1277893-2-haijie1@huawei.com> <4429509.yaVYbkx8dN@thomas> From: Jie Hai In-Reply-To: <4429509.yaVYbkx8dN@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/2/19 2:11, Thomas Monjalon wrote: > 09/11/2023 11:20, Jie Hai: >> Field 'flags' of struct rte_ring is defined as int type. However, >> it is used as unsigned int. To ensure consistency, change the >> type of flags to unsigned int. Since these two types has the >> same byte size, this change is not an ABI change. >> >> Fixes: af75078fece3 ("first public release") >> >> Signed-off-by: Jie Hai >> Acked-by: Konstantin Ananyev >> Acked-by: Chengwen Feng >> Acked-by: Morten Brørup >> --- >> lib/ring/rte_ring_core.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h >> index b7708730658a..14dac6495d83 100644 >> --- a/lib/ring/rte_ring_core.h >> +++ b/lib/ring/rte_ring_core.h >> @@ -119,7 +119,7 @@ struct rte_ring_hts_headtail { >> struct rte_ring { >> char name[RTE_RING_NAMESIZE] __rte_cache_aligned; >> /**< Name of the ring. */ >> - int flags; /**< Flags supplied at creation. */ >> + uint32_t flags; /**< Flags supplied at creation. */ > > This triggers a warning in our ABI checker: > > in pointed to type 'struct rte_ring' at rte_ring_core.h:119:1: > type size hasn't changed > 1 data member change: > type of 'int flags' changed: > entity changed from 'int' to compatible type 'typedef uint32_t' at stdint-uintn.h:26:1 > type name changed from 'int' to 'unsigned int' > type size hasn't changed > > I guess we were supposed to merge this in 23.11, sorry about this. > > How can we proceed? > How about we drop this amendment (patch 1/3) for now? > > .