From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01hn0232.outbound.protection.outlook.com [104.47.1.232]) by dpdk.org (Postfix) with ESMTP id E665A293C for ; Fri, 23 Feb 2018 07:25:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0zUjTdXgyZokcgRp9Nb/jLZjrbOfvp2HfMO3bt6kpUc=; b=TWpvWisTLNjAZjxyuJ9wZZhPcKz6kMduncPO7COg1yOFraFq9snZpZdHtiwIh3LDRuHk4e5A4L3ZGuT4SIv1qQXov5o1br/iMEv1Iv4WlhI9/aFX2xUSpapcrQNxie9iLtgHU7kMzmhTzJqpb+GygPNYL6lcZri5TFsSFD5JkiE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [10.232.133.65] (192.88.169.1) by AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Fri, 23 Feb 2018 06:25:49 +0000 To: Thomas Monjalon , mvarlese@suse.de Cc: dev@dpdk.org References: <1519329652.2458.5.camel@suse.de> <20180222225308.16972-1-thomas@monjalon.net> <20180222225308.16972-2-thomas@monjalon.net> From: Hemant Agrawal Message-ID: Date: Fri, 23 Feb 2018 11:55:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180222225308.16972-2-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: HK2PR02CA0193.apcprd02.prod.outlook.com (2603:1096:201:21::29) To AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1235081-e9c2-4ded-7c0c-08d57a86495a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0754; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 3:zRZMK2BZf93fiKJPxo20G4D6cdZ6awA8Qrd9BXNVorEOYUzjv9lXjASSYytlDfhTUl85TQYIVrkLpEFlb49WUge2F5uEMeVwCo4a0Rl6gngWpOMW30SbMLsKzu+8kMLBeYctQZA29i4QnF2DQPjTzXDXWWeq+t9SggmLsLeOeO2smp2RiTOPsfu4aG6VxNNOec8BYIM5yaqmKnXsv3Md0Na0kCHbmw66VJLOJR5mhen53te90cCosyMe2K4eVjIr; 25:N1rkE595EkVt9hjWXbcVHaKByRL0MaxLGNYJKQXLybzbderoRa6Lw7TrmjjwYKkJxoIsxs+xzoPzbDQxriT2p1BeDm5Zn2gdB5D+sR5uXyjV1KHgDPi1IvHcv8zjxeETX3dTSh/32rMWBbVNsTGOWpQSSO40WMpvRgzRQ08Ri8FAYNyc951nkSwIFYM6xNBEzkiUZyKf0Lb3lp6mPot+Lj7hRSrmr9NDuQKy4Rm0JjFtQQrL6+uVfy+YOnhwX/Od5bwJcJdlObDGwG+rZKRKYaeD1zGyZLzNj6Udj9uqsqV647sOtE3m1RfgucMVfjtBMlQq17DVXCacrkLCZmcJ+A==; 31:S+x9yNiEBYTHW4zJzYjHKz16avVBQ7VSV2rGrajzdFYf2ZDa5jaJ6cReYKcoUjcPsVw1Ek+e2DnUbVX7kbqrKphdgkv7mg6Pm/fbe5DxAPIidfrxr/K+uzDUHe08xIG4+c8IF9hyrlluKNrZ/0PNvjd7iEXunWbAOAqgupzQJJkchTsxJR67zCC8CRKRptK8bvYjAP+ICOuW5qVhj5fqGz8ibUZdhGuPP4iBbdHOb6w= X-MS-TrafficTypeDiagnostic: AM2PR04MB0754: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 20:E0/Wo9CpQE/t7b/D7PvP+dHUieED4Dunay+Z24e2fbjjrYMAdlcGq+UUk5Lu/Iejh6SdHQG0DaVpMZY85fQdXIghxStS+z55Qxc/S2KWU0EbZn42QhPvNym10YFNFXmqrKwwf3fYytbERaZcVHYjbRI3/BrBL4GMoCh4CqxQLSvC++oz0DwwixdUzH7lNKtgxtU/ZLVwR2gF47LO4FyWmDHD1EO55o9CLoRrI/ZT0gUM/C4T61DnlHyujQChI9kh6fq38opjaXWGCJH26+emO5WXWMFL0uwVLlENkyHXSaz8empnPlcXj33U2y5HDmQMfGSaVL87c4YVXgOdYEFYbEy2BUUz5zH0BU9+EwiMKtRDykkm1KrLp8QQGBz04v6Lcfjmp1LaEbyZkJ05kDjlE+KuX9c/yg5eLKkIjW37tYpa0pa53PusLSsG+rlMZecv/An+Lr4TZMIWfQzoNNHNgWxwdriU2X4/e9U0otgN6qNlsWCYPFKURNP0BqOFdCGr; 4:9Hd1zFmyqNOW2pHkSxpPPAHWpIYshxC0Mo/seiNTb4VfkAokpBSgEo4geG52YPgq/RyDLmETF1gMkthAWxNnBbbhLLc93ILH3iA8Trh+y5SH/2sKb41Rk9cKXjAJPfG7JgnTtwB4+Ugv860iPzZMDAxEdYV7iSZiboLv0Rf5iJ9iYsci9cC8nYcNZw4NaTA588CZom2thF4h0bfRbyLvUuIE833alGzHPZvH+C+db2dfXfRPk965Z30oKcTGq711lpr+6zdeRkLNQgvS9n2sXPUA+qZ9psXZdTe2pyPYrRmztudTmaLgP9CgVbgOp+Rg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(66839620246622); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001082)(6040501)(2401047)(5005006)(8121501046)(3231101)(2232076)(944501161)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041288)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0754; X-Forefront-PRVS: 0592A9FDE6 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6049001)(366004)(39380400002)(39860400002)(376002)(346002)(396003)(199004)(189003)(25786009)(31686004)(81166006)(6486002)(77096007)(186003)(2486003)(81156014)(6666003)(76176011)(26005)(16526019)(5660300001)(97736004)(229853002)(64126003)(50466002)(105586002)(8676002)(36756003)(4326008)(58126008)(106356001)(316002)(7736002)(305945005)(23676004)(230700001)(67846002)(65826007)(16576012)(52116002)(53546011)(52146003)(478600001)(59450400001)(6246003)(386003)(31696002)(3846002)(2950100002)(8936002)(2906002)(65956001)(6116002)(86362001)(47776003)(53936002)(66066001)(65806001)(68736007)(59010400001); DIR:OUT; SFP:1501; SCL:5; SRVR:AM2PR04MB0754; H:[10.232.133.65]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA0TUIwNzU0OzIzOlgrV2FzdkgvYk9CeHZsOFBDSFYzMmh5aVBW?= =?utf-8?B?SWxrM0JDRHBLdnpFRmZxbmJpRUpxOTh1c3ZMcnROYkpnd1BDYWFFd3M0V2RL?= =?utf-8?B?S01xNSs5b1MxNnAwQ2RFR2RNQnV6d0pjVlRETkttN0lWWkFhenJpbGRnR0g4?= =?utf-8?B?NkhZRkJ4SmtMUUpHSlVkeHhvNk1DRjgzQUdqMFdXUjNsaG1CZHpYRUVkaTBi?= =?utf-8?B?dFBHNXJmektIN0lLakN4YkpDWTk0QmpmdzIrQTBOUmhKdWdqcUJIQU92Ymll?= =?utf-8?B?MUdhemhCUms2Y0ZWS3poWWl6Rk9KRmwwSi9jNHZPRmlMalhQaTNoczBSSU1j?= =?utf-8?B?V0g0U3d3Q1hxQkowRG9TRDVRbzF0Y3kxdVdEYzgyZ3MxUVFaQ3BHcHRWZzcr?= =?utf-8?B?WGEydVkwOFhxV3VoZ2svbjRYZFc5a3cxM05xUVBKai9RbDR1bVlCMlVRSzUz?= =?utf-8?B?RGMrQ1dqSlE0VmNaN3RteGpZWE1ZRU5pM2NvS203UVBvM3RXR3pGbENRejRj?= =?utf-8?B?UU9XVmdKMytxOVYyOWZYNkQ0ZXVXYkNEc09jWW5aY3g3R240dDJBamZVSHht?= =?utf-8?B?T3RuQy9vVlR5dEVtNzdNRGNnbG1ac2MxVDNINkF4UTdTRDNzdk5LTmp4ckJn?= =?utf-8?B?Z1pNYkRmSnFtZkRTbHl6OVphVmFKTFZSWDg3OVRIR3dNRnZ4MVI2aTg2NzFk?= =?utf-8?B?N203S0JHUmpxQjJxdlhIY2hVUlhQWDA2YVlhR2hjdGFUVUY3cStObjZSN1Zy?= =?utf-8?B?YnQ3RFYralBlUFIyQ2xRb1NPYllCN1Excjlsc3BmMWZjR281b0xRNDhqbXFN?= =?utf-8?B?R09OcEU5MndRU3NJSXR3WFN5NkpzTDJqbUw2V0t4VENFY3lCUllnMVlrNnFG?= =?utf-8?B?bU8rbDNoelBuRUticTZvdy9Jb012U3ZFSUkzRzBQZUFsc0VyNmtOWTdSUEVY?= =?utf-8?B?b1BSWk96Q1ozVlhieU12RFNYYWk5QTlaUkcvb2RwbkYvQUw1WklKQmQ2VmlF?= =?utf-8?B?SmVKZ283VktraDdDbmFRRDBZQlBndldhMExJaFJrN1JNNmlvRHpSOE1jbmlX?= =?utf-8?B?RlZOUW9lQjJhalNweTg3SmNvbFcrbWdKbWNnaEhqNTNPUFl1ZTJ3R0liNXdx?= =?utf-8?B?SEN5eEJUTzZNc1R5RnovRWd2cFNTWkV0dDREekxFZm1HYVpZcXJ5MnEwdnMr?= =?utf-8?B?TFoxcmwzQlJLSjM1UGtodTBTMHU1WjQvV3BmM0pXRkVZQ2NsR2VhVkxVQlAv?= =?utf-8?B?U012OHNrVmVUTWJiRC95QXR0d3hsZXlBNmdBaEZiV0FZblIzWjA0aUg0OXBN?= =?utf-8?B?MTd3NjF4MCsrSFVKeHgwODNHSDhvd1p4Y1dOUVBYaVlMMEZWSjE3S2s1M1hm?= =?utf-8?B?bXpjWGZ0Nm1kdkxSMCtmMXN5dHE1VGRpNHc4ellmRGZtcmpxTzNtdUV6UDR2?= =?utf-8?B?b0Q3SktUWnQxa3htRSt3WkJFWjdvQitmUmIxZE1ySTNBZ2JSZ1ZkNXA5bGRr?= =?utf-8?B?Z2tQYSt1UVdrK2JYYXdPQVVvcFkvVUxLS3lxNXdmMFZtblZmMHlzU2F1WGJR?= =?utf-8?B?ekhQdDZxdjdrd1BSNXpMQ1p0dmpnV1BQRjJpREVZMFdJRWErNHZsdklJQnlz?= =?utf-8?B?VXFQOFpGY2F5Mk5MazNvQVVJWnNzRUNRNHUzY2ZvbG1qdzc4NHdZa3NucGhQ?= =?utf-8?B?MVpwWTZhZFB5b1czampvdWFPM054UUVsYTRWSk5aZGdrZWZDdE5CQ2prVUtU?= =?utf-8?B?ZVI4M29uZ01QOU5tZnk3bStqLzgzc1NuZkJQWDVPbmFqYjh2VDl1QnNwNVJT?= =?utf-8?B?cjZGUVdiMEhmWGhscThudGFiMUlCUXVwOStYNVlQRWhVTXIvNlVSTy9DZ2RQ?= =?utf-8?B?bUNLdTJBYzIyRWV4SWJFTVVxT1FnbW94Mk5TU0YzQ1AxQ0RPTVJweXRHWDRC?= =?utf-8?B?dU5sMnZaL2RBPT0=?= X-Microsoft-Antispam-Message-Info: cmS6KgkfC504v2lxp4+8LtD2jUaushDb2Nf9+r5BaA1RIjAdQonSxZ9FmNI9OR5ZdutPio6HgsxV/Y/UNWN7pioMEvUuSkP7JMmFH+N4esAtrCarVsVzEzGGrTPVGdh/dDE2Rq2PjWLYVRhXt7oPPCc5Y04BjqJ4eIiTzJRsHNI= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754; 6:ekXS+Xhj4gsjMOcg1eWUA43zl9dg5V4q+EhYXneAyDxnGOizy0mKYawqpSjpGeqHDtg+Jjz8rbpk+7/HjmJo8Lzt2T1MYzbhbLDFnIEqFaO0ZrWPpW8Gd5GxsKGDMILSec7qbLC0CJpHHts8tFpJsUP/sLO47a+ckBaHaBhbwTg6yD9+Z4ceMRMB/4SzCLHi4qtVthCZqY3v+FBvemHZ6dQR7E4he8xVqCwm9OXgZ6ElTjETreVvbptctf66RkbGZgW/zEDmlFBuZSflY8eP2hxlSnznEdY7B04Y1Hclo8ZDBFmeKfhf2BZDKmSyc8pjyqPjjFwA1bICFEdqZrgW56Y8x3WN0YwPtMo9ZO8iGRI=; 5:FmgoKH7MgtL5qnwHWHxv3xY285wH4JMKkkej5IzDqaqk/msY0ihYGN+WL/FZ3eOygZ3aOLvIi0SAoXTfOSm1oun1FUzm2DNVXHITt5gBvDkP08N8rz9LypB6R0+ZdT5VH02tV/sUrQ3BGRqV3iqWsz1Nf2QSY9qp42Vk+IiBj/w=; 24:wQ7lKIspjmsoauLJwyWowCUOUkrWZxZE/t1bdffClWorEML4pO5FXPyKiW0o5b2/1oMZ3g9B8yksHX3pCH8dnA==; 7:519lCKmx8HurnO/TwgGkBrKdvLl5m3y9G2PzGNXf2s4i6bed8M8toez7BJnsjk9t9yC0e96ZxIk1+wckO2bflOm47+2gHO73h/m/yGBnICNYH8Lc15j6wheA2mjtPftyTZqsD16hIX+kFlivWv2AfF+uAPtAUIH5UeOC/1bA3j6ZqVgVhaynrDhsXn+XoL74zvSY9F/FmLSeNyZmqD1rmC2XcDOrc5tgDaLupfkTKiW6G8lrkB5VoeSXTAFBZz5J SpamDiagnosticOutput: 1:22 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2018 06:25:49.8447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1235081-e9c2-4ded-7c0c-08d57a86495a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754 Subject: Re: [dpdk-dev] [PATCH 2/2] mk: clean up static link with DPAA libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 06:25:53 -0000 Hi Thomas, On 2/23/2018 4:23 AM, Thomas Monjalon wrote: > The bus and mempool dependencies should be declared after the PMD > libraries needing them. > > Moreover there is no need to disable the PMDs at the Makefile level, > in case the dependencies are not met. > Such dependencies should be handled at configuration time. > > The other side effect of this clean-up is to take into account > the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.app.mk | 20 ++++---------------- > 1 file changed, 4 insertions(+), 16 deletions(-) This patch looks good, however I think we (NXP) need to also set some dependency check in makefile to avoid dpaaX PMD compilations, if bus is not available. I am working on a patch for the same. Regards, Hemant > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 3eb41d176..b71a71663 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -127,11 +127,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lrte_pmd_bnx2x -lz > _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += -lrte_pmd_bnxt > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > _LDLIBS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += -lrte_pmd_cxgbe > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += -lrte_bus_dpaa > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += -lrte_mempool_dpaa > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_pmd_dpaa > -endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_pmd_dpaa2 > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000 > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena > @@ -204,16 +200,8 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -lrte_pmd_armv8 > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -L$(ARMV8_CRYPTO_LIB_PATH) -larmv8_crypto > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO) += -L$(LIBMUSDK_PATH)/lib -lrte_pmd_mrvl_crypto -lmusdk > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += -lrte_pmd_crypto_scheduler > -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_mempool_dpaa2 > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_bus_fslmc > -endif # CONFIG_RTE_LIBRTE_FSLMC_BUS > - > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += -lrte_bus_dpaa > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += -lrte_pmd_dpaa_sec > -endif # CONFIG_RTE_LIBRTE_DPAA_BUS > > endif # CONFIG_RTE_LIBRTE_CRYPTODEV > > @@ -232,10 +220,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_RAWDEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += -lrte_pmd_skeleton_rawdev > endif # CONFIG_RTE_LIBRTE_RAWDEV > > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_PMD),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_bus_fslmc > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_mempool_dpaa2 > -endif # CONFIG_RTE_LIBRTE_DPAA2_PMD > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += -lrte_bus_dpaa > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += -lrte_mempool_dpaa > +_LDLIBS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += -lrte_bus_fslmc > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += -lrte_mempool_dpaa2 > > endif # !CONFIG_RTE_BUILD_SHARED_LIBS > >