From: Ferruh Yigit <ferruh.yigit@intel.com>
To: viveksharma@marvell.com, dev@dpdk.org
Cc: intoviveksharma@gmail.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: introduce QinQ and Rx offloads argument
Date: Wed, 9 Oct 2019 09:20:02 +0100 [thread overview]
Message-ID: <b600738f-3a54-2d9b-786e-366712f25b6f@intel.com> (raw)
In-Reply-To: <1568376860-9502-1-git-send-email-viveksharma@marvell.com>
On 9/13/2019 1:14 PM, viveksharma@marvell.com wrote:
> From: Vivek Sharma <viveksharma@marvell.com>
>
> Introduce boot time argument for configuring QinQ strip
> offload and for configuring all rx offloads.Fix port info
> display to distinguish between qinq strip and extend offloads.
>
> Signed-off-by: Vivek Sharma <viveksharma@marvell.com>
<...>
> @@ -198,6 +198,10 @@ The command line options are:
>
> Enable hardware VLAN extend.
>
> +* ``--enable-hw-qinq-strip``
> +
> + Enable hardware QINQ strip.
> +
> * ``--enable-drop-en``
>
> Enable per-queue packet drop for packets with no descriptors.
> @@ -385,6 +389,11 @@ The command line options are:
> Set the hexadecimal bitmask of TX queue offloads.
> The default value is 0.
>
> +* ``--rx-offloads=0xXXXXXXXX``
> +
> + Set the hexadecimal bitmask of RX queue offloads.
> + The default value is 0.
> +
> * ``--hot-plug``
>
> Enable device event monitor mechanism for hotplug.
>
+1 to both arguments, but they are independent/unrelated, can you please make
this two patches?
Thanks,
ferruh
prev parent reply other threads:[~2019-10-09 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:14 viveksharma
2019-09-29 4:28 ` Vivek Kumar Sharma
2019-10-09 8:20 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b600738f-3a54-2d9b-786e-366712f25b6f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=intoviveksharma@gmail.com \
--cc=viveksharma@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).