From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 198AC439D2; Fri, 26 Jan 2024 14:43:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8745E40289; Fri, 26 Jan 2024 14:43:27 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by mails.dpdk.org (Postfix) with ESMTP id 1968C4021D for ; Fri, 26 Jan 2024 14:43:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ls1ot8WF+NIZWejraclHfciyW04mrJhrO0sb8yFsvny7pxh/U/QWqXENYU3mFO6Pz4otOA2YQLnl5B3Oz79nsEKhQ5NKVoITzyYiPcH5AhfHGwtjpzzVZKBMsUJ1P9CEnK8a9NRTTVJ49yJRMjXSS/ccHP74NOpNB0b8//UZURKn4Dy3s4bkKkBHnIGfp3lxBnJLQV0bixZIkO0Leqf67WJsrtn2vnuZoWa+PZ3EB59CE6RXa3dB27sykKEI6lW5YuipnJ7sk89h26RQ+qOiTSylkHlzk2uT6YahSnw84Nd2bmSeBQXPWjf/6/6gjlIG3kKJAiJIc16l5N2Dh8Dlvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GPmQtSL2MxezvTDF1f3jFeXrzucKeUGzZUUGN2SKn9Q=; b=fOMZ2AGJ1qTKqQlwKACkQAwxv4KHYt/kPXZFPa54hKnfz87OoUapI7JYeYoDs4+fTvOAN6r8ls1m0eFFISmdx5PLegDg8pW4ubrwBAodPZrpFX2nPpxJ4T8lIvyoJhKsBeKIGq7XINTJF65jH7R3L7d5ofox6BiQHyNGetc1MOzSsFMxXvG5Vky4coEGd2/2rSylU2gZYvi7u1s/PNT/7SC0wlZR928xcWE5WRlqVIpVrexA2P4MJfnrru5L20bEFditJFcrVNq1LY/a8Nq93E9KiX/sB/20RgZMmLHfAoXp4/yKaxZ8IMe/4ktm+jlR5DxzxPaKV2rhkg1tpPJFmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPmQtSL2MxezvTDF1f3jFeXrzucKeUGzZUUGN2SKn9Q=; b=tMqE/fz61/ZIUlaSil12Vodnaeo+ASamu9Nzh4uPa+PqbRATX9mkvw686tBk5bni6SgJZX3dLYiXocjwGDZM8Nt3ZKLrXEm5Ywt8SNxa15b1RKWF1wMMtCLEXABSJ4ofmzNnN8iB/hfC6Fzgri4Lp09+qV88tyd3AAGnHxLC2BQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ1PR12MB6146.namprd12.prod.outlook.com (2603:10b6:a03:45b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 13:43:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 13:43:20 +0000 Message-ID: Date: Fri, 26 Jan 2024 13:43:13 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/1] ethdev: parsing multiple representor devargs string To: Harman Kalra , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Yuying Zhang , Beilei Xing , Qiming Yang , Qi Zhang , Wenjun Wu , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Chaoyong He References: <20240111064432.193119-1-hkalra@marvell.com> <20240121191908.156149-1-hkalra@marvell.com> <20240121191908.156149-2-hkalra@marvell.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240121191908.156149-2-hkalra@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P191CA0040.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:657::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ1PR12MB6146:EE_ X-MS-Office365-Filtering-Correlation-Id: b8fe8333-d811-4b72-5d93-08dc1e74c21a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7MY59uBAIo1/PO8Glqu4QLNpLLrJ4usEHieOL90bkzVCF9Vz+jRTePKPDhnkEWlvTxJlpLHFbpZQ/gperJvSLtfrD3L94O3LcwV7p4ZvUQ8/a/XpZg3yuz9+eDHldNTbIj9gwFyILfyWZamF6PoGH3GQrbKBO+xahKHEmQAkl9cvcUvcwkedgHKYqXx2hPRb7yhQ2tg9/9KKWwu4mitJN5FMOR64SUx/cqH8FuvUvsh6YweoLkykBgWtK0y0DAMc45eZJ1d9AiKwe3kD0wMhKm5IPfmn2jRc5JgfoOpq9DpyaEmDKtTwYYxCYszTHrjzTrkn+KiXxmBwDEO3wyPfmc7r9PWKX8rzyISIdKq2kBJT/S3g+jKdinAze7vF/qorDPrOtKJ1yzM3qvM1OFr49dGs/zjHP/y2t14rLRbBM35KXoTIlKDPlhp6SfewxyezMQIGhjQTbIycsDm8Xb4r4doE2PfrZKWm0X91wPJ1RvlZQbIaIqPrsGFP8i4CPqJlbC9/s4yP2Z+HD/5FVHe4BW1tPujHIZ/Mlg1eCv85Wj1PRFpJCE36TPGHz6CdctmWuUGTvEXOmWkYxHUPso6Ui1ctg3IvdDNPCTBW07pclKYm3OaVLEwPufi0YqRFIxKMrnbEmh12H5CW+5rga8MJ3VSSV+W/fhC8PmlBSnK8dFs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(39860400002)(136003)(396003)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(83380400001)(26005)(53546011)(6506007)(38100700002)(6666004)(36756003)(921011)(2616005)(6512007)(31686004)(2906002)(478600001)(6486002)(31696002)(110136005)(41300700001)(7416002)(86362001)(5660300002)(66556008)(66946007)(66476007)(44832011)(316002)(8676002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEN1Q1FNSmlVY2ducCtTZGRLQkdlTFZtMWd5UkhzcVFSZmZ2Q0dabWo1amhy?= =?utf-8?B?YkYyNUV0OXpWaHZhSHhuTWJiYW5xaW9xSlZvRDNzUm9sR0dNWTJnNzl0ZG9H?= =?utf-8?B?bzVTOXBldFZ5c1IwZDlHMnE2cGZGSW9LUzlLNU9zNldOYktHOG1xVTNhQ2lm?= =?utf-8?B?OEpuTmV6RnhIcDNIVmRVMlp3RTdXWlZVRERWUlF2NVpYRFJQcDFsUGErd05x?= =?utf-8?B?Y0RKVGNHbWdZeFF1dERaSFZ2aEhJdmZMSlFLczNSamhvV3JYNzdZKzJ3SkhW?= =?utf-8?B?UGpoT2FjZU00Y2JOd1RiVkhXaE1QYlNCZlVVUU9SQmlRZXloRWh1Yk5oVkJr?= =?utf-8?B?WTUyMUY4ZWE3VVdIYnVhb3NlNEgySHZEU2VZTmZVanR5Q0taTHFkamNwczNM?= =?utf-8?B?V0Uya0Q3UzY3UWFFWWh5R2FLVitZWWZSSVhpSXBXdDlLamF5WjRkV2pNdTN6?= =?utf-8?B?Y1BhMk8xTjZ3VjU1c1FZS3FNc28zcEx5Y3J4eWwwc2hCN0pxWG9UL01mS2tT?= =?utf-8?B?K1Y1Rm1pYS9yY0hVd2R4VmxaM2FvdmsvMDlnMzM2YXhuRG5mMnBEV0lQSS8x?= =?utf-8?B?R0xXZ3M3T3pFNEdNZG1sVlZ5ZlloZlJ1dGVNTFd2UzVsaWY3d2hvZkFyTEhH?= =?utf-8?B?UFZTUFZralNaWVI4MUxsNTRsdXkwQ0VoV3lBaDc2blo4RytvbHhPVjdtTDI0?= =?utf-8?B?a0FQNUU2cDFHdndSUkxCTUt2R25DbkF5bllldmJ5cE1rOERHL25DQ2Eza3Yv?= =?utf-8?B?bUZXd0FKeVdTNFNtNEdCTWF0MjNzd0JlQS9VWUNidWd6T0ZPOVVZK1FVK2xK?= =?utf-8?B?dmtWT093V053NGRUWCszL1NzVkVmZmYyMUE5SUhhSzBzMFA0L1hQNkhnS3Rp?= =?utf-8?B?b0xmRG1FM294NWFrVVFMSThIaEppRE5SVm84dlhaTHZMQXJYQmlCZDBFVHJI?= =?utf-8?B?QmxpQmRCRzVtQ1UrS2NFZldsZWhIYmcwSFllOERTZ2dzUk1pbkJsODJVZ1lF?= =?utf-8?B?eFJHZ3FPZERjQ1hmMjRFVDBSL0tXdTMvbVRVd2VTSjJ3VlFremRXcEtPRW4x?= =?utf-8?B?V0RFajNVNWgzMVc5cFVjTU9oMDNvVE5OTGQ3eDd3UmFoYmdZUG9xdjJCUHhz?= =?utf-8?B?MHBHdTRJZCtHcXJPVWlBd1VaWkR5SjM5OTFEd3VKNWpzenJCYy9Ra2RoTjYx?= =?utf-8?B?Q1doNmRSSDJjNDc1NEU5UDNFcUdsMlJiRnBUcDhSNGtjU0VleThoWG5ZKzNz?= =?utf-8?B?ZXJpK1UxVzZCUHJvSlFlbjRBODF3MzYwQjMyb2dsSjRSZ0xBaUNlWmh3OVg1?= =?utf-8?B?b29KdzFFTitJU1A0QW85RkNHdXVFbjVwS1pRRVlUaFdDdlRDamY2VCthR2hF?= =?utf-8?B?Y0hyRGxsQWJsRjgzRFcyUklUVTFZbmZiL2JFSFNIcDN4VklqRWJwMFNTSFor?= =?utf-8?B?MDZpTmdKQ0JCbHYrUXVOa0VlZHErQ2RwbUFiTzVQdEw5T1EzUnZqYU41VGV6?= =?utf-8?B?OVZGQlFqbW1LM1FaVG5lOXZYYlN5VWIyYy92QlRGSE82NDA3aHMrTnF5Y0k0?= =?utf-8?B?V0xJS3NiTHhnNWx4Y1U1U0xXNHNaejFNbnFDYm5sc3l4dStOeGZvUjRmc2pS?= =?utf-8?B?bDMra1hJY1pMMzdTOHYwcDIrYTJTb3pUTXNRL3MzSVVlY0pWeEJ2VGlDanJM?= =?utf-8?B?TzVGM28yaVlEMlpPU0pWY3o1WDNOUUgwUUUxZmU5T3ZheGFvWnRjR3NMWEVK?= =?utf-8?B?ampLU3J0RURyU1BkOC9aZ2pPZTU2ZW5heXpnZ2NwTlVFWTcrSnVNUWkrUnhZ?= =?utf-8?B?THRmTnVhaTQ1b1MyM3VMbXlHRnpGU1dEUGx6ZzJvVU1LZnZjRkJDSjNUTE9m?= =?utf-8?B?QmRRVWROK0x4amZrQkZUa1hPdDRRcW9hVTZyK0oxdlMyQnJsSVZWa1h1KzFp?= =?utf-8?B?Q2tERGNVc2xYa3p3eVhNckRkaDJwUE1hY0loS2pHa253ZjFhbzJNUGM3eThz?= =?utf-8?B?dUFVRmhSbDRVZlA3a0VOU1l0M01GUHU3NGRkT1hNektBL25IWTU3SzNVY2Zp?= =?utf-8?B?RGFsN0lYRS9lcEkzaTBHcm8wK2FESDN1MkNjazd0TXhaK1B0YWc4VGkyWVQy?= =?utf-8?Q?F5+0=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fe8333-d811-4b72-5d93-08dc1e74c21a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 13:43:20.3600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w8uvRE0kROWd/vCjokbMIE1bicw+NOl7PbgVVtSrjfSOtP6s4YXUOTC/82wJ3U8P X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6146 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/21/2024 7:19 PM, Harman Kalra wrote: > Adding support for parsing multiple representor devargs strings > passed to a PCI BDF. There may be scenario where port representors > for various PFs or VFs under PFs are required and all these are > representor ports shall be backed by single pci device. In such > case port representors can be created using devargs string: > ,representor=[pf[0-1],pf2vf[1,2-3],[4-5]] > This patch is to be able to parse multiple representor device argument, but I am concerned how it is used. When there are multiple representor ports backed up by same device, can't it cause syncronization issues, like if two representor interfaces used for conflicting configurations. Or if datapath will be supported, what if two representator used simultaneously. Meanwhile please check some comments below related to the parser code. <...> > @@ -459,9 +460,26 @@ eth_dev_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in) > break; > > case 3: /* Parsing list */ > - if (*letter == ']') > - state = 2; > - else if (*letter == '\0') > + if (*letter == ']') { > + /* For devargs having singles lists move to state 2 once letter > + * becomes ']' so each can be considered as different pair key > + * value. But in nested lists case e.g. multiple representors > + * case i.e. [pf[0-3],pfvf[3,4-6]], complete nested list should > + * be considered as one pair value, hence checking if end of outer > + * list ']' is reached else stay on state 3. > + */ > + if ((strcmp("representor", pair->key) == 0) && > + (*(letter + 1) != '\0' && *(letter + 2) != '\0' && > + *(letter + 3) != '\0') && > + ((*(letter + 2) == 'p' && *(letter + 3) == 'f') || > + (*(letter + 2) == 'v' && *(letter + 3) == 'f') || > + (*(letter + 2) == 's' && *(letter + 3) == 'f') || > + (*(letter + 2) == 'c' && isdigit(*(letter + 3))) || > + (*(letter + 2) == '[' && isdigit(*(letter + 3))))) > Above is hard to understand but there are some assumptions in the input, can we list supported syntax in the comment to make it more clear. For example following seems not support, can you please check if intentional: [vf0,vf1] // I am aware this can be put as vf[0,1] too [vf[0,1],3] [vf[0],vf[1]] I am not saying above should be supported, but syntax should be clear what is supported what is not. Also I can't check but is the redundant input verified, like: [vf[0-3],vf[3,4]]