From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B924A04B5; Thu, 29 Oct 2020 15:26:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFF05CDFE; Thu, 29 Oct 2020 15:26:53 +0100 (CET) Received: from qrelay113.mxroute.com (qrelay113.mxroute.com [172.82.139.113]) by dpdk.org (Postfix) with ESMTP id 2E72DCDEA for ; Thu, 29 Oct 2020 15:26:52 +0100 (CET) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay113.mxroute.com (ZoneMTA) with ESMTPA id 17574c107090004441.003 for ; Thu, 29 Oct 2020 14:26:48 +0000 X-Zone-Loop: bde59b30bef8856a5bb3a7f61ba32b0ed072b06ca0b0 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id E80486005E; Thu, 29 Oct 2020 14:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3bXzHd1hKM2bcXgXXK22ZnqEq8C9gjS6I8PVqj0+XM0=; b=ZcAhAC6seURPtFYarZ9B/Y0nim WgbNqhVClxXyGFQKOmVNZ4KfsPYL0kv2fbowJN8UMNMmpVuRA8/kLgId0OkB6d08TYE3PhXo5X1ew t+nzds1ITykRpGBN7RxQ0QJknWWAdKwOFI4gvUBnBj/qUfmPY7vfD42x2R2LyCp8s8OSH5/TzN7D9 SNCQwOH33sDni1QLcB0d+v04q6u2hkz/2jGPmnAxGYGCxP8dcSwdWofdxxO4rfeIrHc2VCBwjvTMQ ftNyrhlrBb3lCam2xoDqzVFaLtEzR9nXG8dKGkU99X7zGG4IxP338HRGYWWHxfnSCtJoL7VQhSk+J QYA3duOw==; To: Honnappa Nagarahalli , Bruce Richardson , "Akhil.goyal@nxp.com" Cc: "Ananyev, Konstantin" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Thu, 29 Oct 2020 14:26:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28/10/2020 15:22, Honnappa Nagarahalli wrote: > + Ray for ABI > > > >> >> On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: >>> >>> Hi Konstantin, >>> >>>>>> Hi Tech board members, >>>>>> >>>>>> I have a doubt about the ABI breakage in below addition of field. >>>>>> Could you please comment. >>>>>> >>>>>>> /** The data structure associated with each crypto device. */ >>>>>>> struct rte_cryptodev { >>>>>>> dequeue_pkt_burst_t dequeue_burst; @@ -867,6 +922,10 >> @@ >>>>>>> struct rte_cryptodev { >>>>>>> __extension__ >>>>>>> uint8_t attached : 1; >>>>>>> /**< Flag indicating the device is attached */ >>>>>>> + >>>>>>> + struct rte_cryptodev_enq_cb_rcu *enq_cbs; >>>>>>> + /**< User application callback for pre enqueue processing */ >>>>>>> + >>>>>>> } __rte_cache_aligned; >>>>>> >>>>>> Here rte_cryptodevs is defined in stable API list in map file >>>>>> which is a pointer To all rte_cryptodev and the above change is >>>>>> changing the size of the >>>> structure. >>>> >>>> While this patch adds new fields into rte_cryptodev structure, it >>>> doesn't change the size of it. >>>> struct rte_cryptodev is cache line aligned, so it's current size: >>>> 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. >>>> So for 64-bit we have 47B implicitly reserved, and for 32-bit we >>>> have 19B reserved. >>>> That's enough to add two pointers without changing size of this struct. >>>> >>> >>> The structure is cache aligned, and if the cache line size in 32Byte >>> and the compilation is done on 64bit machine, then we will be left >>> with 15Bytes which is not sufficient for 2 pointers. >>> Do we have such systems? Am I missing something? >>> >> >> I don't think we support any such systems, so unless someone can point out >> a specific case where we need to support 32-byte CLs, I'd tend towards >> ignoring this as a non-issue. > Agree. I have not come across 32B cache line. > >> >>> The reason I brought this into techboard is to have a consensus on >>> such change As rte_cryptodev is a very popular and stable structure. >>> Any changes to it may Have impacts which one person cannot judge all use >> cases. >>> >> >> Haven't been tracking this discussion much, but from what I read here, this >> doesn't look like an ABI break and should be ok. > If we are filling the holes in the cache line with new fields, it should not be an ABI break. Agreed, risk seems minimal ... it is an ABI Breakage window in anycase. >> >> Regards, >> /Bruce