From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wangxiaoyun (Cloud,
Network Chip Application Development Dept)"
<cloud.wangxiaoyun@huawei.com>
Cc: dev@dpdk.org, xuanziyang2@huawei.com, shahar.belkar@huawei.com,
luoxianjun@huawei.com, tanya.brokhman@huawei.com,
zhouguoyang@huawei.com, wulike1@huawei.com
Subject: Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd
Date: Tue, 8 Oct 2019 16:33:04 +0100 [thread overview]
Message-ID: <b626065a-7d5c-0619-2790-2083bac022ab@intel.com> (raw)
In-Reply-To: <3f098f19-4029-21ae-b685-ece6af9e237a@huawei.com>
On 10/8/2019 4:14 PM, Wangxiaoyun (Cloud, Network Chip Application Development
Dept) wrote:
> Hi Ferruh,
> Thanks for your comments. hinic pmd driver doesn't support 32-bit build, we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc".
> and “defconfig_x86_x32-native-linux-gcc”. I don't know why it also build in 32-bit platform, can you tell me where also need me to add configuration.
> Also I build it on 64-bit platform,That's OK.
Hi Xiaoyun,
You are right, driver doesn't support 32bit, I am force enabling it, just for build.
Since the build error is only in the logging format identifiers, I think it make
sense to fix it, and it is better to use more proper format identifiers.
>
> Best regards
> Xiaoyun Wang
>
> 在 2019/9/30 23:06, Ferruh Yigit 写道:
>> On 9/30/2019 3:00 PM, Xiaoyun wang wrote:
>>> This patch set adds advanced features for Huawei hinic pmd,
>>> such as VLAN filter and VLAN offload, SR-IOV, FW version get,
>>> set link down and up, Flow director for LACP, VRRP, BGP and so on.
>>>
>>> --
>>> v2:
>>> - Fix RSS bugs for vxlan packets inner type
>>> - Add comments for new added func interface
>>> - Fix code review comments from patch v1
>>> - Fix code style problems
>>> - Remove ceq interfaces and definitions that not used
>>> - Fix aeq init bugs, firstly alloc aeq resource, then set aeq ctrl len
>>> - Fix bar map bugs for VF Page size larger than PF
>>> - Modify link state set, add enable or disable fiber in tx direction
>>> - Fix mbox and mgmt channel sync lock mechanism to reduce CPU usage
>>> - Fix FDIR bugs for VRRP packets
>>> - Fit ABI changes from dpdk lib
>>>
>>> v3:
>>> - Split hinic.ini and hinic.rst to related feature patches
>>> - Add min_mtu & max_mtu initialization for hinic_dev_infos_get
>>> - Fix fdir config patch with net/hinic/base
>>> - Split link patch into link and fw version getting 2 patches
>>> - Update pmd doc files to new next version
>>> - Add comments for cover letter patch
>>> - Add rxq & txq info getting interfaces
>>> - Fix load intrinsics for receiving packets
>>>
>>> Xiaoyun wang (19):
>>> net/hinic/base: add mbox command channel for SRIOV
>>> net/hinic/base: add HW interfaces for SR-IOV
>>> net/hinic: add VF PMD operation interfaces
>>> net/hinic: add VLAN filter and offload
>>> net/hinic: add allmulticast mode and MTU set
>>> net/hinic: add unicast and multicast MAC set
>>> net/hinic/base: add fdir config interface
>>> net/hinic: add fdir validate flow operations
>>> net/hinic: create and destroy ntuple filter
>>> net/hinic: create and destroy fdir filter
>>> net/hinic: flush fdir filter
>>> net/hinic: set link down and up
>>> net/hinic: get firmware version
>>> net/hinic: support inner L3 checksum offload
>>> net/hinic: support LRO offload
>>> net/hinic: add hinic PMD doc files
>>> net/hinic/base: optimize aeq interfaces
>>> net/hinic: optimize RX performance
>>> net/hinic: add support for getting rxq or txq info
>> There is following 32-bit build error because of the log formatting [1], can you
>> please check it?
>>
>>
>> [1]
>> .../drivers/net/hinic/base/hinic_pmd_mbox.c(659):
>> error #181: argument of type "unsigned long long" is incompatible with format
>> "%lx", expecting argument of type "unsigned long"
>> PMD_DRV_LOG(ERR, "Fail to send mbox seg, seq_id: 0x%lx,
>> err: %d",
>>
>> .
next prev parent reply other threads:[~2019-10-08 15:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:00 Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 01/19] net/hinic/base: add mbox command channel for SRIOV Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 02/19] net/hinic/base: add HW interfaces for SR-IOV Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 03/19] net/hinic: add VF PMD operation interfaces Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 04/19] net/hinic: add VLAN filter and offload Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 05/19] net/hinic: add allmulticast mode and MTU set Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 06/19] net/hinic: add unicast and multicast MAC set Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 07/19] net/hinic/base: add fdir config interface Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 08/19] net/hinic: add fdir validate flow operations Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 09/19] net/hinic: create and destroy ntuple filter Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 10/19] net/hinic: create and destroy fdir filter Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 11/19] net/hinic: flush " Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 12/19] net/hinic: set link down and up Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 13/19] net/hinic: get firmware version Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 14/19] net/hinic: support inner L3 checksum offload Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 15/19] net/hinic: support LRO offload Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 16/19] net/hinic: add hinic PMD doc files Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 17/19] net/hinic/base: optimize aeq interfaces Xiaoyun wang
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 18/19] net/hinic: optimize RX performance Xiaoyun wang
2019-09-30 15:10 ` Ferruh Yigit
2019-10-08 15:19 ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-30 14:00 ` [dpdk-dev] [PATCH v3 19/19] net/hinic: add support for getting rxq or txq info Xiaoyun wang
2019-09-30 15:06 ` [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd Ferruh Yigit
2019-10-08 15:14 ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-10-08 15:33 ` Ferruh Yigit [this message]
2019-10-11 2:50 ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b626065a-7d5c-0619-2790-2083bac022ab@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=luoxianjun@huawei.com \
--cc=shahar.belkar@huawei.com \
--cc=tanya.brokhman@huawei.com \
--cc=wulike1@huawei.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).