From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by dpdk.org (Postfix) with ESMTP id 07A851B292 for ; Mon, 5 Feb 2018 06:24:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7qnabq+zWQjq8e32DriAVCQv+YE5WskT5nsJBNzg/xQ=; b=feqCkiBx8d0BDZU98ExpGg2790uPj4JlZ1i845tXiv3lLq9uBZNp0/A8wVdCbDyhxch0LqIbS0FnIswakB+99d8DTkTEyeP865AmjlRtUGvMtHzdE2rs96noC5+uC6VUnNqy5Ch8k70MRacnLuhdYKbRuw5lch9tZUJ4nSuxdAI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (192.88.169.1) by AM5PR0401MB2451.eurprd04.prod.outlook.com (2603:10a6:203:35::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 05:24:41 +0000 To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net, matan@mellanox.com, konstantin.ananyev@intel.com, hemant.agrawal@nxp.com References: <20180201124439.21633-1-shreyansh.jain@nxp.com> <20180201124823.22621-1-shreyansh.jain@nxp.com> <20180201132724.GB13884@bricha3-MOBL3.ger.corp.intel.com> <78379784-5872-b051-bede-27ee4a8c0845@nxp.com> <20180201141933.GA14048@bricha3-MOBL3.ger.corp.intel.com> From: Shreyansh Jain Message-ID: Date: Mon, 5 Feb 2018 11:09:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180201141933.GA14048@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: BM1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::20) To AM5PR0401MB2451.eurprd04.prod.outlook.com (2603:10a6:203:35::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 60c00264-1646-4c44-f253-08d56c58c37e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM5PR0401MB2451; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2451; 3:dSDYenBNfh2mSVIQkMeXaldDdYMhNvm7+SkqCqfGi+jwrgmlikxh1WJ3TcYP/WwhKoFTwCMU2kuSF2o4bvxeDs1dBPinf89MSGoworkpjOabfLg4xYqO9EnBqeDvjpV9C934yeMy02cBBH9Ra/3BE06VoValOYwDqQoBLzyNUzSz8j7Ra0URNYCSADvo2aj3eHFwMUtranQccYSJrM95GUuJpNfZteLqYMfQfmnz9h/DoXNNhlhqNQFKuCjABJ1V; 25:IXMJwl9MmXYZcPFajHp/zmROUAH+VKManfqRSLS+JkB1/Uf0p2Tf5Q+wVdUJFE24x1Hu+mqI/NOXe+DdeM3YbpQmj0aPlAjOYx4Lq0T9Dnyo4vzal9EnKWn7Mug0v3jOuPUNyARW+fodUGSP9DEsFfeB4mVCLAOqIlhGzEsi0xkhpybX3MGiYjyPa16Ub0A1S2i8AKT2Lwm/tr/F4E/A+N/2oE29WHUJKbnrRlz5qNtlpqOSSC27OZxFulzYU0/Khuymt96hW/ZmaZY3O9wFACkqMEgImeYLUWHtQMFqiv8E1GENFGvtKZ2LFzUWKPrlwvnnNX3UiPozLdn002mYMA==; 31:0B5+YgzOcpf4O5VWXMSsCaqVrqLZDvJ/cKIbCBzB69HSIV8MdES8BbiXE6VBKmyFAuH6JpTrhD/F2FxZSITJgxdys5EVlHaB2A4W8383f9HVvXxtKSn9PkC6obhHDlECky1Ek77/bmvkYLaUoXkCPZl5SYqMxztDvQIiZAoXDjx1ZWC2GxtcZma2rBPfFw1igMSK6dk25mGciq+mObTEzehJMLOSzgQxi0lTFWo9yEU= X-MS-TrafficTypeDiagnostic: AM5PR0401MB2451: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2451; 20:62T8ZNjA155hPdbyhbEpDN1pOHzUa4OSJq13ycXG32fkeJJ7LetmLHZ9NBqBHrcleOGpKXX4goXWmjXzhCYD6Jvss79mlWvkWJJQJHXLUI6yqrUqcrfBQaqYb1AaYamMvhHhASwx+7QVC6sJehR3xJBXEeh4ZG7hhklZEPusdtqi9IZR1dhjeWrmUPC9MdjTPqwVde/T0V7wuHjG+ICce/b4pJc270qRldvHbqwgG2towmP/pnz8zFmHXC040okDXpVhO+ZGQegN0SCZSpW9LaMKhQbtjD9R1iy7IxR5ux/2CXRVpcbnswPbW+EdDsW+3y9umSDWwLq44kTgrXIx/OJIooCvH+p0xJJXkfl8mGFet7yBle69JJSUTSnC7tFrp5T22r3kYlNr7eJq7AWA27jziRv4r04SHEv9Vs74QQNS/+Fk/AlnL7MS9D3ZaweOUO7riHJVQkpqmQarY0duo+PrnWaZJprXBTAU9oC4+DMnuiv7Qm2e06mZhDE9XagU; 4:2Sw+Ok8MnduGjwuJZdPDLabR0740ZPtjaX8gI6qOHr3ByoqRhqqtcYPS2roYkt3NapvfEctuoFbejpJH05/AQtB5DVhzoN2BUVtpVxYQheH/Kvjnfzs1cbXeGNdlT605U8/pKaYOHH1CrKoOS/vZQRBs7BisFs8gsHnjMt4fLJEOgbJdz9IkkIGLneMZ63QgVZBHpnYjZ4pnNlXztSP+NGuOdWWBI49rUCQI9uZPSYG7gvukpFqLnDk7HcjwbAeO4txAygbYwfEh1eByl0Y2VI9wevaKTf7UlXDAry24Z5PLBNIE+YYRv41Myg0FtU/S X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM5PR0401MB2451; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0401MB2451; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39380400002)(376002)(346002)(396003)(39860400002)(366004)(189003)(199004)(36756003)(6916009)(53936002)(66066001)(65806001)(6246003)(67846002)(5660300001)(52146003)(6486002)(2906002)(25786009)(83506002)(31686004)(23676004)(81166006)(81156014)(26005)(2486003)(52116002)(6306002)(8676002)(47776003)(76176011)(97736004)(77096007)(16526019)(65956001)(7736002)(305945005)(106356001)(105586002)(64126003)(386003)(58126008)(316002)(16576012)(59450400001)(53376002)(4326008)(31696002)(230700001)(6116002)(8936002)(68736007)(3846002)(50466002)(65826007)(86362001)(2950100002)(966005)(229853002)(6666003)(93886005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0401MB2451; H:[10.232.14.39]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA0MDFNQjI0NTE7MjM6Q2NMTXg3WHVBSFFleFZxUDd3QlBsRWtI?= =?utf-8?B?Y0QyRkZTakVIc0dCM3ZLOW1PWUhnMENTdEs4QUhheXpnMzFPbVdCd1kzeG1x?= =?utf-8?B?QWRxT2ordTdLcmNaUlFOZHY3YVB1TnJUdWxyWVR2N2F6R2hWa3E3Zkw2RmNP?= =?utf-8?B?WFJHNTRlT01SME0wUGluVW9ZMzk4YXBHNkd3SFJnVUIyeExjNzJRaHkySStx?= =?utf-8?B?dXRzMkNjUDNpRTMxTk5xOVZ3dFVKODlTRVdWKy9CWG85TjBLNGtkWmRUS2lV?= =?utf-8?B?eHYvL2NKSzNNK1RXVTFyeFpQV3hYUGpVMWJSN2UyOUVibm1zMHVpMmNJSVg1?= =?utf-8?B?diswenJaczJ0QmJiSHEyd1o5WHNBNi9jeGdlRUtpQytIOGZNNEFkWGF0enhO?= =?utf-8?B?Q2xybzJzNWtCVm9EaTBQWnRNNU5NTitTYUt5Y1ErYkx5V2QzcnYxZUhTV21X?= =?utf-8?B?NE1FL3RUY3JsWnVoZWlQc0ZIcUxZMWIvR3hrdVFYbDJCRmpQakd2eTFwbU45?= =?utf-8?B?VGVINnZRdGZ4R3FLaEZuS0JzTkE1eW0vdndzM2RwekZESUdFamlHWENzVFRr?= =?utf-8?B?dnFLWnNONm1tMDJQOWx4eVFDVEtlbXBDVENoc2JXRkFZREtrRXN5eTk4Y0lE?= =?utf-8?B?UUpFOFZTeW1INmgyZUI5a0hGRTFySXdmZUwwdjRqa0pjQ3BkS29uM05YNUY1?= =?utf-8?B?R2tYSDlXTm10YXkzelB2cHFaclF3cUNrWk5mSW53U3NDcFlCTDMxbnRJYkNx?= =?utf-8?B?bGU4NVdKZlBERW5SQWloWWNCNlJGOTlqTGJoU3ZIOURIQTJKL1VwVXBtRzdh?= =?utf-8?B?Nk5QTEJTdm5HQkJXUnd1UmI1OHBzQ1Y1c3BNci9ndjZVS3Y5N0xZZVVKdCtr?= =?utf-8?B?RWRYS1FoYzhHcHdvbVp2Kzc0VHppV3BySUVMUW1paWhiZjN0VkhpeHJobjNp?= =?utf-8?B?blJIbldzbDFnR3pCU3BrZ2pFUFlsUXl1ODdGUjNOSnhidW42cStqRWFTMnJM?= =?utf-8?B?WDlZYk0xaENONFRzNHVxektKaHdFa2Z4c2pqdEF0NkhNc3VNM2lMNnZqTjlx?= =?utf-8?B?aGtDU1QwU3RFMFFqaks4RmY3Tmk4QW9Wdkx3bEwwRGFiUG5WM1lOcXBPb1dY?= =?utf-8?B?RGJROS9qTzhyVWZCZTB3cm0yOXFOdk81OHJVeTNTNXRYaDRLdUZXVjY4RWVQ?= =?utf-8?B?TWI0TkNqQU15UWVwSGlYcUVIdTRZaWtEK2Q4TWFRdGZvT3c4WlRBZEZyQ3RZ?= =?utf-8?B?Ylg0SDh4QWF3UTgxVFBITjVHbFpOc3VNMyszWGpDeUVGQjdXVU1qa0lhRWVG?= =?utf-8?B?WU1Jc2lNaEVOMW9MeXB1cmovWnBUdkNDbjVhZkJyTDNPOWozcjJFdDRpcXg1?= =?utf-8?B?NEFqczVXNzhMenJCVWkxaEN1VWRDRnJ4SDZMczk0WTc2MmZka2trQ0kxNGtw?= =?utf-8?B?cG14ZlZoZENRK2dxbkJhTmN3dGRKdEpDYzd2YnJQalVLQlRTcXluS1gyMUhX?= =?utf-8?B?VlB1Qm9NSG1ZcURqNjVFNkEwRm0rdkxhb280TzVweVdSNGVKb1o0WTh4eWxs?= =?utf-8?B?RUJoWGUvMm9mMHZ6V1UzaFZBMWtCVkJxMEN5c0RmM3RnbFdrQ1RzZE5yT0Zh?= =?utf-8?B?aVV4aU5PT25lUFVtcG1QVFJwVHNDSHhEUHZuZmdWSzArdXkxTjJjWkdFNC9O?= =?utf-8?B?R0p4dWV5QStCa1NZRG1JbXpIaUxKcDJEZGlnR0kyVEdVTkE0QUloeEJCRGlM?= =?utf-8?B?TTVXMjR5eks0QUgxNUx4K05aV3M4WTB4aHJmSHZsQythbEgyUG1PKzlmY2xC?= =?utf-8?B?WnBZQ1dmV3ZuSXl6YjBoY3FxV2FaR1dnYVF3cTAzZldpakp4QmZNTk5QMFZl?= =?utf-8?B?TFo4MXpjRGFMQ2Nha3BEOGtsakVvY1dRWVhnS3J3VmVZZHJJbkxVSkJaV0ha?= =?utf-8?Q?hh9eWD7quKS2JoVxyM1/t/xURan3rl+A=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2451; 6:C1vKv7c8zsSIxPMiuLXlVKKogvyVQAWTyp3ypoUmg/qIVyiE1k/h7IUrBW5kIUBSeSSpc6+ojW+aLWU0UpGfmnGWWXu0AH+OAyi8zPAqriOeyrkLEbrRn5FyabRzFpaYqiaR7/nQKCGlRc09bAJt4j48uJOJrK3iLdbvC6Wefi5bAON9rVarbcJKwFR/9I5QxbtHvT3lJmxWDarGs4lsjWELDcF3dc4DchB9dlIlUpWwhtYgdyeFRCnBFJejBUwC/pw4TbVtk8gkOf0USDcfde7f7IX9ILziRyeOSmUGoQttsf3mHQivVmwH8I95nEbHnlqvZH5uoty6ueqVFep+0KKDASoIgQTOc9aWuJO5d4M=; 5:PPCg45XhHS2WjPq1hZDKvlbtOWdovAaDQcw/S3x27VFfHNx7wGAe/bNAMEFGvPoEq+tvsLNCtDr3B8eM3rfCMNt+Bw5gPq957RQpfL+TSB5scWyXPtTbAWuM0sV3/L73Ku4MX3MI8f3ra7QzC5C4rle+tmYfYu30rFWKnrNz18M=; 24:J+0ZUskv80nBY0KiWY8tBq+Mw3cK2Fh38vHLj9kOBouasKewQJDmPgb/9MSQjil9uHu1Lxp5tV/GqMg6ECEetdDS2B1mmpkVJHFLBraEG4E=; 7:yPew1VwDL7iOu0IP8uCjeLzOIoQ2mJOAzn/xtgstiLZnJyx7L/NAzu1hBoFxWJ7TexZt2DUwp9DuBHO+CRTgt7xLfmMUhQdZMKFEXX2anhUu8d7fHBxn563rTNQ9N4HyYGP/Almnvv5qZAA/n+eGFvv3rBZQir1oTr00VHbDZcj4L3SfAyZDKRWSYyatuPKB+IryfPXfBoP7Y431TL8Wj0MBwsDEKR5kQnna9vy/c4vYiJsBvR2Bi14Fd11B4EfZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 05:24:41.3560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60c00264-1646-4c44-f253-08d56c58c37e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2451 Subject: Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 05:24:45 -0000 Hi Bruce, On Thursday 01 February 2018 07:49 PM, Bruce Richardson wrote: > On Thu, Feb 01, 2018 at 07:58:32PM +0530, Shreyansh Jain wrote: >> On Thursday 01 February 2018 06:57 PM, Bruce Richardson wrote: >>> On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: >>>> rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value >>>> is smaller than requested, application can consider it end of packet >>>> stream. Some hardware can only support smaller burst sizes which need >>>> to be advertised. Similar is the case for Tx burst. >>>> >>>> This patch adds deprecation notice for rte_eth_dev_info structure as >>>> two new members, for preferred Rx and Tx burst size would be added - >>>> impacting the size of the structure. >>>> >>>> Signed-off-by: Shreyansh Jain >>>> --- [...] >>> >>> LTGM as far as it goes, but following discussion on this patch, >>> http://dpdk.org/ml/archives/dev/2018-January/089585.html >>> I think we might also want to add in parameters for "pref_tx_ring_sz" >>> and "pref_rx_ring_sz" too. While it is the case that, once the structure >>> is changed, we can make multiple additional changes, I think it might be >>> worth mentioning as many as we can for completeness. >>> >>> Another point to consider, is whether we might want to add in a >>> sub-structure for "preferred_settings" to hold all these, rather than >>> just adding them as new fields. It might help with making names more >>> readable (though also longer). >>> >>> struct { >>> uint16_t rx_burst; >>> uint16_t tx_burst; >>> uint16_t rx_ring_sz; >>> uint16_t tx_ring_sz; >>> } preferred_settings; >> >> This, and the point above that we can make multiple additional changes, is >> definitely a good idea. Though, 'preferred_setting' is long and has chances >> of spell mistakes in first go - what about just 'pref' or, 'pref_size' if >> only 4 mentioned above are part of this. >> >> For now I saw need for burst size because I hit that case. Ring size looks >> logical to me. We can have a look if more such toggles are required. >> > > I actually don't like the abbreviation "pref", as it looks too much like > "perf" short for performance. As this is an initialization setting, I > also don't think having a longer name is that big of deal. How about > calling them "suggested" or "recommended" settings - both of which have > less fiddly spellings. > > /Bruce > I get your point and on a second thought even I think 'preferred_*' is better than other options (including mine). Only change I will do is change to 'preferred_size' as all members are size only: struct { uint16_t rx_burst; /*< Rx Burst size */ uint16_t tx_burst; /*< Tx Burst size */ uint16_t rx_ring; /*< Rx ring size */ uint16_t tx_ring; /*< Tx ring size */ } preferred_size; I will use your ACK but if you have objections to focusing on size only in this structure - let me know. I will send across another patch and put it as 'preferred_settings' and then we can discuss the naming during implementation. - Shreyansh