From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50E5D43B08; Mon, 11 Mar 2024 23:32:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20219402E6; Mon, 11 Mar 2024 23:32:04 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55]) by mails.dpdk.org (Postfix) with ESMTP id 821CB40276 for ; Mon, 11 Mar 2024 23:32:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AfutLoY3crbFAsHkE9Z+FpzcuMO6sp3MIIzXzvu3PRWUNBlI9WyQxYbFSbaBpwGl47Py4m5tPh3bKKW7P1m0pUOa5SSs8LA+fRqCPhGyGJhkIUfJAS9NqeAkCwusGH1JAUGu0Fl3AlTw3PnVyeH9r/Rtx3xrDjdXrLz8YaPNTufxygyP9PDEf7Cb8s1QDJ5hqfeLdLNMKb3mVk9OudZoGtlwpcynw6d0H2RrdOvxhlmIM5DK7g0dLOnATdOiAlWItXX0HPVZQxCAb0B5lWYk4RlZarV1pnn/LvCxeQ1e7tMk8kTi3mj5wZZROmxld9ANnqJ4yWyqJD2opYoBxyNuZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/rcVuyeOigl0ZeQ7ViPb/7d6B92Zh8QU6X/H8bxW64=; b=nGMqsIf7B74fWy2zu1+/7HA06S0SWvdaXTQyaVBfGXMzKVGuxXgskildVipaPMKEHYWV5Ohq0u9RiZFe7JOrRdMj135fiUgInYadMtuMJiKH5YHpjfHqGl+qRlIj7KBu4OnJPazrFMrsQ3V99y/CP0/72gU4EE8Hswa574b2heCEMnUNbUqffTNMO2L8qfdcye9m05iLlu+5lqcw73AOgiSpRU95E0toyFpXlqZO7gpHOswTLebZFbgdkb5ck3/oo7Tm+8eI/rY4D4CwM9ULWhDD7r6M+GFWZ+M5HFQUERid6Sngw8nYROKFDzVuiqMipcXTxByDMh2DR+PiH8wWAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/rcVuyeOigl0ZeQ7ViPb/7d6B92Zh8QU6X/H8bxW64=; b=XNuPn441DmrUZP0kzTj1CAqhJqs8HAQFvB2HJcd1f/Kn7MUuP/6AT39i+oRyaEROoR8diWf/8ZY1cJI64D8IDjH18Au0mu7FyoACp/l4jcJQFx209bMMzIxSeeOKR+9AJiiFwpkgCuG2oy34QXE6sX/VnTzg5FGj+4ddwAgywp8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by BL3PR12MB6473.namprd12.prod.outlook.com (2603:10b6:208:3b9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 22:32:00 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d%7]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 22:32:00 +0000 Message-ID: Date: Mon, 11 Mar 2024 22:31:55 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/netvsc: fix number Tx queues > Rx queues Content-Language: en-US To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0370.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|BL3PR12MB6473:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c8cbc15-a291-49d7-3854-08dc421b1124 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dpr9SAbci+QFEjN2BXhY+OR78tb2T8C9xxDhg9vZrFt7hpleBBsGJaLryBaHRY+4uvw++mhvEbUJ8FmXDaBjTdRjbk6m9TeKLWegCj1NdMImWxjIoGHw+/uyGTMrY1QBwu5vHCQF1lzImGW6CA9isNLCgMrFKgaqORNm/LK898C0S6fwiE0ZbYi02dU+sj1NUcWGBsWvetMApQCbaBYxkq2GRaw8cRHiRXa/c+sFgbhuRkkXfSfo0dktU5qOyeb3vQ6c14SfoHCvczr2ftplw8W+/QoUDigVkixHWLkIAWIpyf6v+p86aNb1Mb8jzbRkvV4Nsdvh4f94fyV50JOZZ3/6iLxJZoxBqermoeILM5cYYnMugRCQ8MT8zX2VowatoLDE9avqQNOwCRs9zGxcTp0p1pUxg1EcKKLicAojdYPv7dssaNaY1KfF5rQCn3iHL+h5Sg6f/5HW0xkaiLtwJVdDkULu2o4qLMI1ZkOzk5TUBfIyzvT7t8IPjj42D9rfgGS/8i0ezO5nmdek2xQI68VHNus0EokOf9a2xZdf3qywH5oiDH+jhw4Zr8rL6pIOyJ8OwA3jRxyIZoBPtxRf8CuHX5as2KLNSdAHMO1HMQowtVj9PnGOQM7Is35p+w5VRsF3warrPrexmygJ4UcGp/YuI2uqVzhHRcPQbd+p6bw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXVkTVRGam1wdVBnL05RYXdFOXkyUHpobU1aT2IzVys3TEJxVnFtSmlpanlS?= =?utf-8?B?eExWNDBhMjVkaFZ5NDZHNjc4M2ljdXVlblFHbEwxRDZ5cGVxcHpielUrUTh4?= =?utf-8?B?QmVYQ1VOTG5GU0lwRC9obll0N254d0x4MzcwTllRRUFIQnNBM3J4eDdkUm1L?= =?utf-8?B?dXZzTEdWZTZkVVQzVndBdk1vQTU2YlBuNnMzRjIvaVhiOGxaVW9FWllBOHVK?= =?utf-8?B?b1JCRUFFSHpJVkkwVFJCUkI5ZUNTeFJtZi9LQ284bVZvSTZzVXE2YVRrMmU1?= =?utf-8?B?U3p1WGNYNUNJOGgybHllb1VKV0dFbXZYZHRJNnBaNlhpZ2ZvNzlaRnhkeFpK?= =?utf-8?B?TUVHQXpEUVVxSVFVK2Z2SitYSi9rNjByVGVVVTRqVjdjOWliTjkrc1J6Nzdl?= =?utf-8?B?N1AvTUtUWGF1RHRqMnJFT25FSGU3UTh1d3FJZmlBa3dXTGZ6RnhEZm1TM0du?= =?utf-8?B?S1NYVThBOEhpRGlzUHN1TUhGblIyckd1eUYrVFNGQjhrK2JOUXBTdEs5ZmND?= =?utf-8?B?eXgwZ1M3YVY2N3JJV21aNGNWQjNPZUNZSm1PZ2ZUazRiQ3NHQ21vaFBqVTds?= =?utf-8?B?Y0xzanQ3S0wzYjM1cEVJUjFrMDJpN3pXN0UwdmhmeU1CVUc3THlsMU9qY1Z3?= =?utf-8?B?MXZuR2FwNG8xYWhhNjlMS1VLeXl6azhxUXNiRTRZVDB5RUVuL21RNGI3bWtz?= =?utf-8?B?VGUzVUFDNGdiamgzdk1RblpUQnRlbUlHSmJaNkdKYVBSTm83ajBteUxqMHhP?= =?utf-8?B?NThua0NQR0dkYmpEUjhsaFpDNEpqbktOOVYySXhGRDhXSzhKYVpLUG90NEpV?= =?utf-8?B?aDZsWkkzbVVRNTk5K0Y5eGcwQnlSTnVIZklsTS9YVGc3Vi9hNFFMRXBlVUlM?= =?utf-8?B?RXY0S1p5MGxCQVN6WnRXdSsrSTRieXRjVC9KYmJoUzZ4TzAzamxaTmIwTVNi?= =?utf-8?B?anl5dGlWbWtST2dPQ0V6ZzcwRGJyUWlPV1FzbndhalZIRWdUQmQwNUc2aTJX?= =?utf-8?B?SlhJTVB2TU5SZ0I1dGpGQ2hoeXVpbENZdmdMUWtBS1JXNFFtdWpKYzd2bndE?= =?utf-8?B?VytXQ1dleU93M2xpblkxM3FKSUtvNUI0bjVISjB3a1JpTVVkK1JUM3lxcTFM?= =?utf-8?B?VTBVdTJ5U1l3cjdOWCtwZWNOQjZFUFhyWjkvMWVsQkZuKzRqTXB3RGtUdzlo?= =?utf-8?B?ejRKbXlXVFpJZmdLT3dHY21GT2x1R3h0allWRlZaaHR6blRkUVlmWVlFRHNH?= =?utf-8?B?MTBqNGxtdG5Vc0VHY2tuM3gxYlNnMWZqZFRPYnJXZmJXaGRmb2cyVkNkUjNJ?= =?utf-8?B?YXA0MUpLb0ZOYUgxblR0M1R5dU9LNm5PcTVUbmgwOXoxZ3FkMVdHVUpKbzRB?= =?utf-8?B?ZW16Z3ZFODRKeHhCUk9yTDMzWmdIV0svaUw0N1VyTnZzYzNPSVpoOGUzM1do?= =?utf-8?B?Zzd3ZUNOR3RuNUgxaTJiVTRFU3Jlc21KUkphWmViL0F2blFwTHM3em5INTJQ?= =?utf-8?B?SnU5ekdVRVBIMmxTTTA2STY4Y0ZpZkJBalgzd29oZTF4VzRuSjl1ZG5pVGRq?= =?utf-8?B?Q1dBUU5GSmduaFU0dTRVaFFsV3ZFUlk2ZVJNcldxSHZHYUZwV3F5Q0Rkc0JT?= =?utf-8?B?MWtCYThKZWExM1JSWVgvVk5lMU92R0lDNWZWVXZ2VVR5KysyV3o4cDBsK0Vr?= =?utf-8?B?VXl6U0FmNktONmFxM1UzS1BkcXhiYzVrRllPK2FZcmRYK05DU3RLcTJTOTJu?= =?utf-8?B?V2l6RVRHbmFpaGdMTGwxbTcxVzZwbUl1YUpFQlpHZUgrVllodFNFVVRQUWNz?= =?utf-8?B?RURDQ1FTRU1nSkZMVkwxL3gxT3pUa3ZFQ3NCRVlaZTFOY1h6TDNXTG9qTzlv?= =?utf-8?B?RWxsMmIrOFh2YWRwN2h2U0t6bFlSYWlxdTAzSjI4WWNKcnhkTGZnYkhqNFVZ?= =?utf-8?B?SDcyMFU5bHBDTE9tcWZPdkV4b0RyVTFrUkF4OWZWL3ZZdFdBMTRBcjE0WWd2?= =?utf-8?B?M0x2QXc2bFNrdFRBK3FaRXhybGJYVHBpN3JGRm8wdjRsa0dkTVgzTjhHMFpz?= =?utf-8?B?L1Z3aWNtd0lRUTllN2ZQMW9YN1hnT3dGcTRIdWZTdDg1ZCt1d3dTaEtBQnVU?= =?utf-8?Q?WK6FWyTAyWNAUMibvWC522QQW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c8cbc15-a291-49d7-3854-08dc421b1124 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 22:32:00.6840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YVQ8H3B5+/fItGQioKfejzNoOpZwrQQAXgowF3AbC6Md5KL2JKZd2UrSZAsSgEZE X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6473 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/8/2024 6:09 PM, Alan Elder wrote: > The previous code allowed the number of Tx queues to be set higher than > the number of Rx queues. If a packet was sent on a Tx queue with index >> = number Rx queues there was a segfault. > > This commit fixes the issue by creating an Rx queue for every Tx queue > meaning that an event buffer is allocated to handle receiving Tx > completion messages. > > mbuf pool and Rx ring are not allocated for these additional Rx queues > and RSS configuration ensures that no packets are received on them. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder > --- > v2: > * Remove function declaration for static non-member function > Hi Long, There was a request to hold prev version, what is the latest status? If you agree with this patch, can you please ack/review ?