From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CB3AA1BA3B for ; Wed, 4 Apr 2018 10:06:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 01:01:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,405,1517904000"; d="scan'208";a="44759697" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.51.73]) ([10.252.51.73]) by orsmga001.jf.intel.com with ESMTP; 04 Apr 2018 01:01:24 -0700 To: Stephen Hemminger Cc: dev@dpdk.org, keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com, gowrishankar.m@linux.vnet.ibm.com References: <20180403164128.0946b6c8@xeon-e3> From: "Burakov, Anatoly" Message-ID: Date: Wed, 4 Apr 2018 09:01:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180403164128.0946b6c8@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 11/68] eal: enable reserving physically contiguous memzones X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 08:06:35 -0000 On 04-Apr-18 12:41 AM, Stephen Hemminger wrote: > On Wed, 4 Apr 2018 00:21:23 +0100 > Anatoly Burakov wrote: > >> This adds a new set of _contig API's to rte_memzone. For now, >> hugepage memory is always contiguous, but we need to prepare the >> drivers for the switch. >> >> Signed-off-by: Anatoly Burakov > > Why not make fragmentation an optional flag to the memzone_reserved > rather than a new API. That way less drivers need to be changed. > > #define RTE_MEMZONE_SPARSE 0x00100000 /* Allow zone to be non-contiguous */ > That is a good idea, however, i would perhaps do it the other way around. Most of the time we are reserving memzones, we do not need those to be IOVA-contiguous (i.e. creating rings, hashtables etc.). So it would rather be a RTE_MEMZONE_CONTIG (or some such) flag. -- Thanks, Anatoly