DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, pmatilai@redhat.com, david.marchand@6wind.com,
	jia.guo@intel.com, matan@mellanox.com,
	konstantin.ananyev@intel.com, stephen@networkplumber.org,
	fbl@redhat.com
Subject: Re: [dpdk-dev] kernel binding of devices + hotplug
Date: Fri, 13 Apr 2018 18:40:46 +0100	[thread overview]
Message-ID: <b670f7b1-c894-ec92-86d0-fdd2fb789e67@intel.com> (raw)
In-Reply-To: <20180413164046.GD37024@bricha3-MOBL.ger.corp.intel.com>

On 13-Apr-18 5:40 PM, Bruce Richardson wrote:
> On Fri, Apr 13, 2018 at 06:31:21PM +0200, Thomas Monjalon wrote:
>> It's time to think (again) how we bind devices with kernel modules.
>> We need to decide how we want to manage hotplugged devices with DPDK.
>>
>> A bit of history first.
>> There was some code in DPDK for bind/unbind, but it has been removed
>> in DPDK 1.7 - http://dpdk.org/commit/5d8751b83
>> Copy of the commit message (in 2014):
>> "
>> 	The bind/unbind operations should not be handled by the eal.
>> 	These operations should be either done outside of dpdk or
>> 	inside the PMDs themselves as these are their problems.
>> "
>>
>> The question raised at this time (4 years ago) is still under discussion.
>> Should we manage binding inside or outside DPDK?
>> Should it be controlled in the application or in the OS base?
>>
>> As you know, we use dpdk-devbind.py.
>> This tool lacks two major features:
>> 	- persistent configuration
>> 	- hotplug
>>
>> If we consider that the DPDK applications should be able to apply its own
>> policy to choose the devices to bind, then we need to implement binding
>> in the PMD (with EAL helpers).
>>
>> On the other hand, if we consider that it is the system responsibility,
>> then we could choose systemd/udev and driverctl.
>>
>> The debate is launched!
>>
> 
> Allow me to nail my colours to the mast early! :-)
> 
> I believe it's system not application responsibility.
> I also believe I have previously explained my reasons for that choice in
> some of the previous email threads.

For what it's worth, I tend to agree, if only because writing code for 
what is essentially a bunch of read/write/filesystem enumeration in C is 
extremely fiddly and error prone :) IMO things like this are better 
handled either by scripts, or by tools whose sole purpose is doing 
exactly that (or both).

I like having scripts like devbind in DPDK because we can tailor them to 
our use cases better, and having them is amenable to automation, but 
while I wouldn't be opposed to removing them altogether in favor of some 
external tool (systemd/udev/driverctl/whatever), in my humble opinion 
moving them back into EAL or even PMD's would be a mistake.

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-04-13 17:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 16:31 Thomas Monjalon
2018-04-13 16:40 ` Bruce Richardson
2018-04-13 17:40   ` Burakov, Anatoly [this message]
2018-04-14 20:10     ` Matan Azrad
2018-04-16  8:31       ` Bruce Richardson
2018-04-16 16:11         ` Matan Azrad
2018-04-16 16:57           ` Stephen Hemminger
2018-04-16 17:10             ` Matan Azrad
2018-04-16 17:18               ` Stephen Hemminger
2018-04-16 17:32                 ` Matan Azrad
2018-04-16 17:50             ` Thomas Monjalon
2018-04-17  9:23           ` Ananyev, Konstantin
2018-04-17 10:42             ` Matan Azrad
2018-04-17 11:00               ` Ananyev, Konstantin
2018-04-22 11:26                 ` Matan Azrad
2018-04-16  9:26       ` Guo, Jia
2018-04-16 16:11         ` Matan Azrad
2018-04-15  5:01   ` Wiles, Keith
2018-04-15  1:48 ` Stephen Hemminger
2018-04-18 14:11   ` Flavio Leitner
2018-04-18 18:17     ` Stephen Hemminger
2018-04-18 18:54       ` Flavio Leitner
2018-04-19  6:04         ` Alejandro Lucero
2018-04-19  8:24           ` Thomas Monjalon
2018-04-19  8:40             ` Bruce Richardson
2018-04-19  9:47               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b670f7b1-c894-ec92-86d0-fdd2fb789e67@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=fbl@redhat.com \
    --cc=jia.guo@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=matan@mellanox.com \
    --cc=pmatilai@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).