From: "Yuan,Linsi" <yuanlinsi01@baidu.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
Lance Richardson <lance.richardson@broadcom.com>,
dpdk-dev <dev@dpdk.org>
Subject: [dpdk-dev] 答复: [PATCH] net/bnxt: fix a possible stack smashing
Date: Wed, 6 May 2020 03:18:36 +0000 [thread overview]
Message-ID: <b673070af6454b67a654721616637118@baidu.com> (raw)
In-Reply-To: <CACZ4nhsXp9=URHjLkuNsP3aUqQjWXg4axdFkAtOEGjSjhYN-fA@mail.gmail.com>
Ok, I'll modify it per you suggestion
Thanks,
Yuan Linsi
________________________________
发件人: Ajit Khaparde <ajit.khaparde@broadcom.com>
发送时间: 2020年5月5日 11:42:20
收件人: Ferruh Yigit
抄送: Yuan,Linsi; Somnath Kotur; Lance Richardson; dpdk-dev
主题: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
On Thu, Apr 30, 2020 at 4:55 PM Ferruh Yigit <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>> wrote:
On 4/30/2020 2:37 PM, Yuan Linsi wrote:
> From: yuanlinsi01 <yuanlinsi01@baidu.com<mailto:yuanlinsi01@baidu.com>>
>
> We see a stack smashing as a result of defensive code missing. Once the
> nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to
> zero after doing a floor align, and we can not exit the following
> receiving packets loop. And the buffers will be overwrite, then the
> stack frame was ruined.
>
> Fix the problem by adding defensive code, once the nb_pkts is zero, just
> directly return with no packets.
>
> Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode")
> Cc: stable@dpdk.org<mailto:stable@dpdk.org>
>
> Signed-off-by: yuanlinsi01 <yuanlinsi01@baidu.com<mailto:yuanlinsi01@baidu.com>>
> Signed-off-by: rongdongsheng <rongdongsheng@baidu.com<mailto:rongdongsheng@baidu.com>>
Hi Yuan,
For the sign-off tag, we need "Name Surname <email@adress.com<mailto:email@adress.com>>" syntax,
for you I can see from mail thread that it is:
"Signed-off-by: Linsi Yuan <yuanlinsi01@baidu.com<mailto:yuanlinsi01@baidu.com>>"
Can you please share the same for the other sign-off, 'rongdongsheng'?
Yuan, Can you please send the proper first-name, last-name for rongdongsheng? Thanks
next prev parent reply other threads:[~2020-05-06 3:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 13:37 [dpdk-dev] " Yuan Linsi
2020-04-30 13:45 ` Lance Richardson
2020-04-30 18:29 ` Ajit Khaparde
2020-04-30 23:55 ` Ferruh Yigit
2020-05-05 3:42 ` Ajit Khaparde
2020-05-06 3:18 ` Yuan,Linsi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-06 3:28 Yuan Linsi
2020-05-06 5:26 ` Ajit Khaparde
2020-05-06 3:18 Yuan Linsi
2020-04-30 12:05 yuanlinsi01
2020-04-30 12:55 ` Somnath Kotur
2020-04-30 13:33 ` [dpdk-dev] 答复: " Yuan,Linsi
2020-04-30 10:08 [dpdk-dev] " yuanlinsi01
2020-04-30 10:07 yuanlinsi01
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b673070af6454b67a654721616637118@baidu.com \
--to=yuanlinsi01@baidu.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).