From: fengchengwen <fengchengwen@huawei.com>
To: Dengdui Huang <huangdengdui@huawei.com>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>, <ferruh.yigit@amd.com>,
<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
<anatoly.burakov@intel.com>, <liuyonglong@huawei.com>
Subject: Re: [PATCH v3 1/2] app/testpmd: fix help string
Date: Sun, 8 Oct 2023 10:47:59 +0800 [thread overview]
Message-ID: <b6768060-494e-036c-4427-37599b27b7be@huawei.com> (raw)
In-Reply-To: <20231008015630.406378-2-huangdengdui@huawei.com>
Hi Dengdui,
On 2023/10/8 9:56, Dengdui Huang wrote:
> Command help string is missing 'mcast_addr add|remove'.
> This patch add it.
>
> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> ---
> app/test-pmd/cmdline.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index a0e97719b3..3165347a05 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -516,6 +516,12 @@ static void cmd_help_long_parsed(void *parsed_result,
> "set allmulti (port_id|all) (on|off)\n"
> " Set the allmulti mode on port_id, or all.\n\n"
>
> + "mcast_addr add (port_id) (mcast_addr)\n"
> + " Add a multicast MAC addresses on port_id.\n\n"
> +
> + "mcast_addr remove (port_id) (mcast_addr)"
Please add '\n' at last.
with above fixed,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> + " Remove a multicast MAC address from port_id.\n\n"
> +
> "set flow_ctrl rx (on|off) tx (on|off) (high_water)"
> " (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd"
> " (on|off) autoneg (on|off) (port_id)\n"
>
next prev parent reply other threads:[~2023-10-08 2:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 2:43 [PATCH] app/testpmd: add flush multicast MAC address command Dengdui Huang
2023-08-01 15:18 ` Stephen Hemminger
2023-08-02 1:28 ` huangdengdui
2023-08-02 2:41 ` huangdengdui
2023-08-02 4:16 ` Stephen Hemminger
2023-08-02 6:11 ` huangdengdui
2023-08-02 6:23 ` [PATCH v2] " Dengdui Huang
2023-09-28 17:23 ` Ferruh Yigit
2023-10-07 8:18 ` huangdengdui
2023-10-08 1:56 ` [PATCH v3 0/2] fix help string and add a new command Dengdui Huang
2023-10-08 1:56 ` [PATCH v3 1/2] app/testpmd: fix help string Dengdui Huang
2023-10-08 2:47 ` fengchengwen [this message]
2023-10-08 6:46 ` huangdengdui
2023-10-08 1:56 ` [PATCH v3 2/2] app/testpmd: add flush all multicast MAC address command Dengdui Huang
2023-10-08 2:50 ` fengchengwen
2023-10-08 6:46 ` [PATCH v3 0/2] fix help string and add a new command Dengdui Huang
2023-10-08 6:46 ` [PATCH v4 1/2] app/testpmd: fix help string Dengdui Huang
2023-10-08 6:46 ` [PATCH v4 2/2] app/testpmd: add flush all multicast MAC address command Dengdui Huang
2023-10-09 9:39 ` [PATCH v3 0/2] fix help string and add a new command Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6768060-494e-036c-4427-37599b27b7be@huawei.com \
--to=fengchengwen@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=huangdengdui@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).