From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C1ACE426E8;
	Sun,  8 Oct 2023 04:48:03 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6CA4340263;
	Sun,  8 Oct 2023 04:48:03 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 222EF4021F
 for <dev@dpdk.org>; Sun,  8 Oct 2023 04:48:02 +0200 (CEST)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S363G2MQszrTBH;
 Sun,  8 Oct 2023 10:45:30 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Sun, 8 Oct 2023 10:47:59 +0800
Subject: Re: [PATCH v3 1/2] app/testpmd: fix help string
To: Dengdui Huang <huangdengdui@huawei.com>, <dev@dpdk.org>
CC: <stephen@networkplumber.org>, <ferruh.yigit@amd.com>,
 <aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
 <anatoly.burakov@intel.com>, <liuyonglong@huawei.com>
References: <20230801024304.2187484-1-huangdengdui@huawei.com>
 <20231008015630.406378-1-huangdengdui@huawei.com>
 <20231008015630.406378-2-huangdengdui@huawei.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <b6768060-494e-036c-4427-37599b27b7be@huawei.com>
Date: Sun, 8 Oct 2023 10:47:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20231008015630.406378-2-huangdengdui@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Dengdui,

On 2023/10/8 9:56, Dengdui Huang wrote:
> Command help string is missing 'mcast_addr add|remove'.
> This patch add it.
> 
> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> ---
>  app/test-pmd/cmdline.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index a0e97719b3..3165347a05 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -516,6 +516,12 @@ static void cmd_help_long_parsed(void *parsed_result,
>  			"set allmulti (port_id|all) (on|off)\n"
>  			"    Set the allmulti mode on port_id, or all.\n\n"
>  
> +			"mcast_addr add (port_id) (mcast_addr)\n"
> +			"    Add a multicast MAC addresses on port_id.\n\n"
> +
> +			"mcast_addr remove (port_id) (mcast_addr)"

Please add '\n' at last.

with above fixed,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

> +			"    Remove a multicast MAC address from port_id.\n\n"
> +
>  			"set flow_ctrl rx (on|off) tx (on|off) (high_water)"
>  			" (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd"
>  			" (on|off) autoneg (on|off) (port_id)\n"
>