Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, April 30, 2021 7:57 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.
> 
> On 4/29/2021 1:41 AM, Qi Zhang wrote:
> > Add IP fragment support in base code and couple QinQ improvement.
> > update the release date as the last base patch for DPDK 21.05.
> >
> > Qi Zhang (6):
> >   net/ice/base: add IP fragment flags
> >   net/ice/base: add function for post DDP download VLAN mode
> >     configuration
> >   net/ice/base: add print if DDP/FW don't support QinQ as expected
> >   net/ice/base: modififcation to support L3 DSCP QoS
> >   net/ice/base: signed External Device Package Programming
> >   net/ice/base: support IP fragment RSS and FDIR
> >
> 
> Hi Qi,
> 
> Patch by patch build fails, can you please check it?
> 
> Also some of the above patches title doesn't match to our convention, plus
> there is a checkpatch warning, can you please fix them too?
> 
> And in 4/6, the message logs are too long, yes we allow long lines instead of
> breaking them, this is to help searching log in the code, but those lines are
> ~150 chars and I think makes harder to read the code, what do you think
> indent the message and break in the sentences boundary, something like:
> "
> ice_info(hw
> 	"QinQ functionality cannot be enabled on this device. "
>         "Update your DDP package and NVM to versions that support
> QinQ.\n"); "

Thanks for the capture, all issue fixed in v2.