From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 720E8A0C47; Thu, 4 Nov 2021 19:31:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 577C742793; Thu, 4 Nov 2021 19:31:24 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id E1B7B42792 for ; Thu, 4 Nov 2021 19:31:22 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="255413619" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="255413619" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 11:31:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208";a="532355301" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 04 Nov 2021 11:31:21 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 11:31:21 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 11:31:20 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 11:31:20 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 11:31:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMSg6vjLUuAanZ+ucJWJJ1qVfkmEYH+vjzEAGxivS+RjSonMQdHqAosT+yuwXpMH/9RevW3aw9oiOIOhaGizG118Xm5aFQiXLw9SIP2x3CjuTsVcAIiV6uo2RNADnQ3H+KHzhXRuDkhta+bzZKZjKHEbqfxFCfRyZvYIUezj9MYy87gWoVp3is6xcRyl14uv6x89d5qow5HW5Q4copdoqh1z98ZzUM4YIDUfgPzDJviC2kHPvpsSU+Po7M4FhqzsEvi68IqUMSFFc/bXE+WdD+lYAMmhgc1wh4hBCrim2x8EFeVvkIzwR0LFcrgeKxcfRvf14oqvxCk4oaXt2DnifQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QQbwyZjuW+01TR0g0E3NqGePGor95DuIE3YO1a6cNmc=; b=dqrB4qwx4dKgBLiXio96KQFjzUjJkqiL+ynrarKkYoJYOfSpFp+cOZpSV5LxeixzIXJkNKC7hEIjWXuKZrQrTbGP+jlh2XzNniRaA7YJU9liqHGq6YEpBkzCjOilT6n37h7Crfc85PzhZXdfri7ZB21JRKXNMK0B+SYT/5HTgHioGFM0SPCavxVX1N7w76RuGBSLeh7q9AfJURrSujERoly+A6KBABOfIS6K8J3ZNLmBhbtTKajiDgJvY9Kpz6eOEvXoCNCUThjh+FwFdwLVNIRcf+5YHd1BJg1PgO4HFep2P+FcrNYwXJxJIGBT6h1xl2jQnuKS40p6Ykg16WkyBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQbwyZjuW+01TR0g0E3NqGePGor95DuIE3YO1a6cNmc=; b=Bmu3mblY0QmK8q5P290iPMjz3beuVxvjDEHQhM3b/TM4GHwVTImRAX1XAti1tzmZSX9T6ycYh4IhiUjxzuA46fE7ItN7oYouJne14yjjspKkHtenQtFWS5/ixXg27sjjfA0JqvUnHZ2S5GOd3SGr1xugBxqeGs3g66+WqUzwAJU= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5159.namprd11.prod.outlook.com (2603:10b6:510:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 18:31:19 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 18:31:19 +0000 Message-ID: Date: Thu, 4 Nov 2021 18:31:12 +0000 Content-Language: en-US To: Apeksha Gupta , , CC: , , References: <20211021044700.12370-2-apeksha.gupta@nxp.com> <20211103192045.22240-1-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211103192045.22240-1-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 18:31:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eaf0167b-0805-4c1f-eb42-08d99fc14b7b X-MS-TrafficTypeDiagnostic: PH0PR11MB5159: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZiVSVB8WcltPNSIk2IV7cJcV2UgnpQkAAnro1p3M+n+rj4dDn7Tsy84aCWpf2nm8xDca1xY8Lcekw67ABsr6wbEwEraK62c0HbXKvThnOcnn1v7JGUVgzxm0XSGM2A6r1qFgrW2EEdwqfP2oH0RVafWJ3fFhPjUUxUfjEPl9OJm9oQ5Rhs6Dc/SyEGY2eirkB7HSmHnIqJinCxtoo/0uug9Cq8ZI5VjBWgRu34zXXcvj1L+aehugYrV17qCGkB6DXCqeppXP/4YWotggQPHsAqUC8yO7nFAfHRJ+sGWCuVJAzznXx0E8o3EWL+RI/cnLRkOcrBQRvXWlZqDGOW5s0Hue8/eQiIEX+m9V6kQhzAsJobrnghpZB9i10L3YER5pgVKf67/qA7A8rcnYUy9XhCmkNZR34qgJVZhuaSudWnUUMJOPqDS6Cf2t3W63xhFvybA59IUzFC11noiEz68KmAOoCaQ5/mrItzrNGABJw2GryMbUgCc2rsck0UnaTLn5qgI8KdTeTocjqEQ+qNqd/Fz3J5q2MpKSQ4z8EeuesYCbo4PWWrr0u7WJJfXwNiKiU/XNJyisPyjq5gwv0+lWVE2jplTU1ZPYiv2okjK9zFNOHZNZCSJyeS0cOBDh2+XLI8+Ry95emrGkhmmtkm0Iao2bGvmEGEf3RPYh5JrfiPoAeWqQlcoAuYB2kpwzxy+tiwOtgBpY4L684jx9lGiWgg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(316002)(8936002)(508600001)(5660300002)(6486002)(82960400001)(16576012)(6666004)(86362001)(4326008)(83380400001)(2906002)(66476007)(186003)(53546011)(31686004)(66556008)(2616005)(38100700002)(36756003)(8676002)(44832011)(956004)(26005)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGttWXcrYnU0dFdsak5nTU9TSml2TUFXUzY4bFZuSWZNWWlvTHhub0w4NGNk?= =?utf-8?B?YzR3YkhGRUxPYnpRVG1zKzdDakJvSUV5SVJqVGpvZFliZFAwYlpRYWdhZXoy?= =?utf-8?B?QTJENGZPNmtmbFdkdTlwT0lSOXhFSVNlSDd5WmhjVWVkem9PS0hoTlVpT01B?= =?utf-8?B?ZlNhUStkeWVuR1dSbEV2a0FpTDBYU0gzUldWN3JMVXorQXgxYlFnSmxsdjdM?= =?utf-8?B?eGM3OXhqenFpd09SM21JRlg4Y1FEQ2szWUJTTkRLNlQxZHh5L0pJcFpneTc3?= =?utf-8?B?clVGM2ppckxGdXR6UjRqL3pnaGpyZGpZbWQ2NW1Dd2luanlZSW00Mlk5THhR?= =?utf-8?B?VW9rdmJ6RnF0dnZ4c25YZHFSUnE5Y2dNRTdsb21MT1VYTjdDYlRzd1R4Nmgy?= =?utf-8?B?YkhHOHhmWGdUTnVsTVAzZjc5QkRxWlhXUkg5NnNCTE91UVNYeGc1eVJQR2tn?= =?utf-8?B?b0haZWQ4czRPc0VHcVVCYlBETE1sbHZlZWcyZ2tkMzUvVmRaTjd2bjRiM0JG?= =?utf-8?B?cXRVUnpxTW9qcEdQck95d0ZrZURiS0M1K1FnRUlIdTc3Ti84YjNjeGhkV003?= =?utf-8?B?ZzROWGhOUzMzdi93Wm9CVWhicXhwMTByQkYwY0FZWVBNbldDYXV0SDBYUDNm?= =?utf-8?B?VjBlTjdEUzNUVkNONXNxSTVNeWhYRGJsVlllOE9oV1JoN24ybTZHdzVjdHZH?= =?utf-8?B?WWx4RThJTHZqeXJPWUVBRW04elVZRHdvVCsxdW1xeExuNGtyZVd3TmFHWVR0?= =?utf-8?B?NUs4K2FwZkkwVnNVaGFMd0lYTDdOVWtldXBCWmxXTnN1ZTBseC93OHo3bDA2?= =?utf-8?B?NDlvc1BKUml2dE1YRGZYQUZSZTBhb2tTSkNpM2xVWUI5WlZOSWFVaVJKdUtp?= =?utf-8?B?V3h4ZVdST29lQ0pIRWVoZlVCbHU5OWNjWGdCQUdvSWMwY0VTdExDTDVhSjFW?= =?utf-8?B?WjlyV2o4NzE0QnZtdUNYRml5MlNhVFgxSks3UllqWkxZUlRPejlTUEdQVzV3?= =?utf-8?B?cEEwT1dqa3N4eldTcFRlVU0yeHZLVy9iUTJLTUhIelE2Ynp4b3BReTIwcHFz?= =?utf-8?B?amZ2ZFA1WG9pNHplRzBOZVdxalN6VXBOTmRZUmgxYk81a2owaFpRTDB3cjRB?= =?utf-8?B?WGxwWTR1QjY2UExjMDVuQlh4UkJ1OHk1QytGc0tPZDFwdmp5TVRjTDZxaEFs?= =?utf-8?B?d0tXeHNVcjhqODBReVI1ZXE5SVZRME40Y0toSGkrTHNHS0VlOEdtS1p1SXg2?= =?utf-8?B?bUpidVpOb0JDK3lYVGlETXl4ZWNjQzJlQkxCejM4c1hWaTB5eUNUMTY5S29o?= =?utf-8?B?NTZoWG9DVWtvVUR2UmY2azNzNU41UjNzRHlHK0ZQd1RRbnlNc2pSUFlnZHNz?= =?utf-8?B?VlBaQUh1dE9FQTRFU0xFY25PRStLWWJtTG9zK3l3ZzZKMnZSMHdIc1kxZWRk?= =?utf-8?B?Q3l4S3BhNXp3dFA5bFBpOVo5bDR4RzdlVzB4TDVWOGt3UlJqTklBb0VmMnB2?= =?utf-8?B?NTNWZmVTdnk3NlNSR3lBZFB5am5oa3BYek5ra00zKytkWkIrSytyOTlHYkFn?= =?utf-8?B?NklZTGF3ekIxUWFsYk85WFlXcWtoUUhxZmUyUnd4SktBM3d3eDJaNFpxWDlG?= =?utf-8?B?Z1I0Y1lxSzFZUWxQMll5emx3SDVmZ3lVek9mSUl4OWZCeGw5R3lhRFMvWWgr?= =?utf-8?B?M3ZHbzl4elB1TGxQb25zQVNpU3JNT29wak1mK01pRC9SeTdCVTBPeHBTSmNT?= =?utf-8?B?WEJTUlNBeUMwTHhjZFBuZjVOckRXc3NQMzI3cThKMzE2QkR4ZzVOa3RCWGR2?= =?utf-8?B?dFJUMDF0c2doNW5maExWQlNZWVNoMk5RK0Q0dzBYVzNHL29PdDFqclJvTUVS?= =?utf-8?B?K1kvVnVFSUZyejlSZ0FkQWhwRHgrTEg2NjM0VVZRSnMrNEowakx6MHhjemJh?= =?utf-8?B?MGVxOFRzMTE2MHFUdlBGazJlaEJkQkF3TjE0VDVTbUdoSDBrenhJaW9HbHBT?= =?utf-8?B?cUFmbVd0bnc4OVgxTmZnbGdzeWE5eXB1UHdLVXJZby81MEpuaVFJZjdWckFX?= =?utf-8?B?WkxjeWFKR09WTHlwVk1xTHptVUVFZXBtcjA4Sk9BM2tWMFhkckF1V1NYRWxD?= =?utf-8?B?TGw4R0VpWHkwalgxWTNyYXk3Z2lPWElYS2xRbmVkQ0E3bGpQdHd5c1dNU1A4?= =?utf-8?Q?0vftRqaetvjjKBEGokKxiHo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: eaf0167b-0805-4c1f-eb42-08d99fc14b7b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 18:31:19.5703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 42X5vB7KjSlDoX1zbwmcZnzFoBKGL5q6yhGuXkkSyoTGxqA2SBV9xHl0N2f5UDHwipmNor9iU1n0g6UGoJpn9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5159 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 0/5] drivers/net: add NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2021 7:20 PM, Apeksha Gupta wrote: > This patch series introduce the enetfec driver, ENETFEC > (Fast Ethernet Controller) is a network poll mode driver for > the inbuilt NIC found in the NXP i.MX 8M Mini SoC. > > An overview of the enetfec driver with probe and remove are in patch 1. > Patch 2 design UIO interface so that user space directly communicate with > a UIO based hardware device. UIO interface mmap the Control and Status > Registers (CSR) & BD memory in DPDK which is allocated in kernel and this > gives access to non-cacheble memory for BD. > > Patch 3 adds the RX/TX queue configuration setup operations. > Patch 4 adds enqueue and dequeue support. Also adds some basic features > like promiscuous enable, basic stats. > Patch 5 adds checksum and VLAN features. > > Apeksha Gupta (5): > net/enetfec: introduce NXP ENETFEC driver > net/enetfec: add UIO support > net/enetfec: support queue configuration > net/enetfec: add Rx/Tx support > net/enetfec: add features > Hi Apeksha, There are many comments to the previous version seems just ignored. I did not finished reviewing this version, but to proceed can you please first address comments to both previous version and this version? Also there are some questions, it would be great if you can answer them. Thanks, ferruh