Re: [dpdk-dev] [PATCH v2 4/4] power: add cmd to query CPU freq

["Hunt, David" <david.hunt@intel.com>]

On 27/09/2019 13:16, David Hunt wrote:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>
> Add command and related logic to query CPU frequencies
> either for specified CPU or all cores.
>
> Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> Tested-by: David Hunt <david.hunt@intel.com>
> Acked-by: Lee Daly <lee.daly@intel.com>
> ---
>   .../guest_cli/vm_power_cli_guest.c            | 150 ++++++++++++++++--
>   1 file changed, 138 insertions(+), 12 deletions(-)
>

This patch set looks functionally good.

Some of the test steps I ran through are as follows:

Initialy attempt to query frequency from guest, it failed because 
queries were disabled.

     vmpower> set_query ubuntu3 disable

     vmpower(guest)> query_cpu_freq all
     GUEST_CLI: Error receiving message.
     Error during frequency list reception

Then I enabled queries for the VM:

     vmpower> set_query ubuntu3 enable

I was then able to query the freq list for all the cores in the VM:

     vmpower(guest)> query_cpu_freq all
     Frequency of [0] vcore is 2300000.
*Frequency of [1] vcore is 2300000.*
     Frequency of [2] vcore is 2300000.
     Frequency of [3] vcore is 2300000.
     Frequency of [4] vcore is 2300000.
     Frequency of [5] vcore is 2300000.
     Frequency of [6] vcore is 2300000.
     Frequency of [7] vcore is 2300000.

When a freq was changed in a core:

     vmpower(guest)> set_cpu_freq 1 down
     ACK received for message sent to host.

The frequency of core 1 had changed in the query, as expected:

     vmpower(guest)> query_cpu_freq all
     Frequency of [0] vcore is 2300000.
*Frequency of [1] vcore is 2200000.*
     Frequency of [2] vcore is 2300000.
     Frequency of [3] vcore is 2300000.
     Frequency of [4] vcore is 2300000.
     Frequency of [5] vcore is 2300000.
     Frequency of [6] vcore is 2300000.
     Frequency of [7] vcore is 2300000.

I've added a Tested-by tag to the v2 patchset.

Rgds,
Dave.