From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54A84A0613 for ; Fri, 27 Sep 2019 14:38:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79B9C1B103; Fri, 27 Sep 2019 14:38:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B448A1B079 for ; Fri, 27 Sep 2019 14:38:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 05:38:11 -0700 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208,217";a="219760262" Received: from dhunt5-mobl4.ger.corp.intel.com (HELO [10.237.221.113]) ([10.237.221.113]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/AES256-SHA; 27 Sep 2019 05:38:10 -0700 Cc: dev@dpdk.org, Marcin Hajkowski , "Daly, Lee" References: <20190403171601.9788-2-marcinx.hajkowski@intel.com> <20190927121601.23661-1-david.hunt@intel.com> <20190927121601.23661-5-david.hunt@intel.com> From: "Hunt, David" Message-ID: Date: Fri, 27 Sep 2019 13:38:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190927121601.23661-5-david.hunt@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: add cmd to query CPU freq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27/09/2019 13:16, David Hunt wrote: > From: Marcin Hajkowski > > Add command and related logic to query CPU frequencies > either for specified CPU or all cores. > > Signed-off-by: Marcin Hajkowski > Tested-by: David Hunt > Acked-by: Lee Daly > --- > .../guest_cli/vm_power_cli_guest.c | 150 ++++++++++++++++-- > 1 file changed, 138 insertions(+), 12 deletions(-) > This patch set looks functionally good. Some of the test steps I ran through are as follows: Initialy attempt to query frequency from guest, it failed because queries were disabled.     vmpower> set_query ubuntu3 disable     vmpower(guest)> query_cpu_freq all     GUEST_CLI: Error receiving message.     Error during frequency list reception Then I enabled queries for the VM:     vmpower> set_query ubuntu3 enable I was then able to query the freq list for all the cores in the VM:     vmpower(guest)> query_cpu_freq all     Frequency of [0] vcore is 2300000. *Frequency of [1] vcore is 2300000.*     Frequency of [2] vcore is 2300000.     Frequency of [3] vcore is 2300000.     Frequency of [4] vcore is 2300000.     Frequency of [5] vcore is 2300000.     Frequency of [6] vcore is 2300000.     Frequency of [7] vcore is 2300000. When a freq was changed in a core:     vmpower(guest)> set_cpu_freq 1 down     ACK received for message sent to host. The frequency of core 1 had changed in the query, as expected:     vmpower(guest)> query_cpu_freq all     Frequency of [0] vcore is 2300000. *Frequency of [1] vcore is 2200000.*     Frequency of [2] vcore is 2300000.     Frequency of [3] vcore is 2300000.     Frequency of [4] vcore is 2300000.     Frequency of [5] vcore is 2300000.     Frequency of [6] vcore is 2300000.     Frequency of [7] vcore is 2300000. I've added a Tested-by tag to the v2 patchset. Rgds, Dave.