From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C472FA0525; Thu, 20 Feb 2020 23:00:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A0DA58C4; Thu, 20 Feb 2020 23:00:32 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id E9A734C81 for ; Thu, 20 Feb 2020 23:00:30 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id k11so6291693wrd.9 for ; Thu, 20 Feb 2020 14:00:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ZaQfYIgH+DED4PU6UCB0bTv4G+glwdhPUllB7kRqSn4=; b=Ztjp6nAqx/fXe6giaLMEq4LWrniDcPAerR+f1r0v4gf8cYHmM1QPOG5Sp0/TRHR2UR 1EW/jbbvlPHpJlW18NNeU2DmHmgaLIjW8BV0MJD49Ox1q2I3CEMHN0tF0IZKG5zhyF5i 1Y/wN8JxaaKEmht4uTacB5e1ZxyKEBLuFfKOWeUUHtxGCI5KY1CjLaVdoGjjVXDUqz2G MLib6L1UJ3dd5fugCB/Suq/fgLHYFjAbUQhbhaekdmdaIn5AMxGKMeXZNFRQ8HEh+rj6 b/d96GkpBE6eN9ZBdqPhFWMsvwS1P9cb1dt2aMQMjMhDFTwg2bsn/mR7G0I/pQtm9Yj2 OG/w== X-Gm-Message-State: APjAAAUs5ts58SP7JRkoCEIpdNLkjC9Rj8wIoXLiyHsLRz85feRN4632 SHUtnnm0EaCSxy8fYczHBkU= X-Google-Smtp-Source: APXvYqxXXky5epDxElTHzDHYt0lMJu1/a/J4/OHyKYCyjTvyb9qXXijb0jLT5FNYx+/VNiguvktjug== X-Received: by 2002:a5d:514b:: with SMTP id u11mr44066475wrt.322.1582236030546; Thu, 20 Feb 2020 14:00:30 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c74sm924014wmd.26.2020.02.20.14.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:00:30 -0800 (PST) Message-ID: From: Luca Boccassi To: Ruslan Babayev Cc: dev@dpdk.org, "Richardson, Bruce" Date: Thu, 20 Feb 2020 22:00:29 +0000 In-Reply-To: References: <20200219191326.35842-1-ruslan@babayev.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: add combined libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-02-20 at 13:35 -0800, Ruslan Babayev wrote: > Hi Luca, >=20 > PkgConfig doesn't cover the case of static linking. See below: >=20 > $ pkg-config --libs libdpdk > -lrte_bpf -lrte_flow_classify -lrte_pipeline -lrte_table -lrte_port > -lrte_fib -lrte_ipsec -lrte_vhost -lrte_stack -lrte_security > -lrte_sched -lrte_reorder -lrte_rib -lrte_rcu -lrte_rawdev > -lrte_pdump -lrte_power -lrte_member -lrte_lpm -lrte_latencystats > -lrte_kni -lrte_jobstats -lrte_ip_frag -lrte_gso -lrte_gro > -lrte_eventdev -lrte_efd -lrte_distributor -lrte_cryptodev > -lrte_compressdev -lrte_cfgfile -lrte_bitratestats -lrte_bbdev > -lrte_acl -lrte_timer -lrte_hash -lrte_metrics -lrte_cmdline > -lrte_pci -lrte_ethdev -lrte_meter -lrte_net -lrte_mbuf -lrte_mempool > -lrte_ring -lrte_eal -lrte_kvargs >=20 > And here's the combined libdpdk.a >=20 > GROUP ( librte_acl.a librte_bbdev.a librte_bitratestats.a > librte_bpf.a librte_bus_dpaa.a librte_bus_fslmc.a librte_bus_ifpga.a > librte_bus_pci.a librte_bus_vdev.a librte_bus_vmbus.a > librte_cfgfile.a librte_cmdline.a librte_common_cpt.a > librte_common_dpaax.a librte_common_iavf.a librte_common_octeontx2.a > librte_common_octeontx.a librte_compressdev.a librte_cryptodev.a > librte_distributor.a librte_eal.a librte_efd.a librte_ethdev.a > librte_eventdev.a librte_fib.a librte_flow_classify.a librte_gro.a > librte_gso.a librte_hash.a librte_ip_frag.a librte_ipsec.a > librte_jobstats.a librte_kni.a librte_kvargs.a librte_latencystats.a > librte_lpm.a librte_mbuf.a librte_member.a librte_mempool.a > librte_mempool_bucket.a librte_mempool_dpaa2.a librte_mempool_dpaa.a > librte_mempool_octeontx2.a librte_mempool_octeontx.a > librte_mempool_ring.a librte_mempool_stack.a librte_meter.a > librte_metrics.a librte_net.a librte_pci.a librte_pdump.a > librte_pipeline.a librte_pmd_aesni_gcm.a librte_pmd_aesni_mb.a > librte_pmd_af_packet.a librte_pmd_ark.a librte_pmd_atlantic.a > librte_pmd_avp.a librte_pmd_axgbe.a librte_pmd_bbdev_fpga_lte_fec.a > librte_pmd_bbdev_null.a librte_pmd_bbdev_turbo_sw.a librte_pmd_bnxt.a > librte_pmd_bond.a librte_pmd_caam_jr.a librte_pmd_ccp.a > librte_pmd_crypto_scheduler.a librte_pmd_cxgbe.a librte_pmd_dpaa2.a > librte_pmd_dpaa2_event.a librte_pmd_dpaa2_sec.a librte_pmd_dpaa.a > librte_pmd_dpaa_event.a librte_pmd_dpaa_sec.a librte_pmd_dsw_event.a > librte_pmd_e1000.a librte_pmd_ena.a librte_pmd_enetc.a > librte_pmd_enic.a librte_pmd_failsafe.a librte_pmd_fm10k.a > librte_pmd_hinic.a librte_pmd_hns3.a librte_pmd_i40e.a > librte_pmd_iavf.a librte_pmd_ice.a librte_pmd_ifc.a > librte_pmd_ixgbe.a librte_pmd_kasumi.a librte_pmd_kni.a > librte_pmd_liquidio.a librte_pmd_memif.a librte_pmd_netvsc.a > librte_pmd_nfp.a librte_pmd_nitrox.a librte_pmd_null.a > librte_pmd_null_crypto.a librte_pmd_octeontx2.a > librte_pmd_octeontx2_crypto.a librte_pmd_octeontx2_event.a > librte_pmd_octeontx.a librte_pmd_octeontx_compress.a > librte_pmd_octeontx_crypto.a librte_pmd_octeontx_event.a > librte_pmd_opdl_event.a librte_pmd_openssl.a librte_pmd_pfe.a > librte_pmd_qat.a librte_pmd_qede.a librte_pmd_ring.a librte_pmd_sfc.a > librte_pmd_skeleton_event.a librte_pmd_snow3g.a librte_pmd_softnic.a > librte_pmd_sw_event.a librte_pmd_tap.a librte_pmd_thunderx.a > librte_pmd_vdev_netvsc.a librte_pmd_vhost.a librte_pmd_virtio.a > librte_pmd_virtio_crypto.a librte_pmd_vmxnet3.a librte_pmd_zuc.a > librte_port.a librte_power.a librte_rawdev.a > librte_rawdev_dpaa2_cmdif.a librte_rawdev_dpaa2_qdma.a > librte_rawdev_ioat.a librte_rawdev_ntb.a > librte_rawdev_octeontx2_dma.a librte_rawdev_octeontx2_ep.a > librte_rawdev_skeleton.a librte_rcu.a librte_reorder.a librte_rib.a > librte_ring.a librte_sched.a librte_security.a librte_stack.a > librte_table.a librte_timer.a librte_vhost.a ) >=20 > Combining the libs into a single libdpdk.a (including the PMDs) makes > it much simpler to statically link against. > How does pkg-config solve this? >=20 > Regards, > Ruslan pkg-config does cover static linking, and much better as the linker script is missing all the reverse dependencies and the CFLAGS, which are necessary when doing static linking. pkg-config --static --libs --cflags libdpdk > On Thu, Feb 20, 2020 at 2:13 AM Luca Boccassi > wrote: > > On Wed, 2020-02-19 at 11:13 -0800, Ruslan Babayev wrote: > > > Add combined libdpdk.a and libdpdk.so libs for Meson similar to > > how > > > it's done for Make builds > > >=20 > > > Signed-off-by: Ruslan Babayev < > > > ruslan@babayev.com > > > > > > > --- > > > buildtools/group-libs.sh | 2 ++ > > > buildtools/meson.build | 1 + > > > meson.build | 17 +++++++++++++++++ > > > 3 files changed, 20 insertions(+) > > > create mode 100755 buildtools/group-libs.sh > > >=20 > > > diff --git a/buildtools/group-libs.sh b/buildtools/group-libs.sh > > > new file mode 100755 > > > index 000000000..b6e4c1c35 > > > --- /dev/null > > > +++ b/buildtools/group-libs.sh > > > @@ -0,0 +1,2 @@ > > > +#!/bin/sh > > > +echo 'GROUP (' $(echo $* | xargs -n1 basename | sort | xargs) > > ')' > > > diff --git a/buildtools/meson.build b/buildtools/meson.build > > > index 9812917e5..eac8bc4ff 100644 > > > --- a/buildtools/meson.build > > > +++ b/buildtools/meson.build > > > @@ -6,6 +6,7 @@ subdir('pmdinfogen') > > > pkgconf =3D find_program('pkg-config', 'pkgconf', required: false) > > > pmdinfo =3D find_program('gen-pmdinfo-cfile.sh') > > > list_dir_globs =3D find_program('list-dir-globs.py') > > > +group_libs =3D find_program('group-libs.sh') > > > check_experimental_syms =3D find_program('check-experimental- > > syms.sh') > > > ldflags_ibverbs_static =3D find_program('options-ibverbs- > > static.sh') > > > =20 > > > diff --git a/meson.build b/meson.build > > > index b7ae9c8d9..eb6974d35 100644 > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -61,6 +61,23 @@ configure_file(output: build_cfg, > > > install_dir: join_paths(get_option('includedir'), > > > get_option('include_subdir_arch'))) > > > =20 > > > + > > > +custom_target('group_shared_libs', > > > + input: dpdk_libraries, > > > + output: 'libdpdk.so', > > > + capture: true, > > > + install: true, > > > + install_dir: get_option('libdir'), > > > + command: [group_libs, '@INPUT@']) > > > + > > > +custom_target('group_static_libs', > > > + input: dpdk_static_libraries + dpdk_drivers, > > > + output: 'libdpdk.a', > > > + capture: true, > > > + install: true, > > > + install_dir: get_option('libdir'), > > > + command: [group_libs, '@INPUT@']) > > > + > > > # for static builds, include the drivers as libs and we need to > > > "whole-archive" > > > # them. > > > dpdk_drivers =3D ['-Wl,--whole-archive'] + dpdk_drivers + ['-Wl, > > --no- > > > whole-archive'] > >=20 > > Hi, > >=20 > > As far as I'm aware all usage of the old hacky linker script can be > > replaced with pkg-config, and that's why it was left behind. Same > > for > > the static archive. > >=20 > > Is there any use case that pkg-config doesn't cover? > >=20 >=20 >=20 --=20 Kind regards, Luca Boccassi