From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45F9DA04EF; Mon, 1 Jun 2020 14:50:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 936691C434; Mon, 1 Jun 2020 14:50:31 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F16092C58 for ; Mon, 1 Jun 2020 14:50:29 +0200 (CEST) IronPort-SDR: hOonmcPltnxy3vxiVZh2ZbOgsFX7p3F/69wMImJa4KZHOS94JBwoH2itxFewMfYZ56OB2UepCt Jjs3bNg9X2Pg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 05:50:28 -0700 IronPort-SDR: YWYAuW9MvoQiuStt8VVytBYoxDUY29xiAVg1AdvKcoOBk+AyrFilHkaEn866HOTEfUibpkLS0k CONS+7v2PT2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,460,1583222400"; d="scan'208";a="311942848" Received: from jkane1-mobl3.ger.corp.intel.com (HELO [10.213.231.125]) ([10.213.231.125]) by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2020 05:50:27 -0700 To: Harman Kalra Cc: dev@dpdk.org, David Hunt , liang.j.ma@intel.com, reshma.pattan@intel.com References: <20200529131955.GA83122@outlook.office365.com> <660267ae-00a0-bb55-fbc3-9ac1473957ea@intel.com> <20200530100228.GA24648@outlook.office365.com> From: "Burakov, Anatoly" Message-ID: Date: Mon, 1 Jun 2020 13:50:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200530100228.GA24648@outlook.office365.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30-May-20 11:02 AM, Harman Kalra wrote: > On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: >> External Email >> >> ---------------------------------------------------------------------- >> On 29-May-20 2:19 PM, Harman Kalra wrote: >> >>>> if (ret < 0) >>>> rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); >>>> - if (app_mode != APP_MODE_TELEMETRY && init_power_library()) >>>> + if (app_mode == APP_MODE_DEFAULT) >>>> + app_mode = APP_MODE_LEGACY; >>>> + >>>> + /* only legacy and empty poll mode rely on power library */ >>>> + if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) && >>>> + init_power_library()) >>>> rte_exit(EXIT_FAILURE, "init_power_library failed\n"); >>> Hi, >>> >>> Rather than just exiting from here can we have a else condition to >>> automatically enter into the "interrupt only" mode. >>> Please correct me if I am missing something. >> >> Hi, >> >> Thanks for your review. I don't think silently proceeding is a good idea. If >> the user wants interrupt-only mode, they should request it. Silently falling >> back to interrupt-only mode will create an illusion of successful >> initialization and set the wrong expectation for how the application will >> behave. >> > > Hi, > > Thanks for the explanation which even I also believe is logically perfect. > > But since l3fwd-power is an old application and has many users around > which are currently using this app in interrupt only mode without giving > an extra argument. But suddenly they will start getting failure messages with > the new patchset. > > My only intent with else condition was backward compatibility. > Or may be we can have more descriptive failure message, something like > "init_power_library failed, check manual for other modes". > > Thanks > Harman > > I think we can compormise on an informative log message suggesting to use interrupt mode. I'm not keen on reverting to previous buggy behavior :) >> -- >> Thanks, >> Anatoly -- Thanks, Anatoly