From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id BC3B62E8F
 for <dev@dpdk.org>; Wed, 12 Sep 2018 09:25:08 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 21595401EF04;
 Wed, 12 Sep 2018 07:25:08 +0000 (UTC)
Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FE9A2023416;
 Wed, 12 Sep 2018 07:25:07 +0000 (UTC)
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
References: <20180622123605.10241-1-roy.fan.zhang@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <b71138d2-1d16-f56f-2499-b451f6c264d3@redhat.com>
Date: Wed, 12 Sep 2018 09:25:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180622123605.10241-1-roy.fan.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Wed, 12 Sep 2018 07:25:08 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Wed, 12 Sep 2018 07:25:08 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2018 07:25:09 -0000

Hi Fan,

On 06/22/2018 02:36 PM, Fan Zhang wrote:
> Originally vhost_crypto sample application only supports single
> core. This patch adds the multi-core support with more flexible
> options.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   doc/guides/sample_app_ug/vhost_crypto.rst |  26 +-
>   examples/vhost_crypto/main.c              | 480 +++++++++++++++++-------------
>   2 files changed, 282 insertions(+), 224 deletions(-)
> 


Sorry for the late review.
The patch looks good to me:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Maxime