From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Zhang, Yuying" <yuying.zhang@intel.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets
Date: Thu, 19 May 2022 11:23:16 +0300 [thread overview]
Message-ID: <b714c525-7c67-26b4-0314-e6354bbcbfd0@oktetlabs.ru> (raw)
In-Reply-To: <DM6PR11MB35160731DB9C1154DDB28FCC8ECE9@DM6PR11MB3516.namprd11.prod.outlook.com>
On 5/17/22 19:02, Zhang, Yuying wrote:
> Hi Wenwu,
> LGTM.
>
>> -----Original Message-----
>> From: Ma, WenwuX <wenwux.ma@intel.com>
>> Sent: Thursday, May 12, 2022 9:08 AM
>> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
>> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
>> dev@dpdk.org
>> Cc: Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan <yinan.wang@intel.com>;
>> He, Xingguang <xingguang.he@intel.com>; Ma, WenwuX
>> <wenwux.ma@intel.com>; stable@dpdk.org
>> Subject: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO
>> packets
>>
>> The GRO/GSO library doesn't re-calculate checksums for merged/fragmented
>> packets. If users want the packets to have correct IP checksums, they should
>> select HW IP checksum calculation for the port which the packets are
>> transmitted to. But if the port doesn't support HW IP checksum, users may
>> perform a SW IP checksum. This patch add the code about it.
>>
>> Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4
>> GRO")
>> Fixes: 52f38a2055ed ("app/testpmd: enable TCP/IPv4 VxLAN and GRE GSO")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
>
> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
Since CI is happy with the patch now [1].
[1] https://lab.dpdk.org/results/dashboard/patchsets/22087/
Applied, thanks.
prev parent reply other threads:[~2022-05-19 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 1:37 [PATCH] app/testpmd: perform SW IP checksum for GRO packets Wenwu Ma
2022-05-11 7:27 ` David Marchand
2022-05-11 9:00 ` Ma, WenwuX
2022-05-11 9:35 ` [PATCH v2] app/testpmd: perform SW IP checksum for GRO/GSO packets Wenwu Ma
2022-05-12 1:07 ` [PATCH v3] " Wenwu Ma
2022-05-12 1:33 ` Hu, Jiayu
2022-05-17 2:56 ` Ling, WeiX
2022-05-17 16:02 ` Zhang, Yuying
2022-05-19 8:23 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b714c525-7c67-26b4-0314-e6354bbcbfd0@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).