From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 942C2A0503; Thu, 19 May 2022 10:23:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84B2B40150; Thu, 19 May 2022 10:23:18 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 4B06840140; Thu, 19 May 2022 10:23:17 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id DD65F8A; Thu, 19 May 2022 11:23:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru DD65F8A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1652948596; bh=gpznysHJD4BJFxy5TiVAz5VJrt6Z2QiHGzTCf7u1/Hc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ea+9bP0XHDZzUIxHCboKqCDOZfVIKVoaNvfcZWCzMoSU0/g/ivnuKlicS3QSJrJUe odyhNlmaMMkmg4sv9znBID+xRRKp9P9mD90k2UQTq7ZTHUkNyFdTP3Uxd5Bntk2HaI Fmm7zxKWhxx0Ho0vTfd2+c+sqEbaUnX+ERUcW/Iw= Message-ID: Date: Thu, 19 May 2022 11:23:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets Content-Language: en-US To: "Zhang, Yuying" , "Ma, WenwuX" , "Li, Xiaoyun" , "Singh, Aman Deep" , "dev@dpdk.org" Cc: "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" , "stable@dpdk.org" References: <20220511013705.24602-1-wenwux.ma@intel.com> <20220512010756.29553-1-wenwux.ma@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/17/22 19:02, Zhang, Yuying wrote: > Hi Wenwu, > LGTM. > >> -----Original Message----- >> From: Ma, WenwuX >> Sent: Thursday, May 12, 2022 9:08 AM >> To: Li, Xiaoyun ; Singh, Aman Deep >> ; Zhang, Yuying ; >> dev@dpdk.org >> Cc: Hu, Jiayu ; Wang, Yinan ; >> He, Xingguang ; Ma, WenwuX >> ; stable@dpdk.org >> Subject: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO >> packets >> >> The GRO/GSO library doesn't re-calculate checksums for merged/fragmented >> packets. If users want the packets to have correct IP checksums, they should >> select HW IP checksum calculation for the port which the packets are >> transmitted to. But if the port doesn't support HW IP checksum, users may >> perform a SW IP checksum. This patch add the code about it. >> >> Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4 >> GRO") >> Fixes: 52f38a2055ed ("app/testpmd: enable TCP/IPv4 VxLAN and GRE GSO") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wenwu Ma > > Acked-by: Yuying Zhang Since CI is happy with the patch now [1]. [1] https://lab.dpdk.org/results/dashboard/patchsets/22087/ Applied, thanks.