From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask
Date: Fri, 20 Apr 2018 01:47:08 +0100 [thread overview]
Message-ID: <b73159c0-6f44-6169-d6d8-30bb6e155742@intel.com> (raw)
In-Reply-To: <20180419235754.75550-3-ajit.khaparde@broadcom.com>
On 4/20/2018 12:57 AM, Ajit Khaparde wrote:
> In some cases bnxt_hwrm_cfa_l2_set_rx_mask is being called before
> VNICs are allocated. The FW returns an error in such cases.
> Prevent sending the command the FW by checking for a valid vnic id
Hi Ajit,
Commit title doesn't explain "why" but explains what has been done. It is easier
to see "what" part from code but not easy to see "why" without explanation. Here
commit log explain the reason and scope, only title doesn't reflect it. Title
can be something like "fix firmware error" ...
Please check patches with "check-git-log.sh", it will already complain about
title, script complains about "_" to force explaining "why" instead of using
variable/function names.
Previous set you have sent has same problem, they are already in next-net but if
you have bandwidth can you please check them too? If you can send revised commit
log/title I can update them. "check-git-log.sh" will help to find failing ones.
<...>
> @@ -594,7 +590,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
> }
> bp->dev_stopped = 0;
>
> - rc = bnxt_init_nic(bp);
> + rc = bnxt_init_chip(bp);
Is this bnxt_init_nic()/bnxt_init_chip() changes related to what has been
described in commit log? If so can you explain in commit log why there are related?
next prev parent reply other threads:[~2018-04-20 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 23:57 [dpdk-dev] [PATCH 0/3] bnxt patchset Ajit Khaparde
2018-04-19 23:57 ` [dpdk-dev] [PATCH 1/3] net/bnxt: cache address of doorbell to subsequent access Ajit Khaparde
2018-04-19 23:57 ` [dpdk-dev] [PATCH 2/3] net/bnxt: check vnic_id before issuing set_rx_mask Ajit Khaparde
2018-04-20 0:47 ` Ferruh Yigit [this message]
2018-04-20 3:32 ` [dpdk-dev] [dpdk-stable] " Ajit Khaparde
2018-04-19 23:57 ` [dpdk-dev] [PATCH 3/3] net/bnxt: initialize mbuf data_off Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b73159c0-6f44-6169-d6d8-30bb6e155742@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).