From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Cc: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>,
Lukas Bartosik <lbartosik@marvell.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Nipun Gupta <nipun.gupta@nxp.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Liang Ma <liang.j.ma@intel.com>,
"techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library
Date: Fri, 28 Jun 2019 11:07:43 +0200 [thread overview]
Message-ID: <b74798cf-df5d-2ca9-9673-cc61e52e8164@ericsson.com> (raw)
In-Reply-To: <2775383.qy1u6QUkDx@xps>
On 2019-06-28 10:40, Thomas Monjalon wrote:
> 28/06/2019 05:37, Jerin Jacob Kollanukkaran:
>> From: Anoob Joseph
>>> From: Jerin Jacob Kollanukkaran
>>>> From: Anoob Joseph
>>>>> The helper library will be experimental while we add event-mode
>>>>> support for other applications like l3fwd & ipsec-secgw. I expect
>>>>> the helper library to be complete over the course of those
>>>>> applications also using the helper library.
>
> You are doing a copy of l2fwd example to add event mode.
> It was the decision from the techboard to not complicate the original
> l2fwd. But it makes me nervous to see some code duplicated,
> especially if you plan to do the same for l3fwd and ipsec-secgw.
> We are not going to duplicate every examples. We should re-consider.
>
>>>> I have only concern about moving this as library inside eventdev that
>>>> till we have mature version of helper library the eventdev library ABI
>>>> will not stable(i.e .so file version needs to be incremented as when a
>>>> change needed). Which align with Mattias thoughts for some other
>>>> reason:. How about moving this code to
>>>> 1) example/common or
>>>> 2) to specific application itself, once at least two applications
>>>> starts using it then move to Eventdev library.
>>>>
>>>> Thoughts?
>>>
>>> [Anoob] Either location is not a problem if there is a consensus. Earlier the
>>> suggestion was to move it to library (when the patch was submitted with
>>> changes added in app).
>
> If there is only one user, making it grow in the application looks to be
> the best thing to do.
> Should we use it in more applications before it is more mature?
> If not, we could move the code in eventdev library when we will
> use it in more examples.
>
>> If there NO objections then lets move to example/common.
>
> If we really want to have this library standalone in examples,
> I suggest to give it a name and not use a "common" directory.
>
>
Another solution would be to keep it in a separate git repo, potentially
together with a few forked DPDK example applications and new
purpose-built example applications, until it's mature enough.
It's a bolt-on, not an integral part of eventdev or any other
lower-layer infrastructure, so you don't need the whole DPDK tree.
next prev parent reply other threads:[~2019-06-28 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:33 Jerin Jacob Kollanukkaran
2019-06-27 5:28 ` Anoob Joseph
2019-06-28 3:37 ` Jerin Jacob Kollanukkaran
2019-06-28 8:02 ` Mattias Rönnblom
2019-06-28 8:40 ` Thomas Monjalon
2019-06-28 9:07 ` Mattias Rönnblom [this message]
2019-06-28 11:34 ` [dpdk-dev] [EXT] " Anoob Joseph
2019-07-02 14:17 ` Anoob Joseph
2019-07-02 14:26 ` Jerin Jacob Kollanukkaran
2019-07-02 14:49 ` Bruce Richardson
2019-07-02 14:57 ` Thomas Monjalon
2019-07-02 16:18 ` Anoob Joseph
2019-07-02 17:38 ` Mattias Rönnblom
2019-07-03 1:35 ` Anoob Joseph
2019-07-03 8:51 ` Thomas Monjalon
2019-07-03 9:37 ` Anoob Joseph
2019-07-03 16:30 ` Thomas Monjalon
2019-07-04 3:34 ` Anoob Joseph
-- strict thread matches above, loose matches on Subject: below --
2019-06-03 17:32 [dpdk-dev] " Anoob Joseph
2019-06-07 9:48 ` Jerin Jacob Kollanukkaran
2019-06-11 10:44 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74798cf-df5d-2ca9-9673-cc61e52e8164@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=lbartosik@marvell.com \
--cc=liang.j.ma@intel.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).