From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D36AA0032; Fri, 14 Jan 2022 15:13:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE84E4114E; Fri, 14 Jan 2022 15:13:51 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EFB9940C35 for ; Fri, 14 Jan 2022 15:13:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642169630; x=1673705630; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=CzIH71GFV6iJ8gSnoLWi3ykLeKEP1HFlyIugTgtfXoQ=; b=cmsRq6n3k0zMODDbZfwJ8Zx9oKzdCFFJFqa7lPNZBjNn8lh5ekVxq/j+ tPQQlKISS8vA8kwFMxMgz+8klUxssT5ldoKLMbCFcifKorawwDZHLlwdK VVEAyna0yaKVhK6IXldNmRFIthVH7GW1WU0zy6tOvVNDlIRf/u/wXu0Qa fJOnQDeohyCSCSHYZVwuisGmL5Ldy1vJVHaGaG8A6kHMQs2JFaq/mHAbR fzHFwyIhK2LxXEr8ELKkp/SJzGdrGhd4GNo4FpKezAXgZIFXg1FmzHZ69 1MsBf37BLbap8nxbpzPYNjM2LiKKEwAAQUDeg80qkaVTzyqZnf5yTlCS9 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="244452591" X-IronPort-AV: E=Sophos;i="5.88,288,1635231600"; d="scan'208";a="244452591" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 06:13:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,288,1635231600"; d="scan'208";a="624353453" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 14 Jan 2022 06:13:48 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 06:13:48 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 14 Jan 2022 06:13:48 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 14 Jan 2022 06:13:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hqH9J8jh5B7S1UWxzRJnShEYFYP+A6sPjiugh+oZburabaXOP8IkptfMRFqBMha2zHnHFjYwHT7NXOK594o7lRN7rDjK45Vds07Pvsf8v58qLGICDFQNkS3cRL2Cfv+ld05L6viM3nhZQqUG057Knxcf4GBjatVTREJSz3S/M9802pjd6li04RbofSpbVoxk9mG0J2RT15rquDraKj/ft9v+TzgnsP8ioTkNwHBJuTX6h2FS6+Cug+8nmG79E5NydfTV+X8XrVFuu1EbtZaXrp1D9q4PzaWRqttOgNktyqxL1K8UO120X/Rk7bgBNcuc7v5YLoPfA5IV/Oh7Kmk0+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V4OCxb6W1vrSp/621k2UofUISeEiKr5wyvIQoDI/UCw=; b=RdofgFE+IWZ1r33aMdprfmdQIhmUs+ViGarPJzZj5jkv182yte7U/CBvT4VEmkiesU2qDW8hZ8BJXi+HerLypy5WYM7s6Ygxona3YRMhAosJesPbpd0NfW7WOVZETstRyTafg15gfvdHt1Ft0GwrJD1/51MXYZCZvJcpUCRxolwlDrsoQ1dLjT1L02LqJeE43ww3Oap8GynLAZGip3XHI/d+vc2rgXaZxYuubXRz3ahFyqbvfvegw9P1xCN7Qzq/texTmVnkJTUt+HnhGeGvPN46gcnIXdPOAoDLXZBsiFj3UrNBp8U1VCIGiGl6o2TNvPrnvxvbViNgp/J4pp98+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5925.namprd11.prod.outlook.com (2603:10b6:510:143::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Fri, 14 Jan 2022 14:13:46 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 14:13:46 +0000 Message-ID: Date: Fri, 14 Jan 2022 14:13:39 +0000 Subject: Re: [PATCH v4] kni: allow configuring the kni thread granularity Content-Language: en-US To: Tudor Cornea CC: , , , References: <1636366413-57455-1-git-send-email-tudor.cornea@gmail.com> <1637781854-74761-1-git-send-email-tudor.cornea@gmail.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1637781854-74761-1-git-send-email-tudor.cornea@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0468.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::24) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef7475e3-065e-4a77-d669-08d9d768140c X-MS-TrafficTypeDiagnostic: PH0PR11MB5925:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BHXyEM+qS0otlgQGhltRU1WQaVDxfgMuwzf4NygJOT91Vrowhb+oiYvUb3nJIzmLwi/DNUbOnqyggND0Ye28TqvMZndo2lSnERSqiGm6G/4lwz9z7QPEPbOehGjaeQKO7n1mKo8aCM8BNw8HtfTF8oGAsfRngd72XokbyrPrQe/veJWyCSGsam+AEErA6Ub7EI1Vv84V5yhNjqSyBGBeLYG2Bw3fctJ1I2yf0hU0b8wXmqzqIuuvEo1exRM8MJDHmNbpWJ175BdTSW0wFROL81E3/HI1eVv1tY02mCOtDiosLBxcyW8xrOsWc/1/9MJmG+L3HO90ym7dFBbc871ipz5+jNKu0RfRZ6kWeUZO8R3vaeZ/Vrt85hAqzCkHGneaD8waeBxfUm1OEe9Ur/QMdedeOla4KncjF+HefAzlOJIkVQY2+oDG5rg9cjDwsZvqx6eOnQf6ADxaquc3ZQt3l3kfMGEjznQIN7C24Mke42fy7ob1p0DLLQy5fT0zJbPje1PFJTEGEdCbI5WER/jSZcUZQiwI9WPA/jnlVzOtN9RNOaAtaQLYvQ0JrR+sOg++IDyXlnF9vKPSk6Yxll1/vBbw0vgbvkk77/sBXoMZyYgboHMfrlAZBVX85YAKLXBkNfbCUaqgMOzVDu0igapn7aDTU8RoDBvvPdAIaRexX0+FwloWE+ZWVwDi3Ws4d6G3UYJWGZaU1ygDLAWDX+b1lszgvDgVCbVy+q9GzYCUZaHB4xXMk7X3BQY+gBd7dBnlvxK3xeNZt+cA9uNdiMq5oivBLv1f7ccKJ5U+3jkbb90= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(966005)(186003)(6486002)(66476007)(2616005)(6666004)(66946007)(31696002)(26005)(5660300002)(4326008)(31686004)(508600001)(86362001)(2906002)(66556008)(8676002)(83380400001)(38100700002)(6916009)(6506007)(316002)(36756003)(53546011)(8936002)(82960400001)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWcwenRiRVl1VFQ2VWJ1dVVMdzFvbm9jVXI4NFVpY1ZsZzl1dDdQZVVqd2FJ?= =?utf-8?B?M3pZejcyUm1WVDMwZnpKUUY5N3hsRDd1NjNLRDFpZXRJdWxUdnlBVEgwNldS?= =?utf-8?B?TTlOMUkzRTNjNWVqQzNmTW92K3NISXlEVDBtcVhJU3A3d2RndnVCbWtwM0lF?= =?utf-8?B?Ky8wdTZSUDVqUHBZN2t4cXZkZmRGaXh1R2R2bnFLVytTTW52WlZaTndCZDdw?= =?utf-8?B?L2VCMFJMdW83ejFTQnVxMFZGM1hNWmJ5MzlpMXFEVmxIYXBHTUNuRG81K1k5?= =?utf-8?B?SnZEWGgyN3ZWOXJ5UnJKQ25iUzNxNVBWM0xnbjdoVkEzdEFVaFA2eTdlVStJ?= =?utf-8?B?enNKVXZIVkx0UTNyYTZaRXhxODM1SVpSSHJSckdsY1NZWEtlenFxZDFjaG1o?= =?utf-8?B?bFNwVVFmUVhpbXk0bzN6dU8zKzlVTnlmMERlYkJvTTNaMEhWMjZuaTZFK2g2?= =?utf-8?B?T1QrcGRHdEJ3ZHBHV1dMZ0wxRWJQRk1iajcweWhlU0xTL3g3VFM5SlRNK1R2?= =?utf-8?B?dWdCbWZnbTVRTmFzUFdwTEtHYzUxYkt6dSt5NFN3UmNPdkZmK3U4YXRma05s?= =?utf-8?B?V0Y1YkVMZnpXN0VvZExUajJTSmNrMzA3YTZ1YWR5Z1h2U2gzTXk5QkxXTWJ1?= =?utf-8?B?Mk5nc29WUFhWRmpyYTlLVU9Td2ptNGo2d05XOUJLbWovUlJoeFM5UWRMSENF?= =?utf-8?B?Tm1QMU9Oc0hKRThkT1VNbFJqVmVDYkM5TWtHS1pZeVNHdTJFS0tkbHMvWnBn?= =?utf-8?B?M0FLZHh5VTArbUcxOTlYLy9uNlBKSGYxRVFENTM2NlhMK3lySzhlZUpIbE9h?= =?utf-8?B?aHVTZy94L0Q3TzZobE4zVXNzZ3hqMU1rVDNmSjVVU2F0c3FkYzRWTngyeDVw?= =?utf-8?B?WUNSc1JMT2ZiQU5zUlk3MWxsQm9Qd2NOTFhwUklGMTdWZ2czQ3pYLzN4Ymdo?= =?utf-8?B?T2twbyt5TncvckdlcW5JbzYzNGFuaTNEczJwQjNacU5IZDRQeDBqbEZZdXBM?= =?utf-8?B?cW9Nd3psT2liM0dwSHQwZVZVNGdRRGFmOUpEZkNLUElLaHFsRGd6UlBlV0Jv?= =?utf-8?B?SUxUbzhtRjlnWTg0RXhJZVVYN1BmK3h2U2pyM2ZiYkF2TFRUUlZ0Njd5VUNw?= =?utf-8?B?VmV2UU9BWllabVQ2ZVNoLzJDZW41a0VMWERPUU9ON01CZElKb1cvSEVaOU41?= =?utf-8?B?VXBVcVBOa2lBdmVORzBwdVNETEZVeUVPMDZBbThsbXZOOFd5WjcyQitIZ0NY?= =?utf-8?B?eVRTOTFKckcydzR4cklvWTBBVFNqMEUyd2ZnV3d4QTNJWVdSeGhxVFVWcFNT?= =?utf-8?B?aHdURW5rb09SbEJTK3lIWXpidGp1SUhwbWU1a2d2RW10TldCSjhBcXZycVdm?= =?utf-8?B?b3FuVjlxOFBTL3VKaS9ta2pFTUdiK3d1N1N4NThtSUN4Skp3eE01bXFOVHl4?= =?utf-8?B?bnZnOW1Ia3NuMjB0cnlVNlJYTi9YbDRLL045RWxHQTNRT0FySVJIV3RkanR6?= =?utf-8?B?QXZxemxEWFhXUWNBbzcwZGpNNTEwazhmS2pEWm95cVdaZndnaXBUWERUa1Nj?= =?utf-8?B?eU8wZElCVk9SY0xzb0lWYXRaWFQzYXgyTm5iNmtoaDAzaTBQdG5RNnVtOGZO?= =?utf-8?B?anRXSk5wdG1idGlJOGYxeDJTTkhjQmtjanNpb1J4UFhqZEsxMzZFeE1OQjZ2?= =?utf-8?B?dzZqS0gzcWNrcjlKQm5zb095U1p6T1dqTlBsS2cxN3ZTRkhYbHphUmFEdVZp?= =?utf-8?B?d3dhOXAwMjlsMnhhalcrZmt5cktka1MzL294dlN6VXlZcm5qeHJTQnBTL1lv?= =?utf-8?B?WHArVlFNZFNhbWVmcWJzM3VYOGZEcFhSZHJTRzRuN2dVSjhDZVBic3NBdXBh?= =?utf-8?B?OWI0alNjRkRwaEV6UEVJa3ozK2l2R204enR1N1kwZE1GL3RodFFSTXZJZ3ZU?= =?utf-8?B?eWRPZFkwUUh2b0Y5eWk4MDFuYnFMWi9GbllyRDI4N2FYQm41eVIrRzdNd3p1?= =?utf-8?B?MENXYjRURGM2Rmcwc2JJRndlOEI2UENZUGRMbGpPODE3aHF1SFRvWUFKN3Az?= =?utf-8?B?M3cyRGtic3ZRbi9nc0ZXVTJncnlwMUV6VmN3UFZCc3B6NmlSTVZyQkVUL3dP?= =?utf-8?B?VVNzVFRJa0xmOGFENlE3VzQ0UVVjcVFmbk5Hdmc4di9mOUhVVmZyUnkxKzNl?= =?utf-8?Q?+6uU2DyMWj04ies5GVXTZAU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ef7475e3-065e-4a77-d669-08d9d768140c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 14:13:46.5560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q212Fq5NddcCRlQ+hxMUntZFyUbjN+xPv7jVEOz7t8SP5aFRhrLzNkOObnIUELlM3nR8/EXFWUb7aTbkRUsQIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5925 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/24/2021 7:24 PM, Tudor Cornea wrote: > The Kni kthreads seem to be re-scheduled at a granularity of roughly > 1 millisecond right now, which seems to be insufficient for performing > tests involving a lot of control plane traffic. > > Even if KNI_KTHREAD_RESCHEDULE_INTERVAL is set to 5 microseconds, it > seems that the existing code cannot reschedule at the desired granularily, > due to precision constraints of schedule_timeout_interruptible(). > > In our use case, we leverage the Linux Kernel for control plane, and > it is not uncommon to have 60K - 100K pps for some signaling protocols. > > Since we are not in atomic context, the usleep_range() function seems to be > more appropriate for being able to introduce smaller controlled delays, > in the range of 5-10 microseconds. Upon reading the existing code, it would > seem that this was the original intent. Adding sub-millisecond delays, > seems unfeasible with a call to schedule_timeout_interruptible(). > > KNI_KTHREAD_RESCHEDULE_INTERVAL 5 /* us */ > schedule_timeout_interruptible( > usecs_to_jiffies(KNI_KTHREAD_RESCHEDULE_INTERVAL)); > > Below, we attempted a brief comparison between the existing implementation, > which uses schedule_timeout_interruptible() and usleep_range(). > > We attempt to measure the CPU usage, and RTT between two Kni interfaces, > which are created on top of vmxnet3 adapters, connected by a vSwitch. > > insmod rte_kni.ko kthread_mode=single carrier=on > > schedule_timeout_interruptible(usecs_to_jiffies(5)) > kni_single CPU Usage: 2-4 % > [root@localhost ~]# ping 1.1.1.2 -I eth1 > PING 1.1.1.2 (1.1.1.2) from 1.1.1.1 eth1: 56(84) bytes of data. > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=2.70 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=1.00 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=1.99 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=0.985 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=1.00 ms > > usleep_range(5, 10) > kni_single CPU usage: 50% > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=0.338 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=0.150 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=0.123 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=0.139 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=0.159 ms > > usleep_range(20, 50) > kni_single CPU usage: 24% > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=0.202 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=0.170 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=0.171 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=0.248 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=0.185 ms > > usleep_range(50, 100) > kni_single CPU usage: 13% > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=0.537 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=0.257 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=0.231 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=0.143 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=0.200 ms > > usleep_range(100, 200) > kni_single CPU usage: 7% > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=0.716 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=0.167 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=0.459 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=0.455 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=0.252 ms > > usleep_range(1000, 1100) > kni_single CPU usage: 2% > 64 bytes from 1.1.1.2: icmp_seq=1 ttl=64 time=2.22 ms > 64 bytes from 1.1.1.2: icmp_seq=2 ttl=64 time=1.17 ms > 64 bytes from 1.1.1.2: icmp_seq=3 ttl=64 time=1.17 ms > 64 bytes from 1.1.1.2: icmp_seq=4 ttl=64 time=1.17 ms > 64 bytes from 1.1.1.2: icmp_seq=5 ttl=64 time=1.15 ms > > Upon testing, usleep_range(1000, 1100) seems roughly equivalent in > latency and cpu usage to the variant with schedule_timeout_interruptible(), > while usleep_range(100, 200) seems to give a decent tradeoff between > latency and cpu usage, while allowing users to tweak the limits for > improved precision if they have such use cases. > > Disabling RTE_KNI_PREEMPT_DEFAULT, interestingly seems to lead to a > softlockup on my kernel. > > Kernel panic - not syncing: softlockup: hung tasks > CPU: 0 PID: 1226 Comm: kni_single Tainted: G W O 3.10 #1 > [] dump_stack+0x19/0x1b > [] panic+0xcd/0x1e0 > [] watchdog_timer_fn+0x160/0x160 > [] __run_hrtimer.isra.4+0x42/0xd0 > [] hrtimer_interrupt+0xe7/0x1f0 > [] smp_apic_timer_interrupt+0x67/0xa0 > [] apic_timer_interrupt+0x6d/0x80 > > This patch also attempts to remove this option. > > References: > [1] https://www.kernel.org/doc/Documentation/timers/timers-howto.txt > > Signed-off-by: Tudor Cornea > > --- > v4: > * Removed RTE_KNI_PREEMPT_DEFAULT configuration option > v3: > * Fixed unwrapped commit description warning > * Changed from hrtimers to Linux High Precision Timers in docs > * Added two tabs at the beginning of the new params description. > Stephen correctly pointed out that the descriptions of the parameters > for the Kni module are nonstandard w.r.t existing kernel code. > I was thinking to preserve compatibility with the existing parameters > of the Kni module for the moment, while an additional clean-up patch > could format the descriptions to be closer to the kernel standard. > v2: > * Fixed some spelling errors Reviewed-by: Ferruh Yigit Only it doesn't apply cleanly because of the latest changes in the kni, can you please rebase it? Please keep the review tag in the new version after rebase.