From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EEFCF1B59C for ; Thu, 10 Jan 2019 09:45:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 00:45:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,460,1539673200"; d="scan'208";a="137022483" Received: from pgomulkx-mobl.ger.corp.intel.com (HELO [10.251.85.183]) ([10.251.85.183]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2019 00:45:13 -0800 To: Thomas Monjalon , Bruce Richardson Cc: David Marchand , dev@dpdk.org References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com> <1557339.2CBSiR8abE@xps> From: "Burakov, Anatoly" Message-ID: Date: Thu, 10 Jan 2019 08:45:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1557339.2CBSiR8abE@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 08:45:16 -0000 On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > 09/01/2019 21:51, Bruce Richardson: >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: >>> On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov >>> <[1]anatoly.burakov@intel.com> wrote: >>> >>> Currently, while EAL does depend on librte_compat as far as common >>> meson build is concerned, for some reason the headers for that >>> library are not added into the list of includes. This is fixed in >>> Linuxapp-specific meson file, but is absent from FreeBSD meson file. >>> This worked fine up until recently, when an rte_compat dependency >>> was added to rte_log, which is a common header. Fix this issue by >>> adding librte_compat includes to common EAL meson file. >>> Fixes: 844514c73569 ("eal: build with meson") >>> Fixes: a8499f65a1d1 ("log: add missing experimental tag") >>> Cc: [2]bruce.richardson@intel.com >>> Cc: [3]david.marchand@redhat.com >>> Cc: [4]stable@dpdk.org >>> Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com> >>> >>> lgtm, thanks. >>> Reviewed-by: David Marchand <[6]david.marchand@redhat.com> >>> -- >>> David Marchand >>> >> Agreed. >> One other point I'd make is that having compat as a separate library seems >> a little like overkill to me - it's just one header file! Is there a reason >> why we don't just move it into the EAL where everyone can use it without >> having to specify another dependency? > > +1 for moving compat into EAL. > Presumably the reason to keep it separate would be to enable depending on it for libraries that EAL itself depends on (i.e. kvargs). -- Thanks, Anatoly